Arch Linux User Repository

There have been multiple changes to how vkquake should be built, and I have come up with the following changes to vkquake-git after talking with the current maintainer of vkquake on discord

diff --git a/PKGBUILD b/PKGBUILD
index d4444d9..324ca42 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -3,7 +3,7 @@

 pkgname=vkquake-git
 _gitname=vkquake
-pkgver=1.00.0.r9.ge4daddf
+pkgver=1.20.0.r17.g6841487
 pkgrel=1
 pkgdesc="A modern Quake 1 engine. Forked from Fitzquake. This version contains Vulkan API support (git-latest)."
 arch=('i686' 'x86_64')
@@ -11,21 +11,18 @@ conflicts=('vkquake')
 provides=('vkquake')
 url="https://github.com/Novum/vkquake"
 license=('GPL2')
-depends=(
-        'git' 'flac' 'glibc' 'libgl' 'libmad' 'libmikmod' 'libogg' 
-        'libvorbis' 'libx11' 'opusfile' 'sdl2' 'vulkan-validation-layers'
-        'tslib'
-)
+depends=('git' 'flac' 'glibc' 'libgl' 'libmad' 'libmikmod' 'libogg' 
+   'libvorbis' 'libx11' 'opusfile' 'sdl2')
+makedepends=('vulkan-validation-layers' 'meson' 'bash')
 install=$pkgname.install
 source=('git+https://github.com/Novum/vkquake.git'
    'vkquake.desktop'
    'vkquake.png'
    'vkquake.svg')
-md5sums=('SKIP'
-    '202e1efb0491aafcc9de6f44295dc272'
-    'ffc3103326b0378af770b1318cf4e7e6'
-    'd6b9553906db3cbadfbc40aafafa2b5d')
-
+sha256sums=('SKIP'
+            '67dbe6ea9b08c4df3322e3f4cc4555ab6583589e241304db607736188a5c686b'
+            '571ab4f163b31f1f56de2b5b9103cf1b48a4baf4f0ef9514bb4b2da6ba899755'
+            'f9f5e7d79ed7ef1eb4dfaf35d5e5e72c271c0d068153f07505ab57a19425f09e')
 pkgver() {

   cd "$_gitname"
@@ -36,23 +33,29 @@ pkgver() {
 build() {

   cd "$srcdir/$_gitname"
+  mkdir build && cd build
+
+  meson ../ \
+  --prefix /usr \
+  --libexecdir lib \
+  --sbindir bin \
+  --buildtype plain \
+  --auto-features enabled \
+  --wrap-mode nodownload \
+  -D use_codec_mp3=enabled \
+  -D use_codec_flac=enabled \
+  -D use_codec_vorbis=enabled \
+  -D use_codec_opus=enabled

-  # clean
-  msg "Cleaning make files"
-  make -C Quake clean
+  # Print config
+  meson configure ./

-  msg "Starting make..."
-  make -C Quake \
-       $(maybe_debug) \
-       STRIP=": do not strip:" \
-       DO_USERDIRS=1 \
-       USE_SDL2=1 \
-       USE_CODEC_FLAC=1 \
-       USE_CODEC_OPUS=1 \
-       USE_CODEC_MIKMOD=1 \
-       USE_CODEC_UMX=1
-  make -C Misc/vq_pak
+  # Compile vkquake binary
+  ninja

+  # Package vkquake.pak
+  cd "$srcdir/$_gitname/Misc/vq_pak"
+  make
 }

 package() {
@@ -60,18 +63,19 @@ package() {
   cd "$srcdir/$_gitname"

   # Install main binary
-  install -Dm755 Quake/vkquake "$pkgdir"/usr/bin/vkquake
-
-  # pak files
-  install -Dm644 "$srcdir/$_gitname/Misc/vq_pak/vkquake.pak" "$pkgdir/usr/share/games/vkquake/vkquake.pak"
+  install -Dm755 build/vkquake "$pkgdir"/usr/bin/vkquake

   # Make doc dir
   mkdir -p $pkgdir/usr/share/doc/vkquake/
+  mkdir -p $pkgdir/usr/share/games/vkquake/
+
+  # pak files
+  install -Dm644 "$srcdir/$_gitname/Misc/vq_pak/vkquake.pak" "$pkgdir/usr/share/games/vkquake/vkquake.pak" 

   # supplemental files
   install -Dm644 "$srcdir/$_gitname.desktop" "$pkgdir/usr/share/applications/vkquake.desktop"
   install -Dm644 "$srcdir/$_gitname.png" "$pkgdir/usr/share/pixmaps/vkquake.png"
   install -Dm644 "$srcdir/$_gitname.svg" "$pkgdir/usr/share/icons/vkquake.svg"
   install -Dm644 readme.md "$pkgdir"/usr/share/doc/vkquake/readme.md
-
 }
+

vulkan-validation-layers are a make dependency, not a dependency required for actually running the game. It would be greatly appreciated if it was moved from depends to makedepends

ok first off, why add $(maybe_debug) to the build(), maybe_debug would be run as a command and its output stdout > stdin to the variable $().

So whats the point, as no compiler group has a maybe_debug executable. there is no such application. - If you are trying to get the end-user to view the PKGBUILD and edit it, please make a #COMMENT: instead.

it breaks automated builds. Thank You.

Second. Please add the following changes. PKGBUILD: add options=(!strip), make replace build options as a CFLAG instead, LDFLAG append required files for build options, as the makefile is not appended by them.

Changes are shown here, along with my Makefile patch to allow including system Global LDFLAGS(As they are replaced by default in the Makefile.: https://github.com/Novum/vkQuake/pull/129) Changes: https://gist.github.com/kingtiger01/947d0c78a271df03c09cbb303f86ee1d

.. search the vkquake issues tracker: https://github.com/Novum/vkQuake/issues/117 [mikeyd@archboxmtd ~]$ locate "SDL_vulkan.h" /usr/include/SDL2/SDL_vulkan.h That is provided in https://www.archlinux.org/packages/extra/x86_64/sdl2/, which this depends on. This is right below where the rest of the SDL files are picked up and should be in the same directory as SDL.h https://github.com/Novum/vkQuake/blob/2bcd8e9c98043fcb3425b3eab5042a8cf04681d8/Quake/gl_vidsdl.c#L30 $ sudo pacman -Qo "/usr/include/SDL2/SDL_vulkan.h" /usr/include/SDL2/SDL_vulkan.h is owned by sdl2 2.0.7-1 The build testing fine in a brand new clean chroot just now (https://wiki.archlinux.org/index.php/DeveloperWiki:Building_in_a_Clean_Chroot) I'm not entirely sure why are you are having an issue then.

cant be installed, again gl_vidsdl.c:32:10: error fatal: SDL_vulkan.h: No existe el fichero o el directorio #include "SDL_vulkan.h" ^~~~~~~~~~~~~~ compilación terminada. make: *** [Makefile:192: gl_vidsdl.o] Error 1 make: se sale del directorio '/tmp/yaourt-tmp-edo/aur-vkquake-git/src/vkquake/Quake' ==> ERROR: Se produjo un fallo en build(). Cancelando...

removing /usr/local/lib/libSDL2-2.0.so.0 solve the issue

but I cant symlink since vkquake doesnt have any libts-1.0.so.0 library. Reinstalling the game doesnt change anything

This was a similar issue like those of ut2004 and is likely due to the latest tslib: {quote} Latest update of tslib broke this game for me. In case if someone got problem launching it because of missing libts, try this command from root: # ln -s /usr/lib/libts-1.2.so.0 /opt/ut2004/System/libts-1.0.so.0 {quote} Arch is shipping libts-1.3.so.0 now, so rebuild the package or symlink it. See: https://www.archlinux.org/packages/extra/x86_64/tslib/