Package Details: vscodium-bin-marketplace 1.56.0-4

Git Clone URL: https://aur.archlinux.org/vscodium-bin-marketplace.git (read-only, click to copy)
Package Base: vscodium-bin-marketplace
Description: Enable vscode marketplace in vscodium-bin
Upstream URL: https://marketplace.visualstudio.com/vscode
Licenses: unknown
Submitter: sperg512
Maintainer: sperg512 (Icelk)
Last Packager: sperg512
Votes: 18
Popularity: 2.73
First Submitted: 2020-12-04 13:48
Last Updated: 2021-05-10 17:54

Dependencies (2)

Required by (0)

Sources (2)

Latest Comments

1 2 3 Next › Last »

sperg512 commented on 2021-05-10 18:01

sorry for spamming releases but I think i've solved the problem where the package doesn't work

doesn't need to be updated with the package anymore as now the hook actually works

@sainnhe I got it working, there's now a vscodium-bin-features package. Not sure if the feature adding works because idk how to test but yeah

sperg512 commented on 2021-05-10 17:18

ok fixed, in the future if this happens just updpkgsums

@GeBo thats what this package has always done, same with code-marketplace.

GeBo commented on 2021-05-10 13:15

I get the same error as ewertoni. md5sum of product.json.patch does not match.

When I open the patch, I see that https://open-vsx.org/ is being replaced by https://marketplace.visualstudio.com/ with a cache to https://vscode.blob.core.windows.net/.

ewertonl commented on 2021-05-10 11:11

I'm getting this when trying to install

==> Validating source files with md5sums...
    vscodium-bin-marketplace.hook ... Passed
    product.json.patch ... FAILED
==> ERROR: One or more files did not pass the validity check!
Failed to build vscodium-bin-marketplace

sperg512 commented on 2021-04-16 14:10

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaAAAAAAAAAAAAA

@macxcool can you try the following:

  • reinstall vscodium-bin

  • get your product.json (/usr/share/vscodium-bin/app/resources/product.json) and save it to another file

  • reinstall vscodium-bin-marketplace

  • attach the error that occurs and the product.json file

thanks

macxcool commented on 2021-04-15 14:36

Still getting:

patching file /usr/share/vscodium-bin/resources/app/product.json
Hunk #1 FAILED at 140.
1 out of 3 hunks FAILED -- saving rejects to file /usr/share/vscodium- 
bin/resources/app/product.json.rej
error: command failed to execute correctly

sperg512 commented on 2021-04-14 18:37

@macxcool fixed

@sainnhe alright, I'll look at that later. Thanks

macxcool commented on 2021-04-12 23:04

I get this on upgrading:

patching file /usr/share/vscodium-bin/resources/app/product.json
Unreversed patch detected!  Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file /usr/share/vscodium- 
bin/resources/app/product.json.rej
error: command failed to execute correctly

If you want to see my product.json, it's here: https://pastebin.com/WM9QvzDG

sainnhe commented on 2021-04-06 09:32

I just tried to get settings sync work on vscodium by git apply this patch to code-features, but unfortunately the sync failed in vscodium (it works nicely in code oss). I'm not sure what happened, you can get it a try.

diff --git a/.SRCINFO b/.SRCINFO
index 6470334..d7d029c 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -14,8 +14,8 @@ pkgbase = code-features
    conflicts = code-features
    source = code-features.hook
    source = patch.sh
-   md5sums = 5d5bd889095a60ffbf1918d5a2a08bdb
-   md5sums = 5af300de3e3efbfd071425b832c83313
+   md5sums = c7060228752c46d4e0126cdd4a68ce01
+   md5sums = 4d53ee04925c53e27922a5f8fdaa524f

 pkgname = code-features

diff --git a/PKGBUILD b/PKGBUILD
index a514419..a886e6c 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -14,8 +14,8 @@ conflicts=('code-features')
 install="${pkgname}.install"
 source=("${pkgname}.hook"
         'patch.sh')
-md5sums=('5d5bd889095a60ffbf1918d5a2a08bdb'
-         '5af300de3e3efbfd071425b832c83313')
+md5sums=('c7060228752c46d4e0126cdd4a68ce01'
+         '4d53ee04925c53e27922a5f8fdaa524f')

 package() {
   install -Dm 644 "${srcdir}/${pkgname}.hook" "${pkgdir}/usr/share/libalpm/hooks/${pkgname}.hook"
diff --git a/code-features.hook b/code-features.hook
index cb5e790..ffd1e44 100644
--- a/code-features.hook
+++ b/code-features.hook
@@ -3,6 +3,7 @@ Operation = Install
 Operation = Upgrade
 Type = Path
 Target = usr/lib/code/product.json
+Target = usr/share/vscodium-bin/resources/app/product.json

 [Action]
 Description = [code-features] Patching product.json...
diff --git a/patch.sh b/patch.sh
index 3adeea2..ebb86bc 100755
--- a/patch.sh
+++ b/patch.sh
@@ -1,14 +1,34 @@
 #!/usr/bin/env sh

 if [ "${1}" = "-R" ]; then
-  sed -i -e 's/^[[:blank:]]*"nameLong":.*/\t"nameLong": "Code - OSS",/' \
-    -e 's/^[[:blank:]]*"extensionAllowedProposedApi":.*/\t"extensionAllowedProposedApi": ["ms-vscode.vscode-js-profile-flame", "ms-vscode.vscode-js-profile-table", "ms-vscode.github-browser", "ms-vscode.github-richnav"],/' \
-    -e '/^[[:blank:]]*"extensionSyncedKeys/d' \
-    /usr/lib/code/product.json
+   if [ -f /usr/lib/code/product.json ]; then
+       sed -i -e 's/^[[:blank:]]*"nameLong":.*/\t"nameLong": "Code - OSS",/' \
+           -e 's/^[[:blank:]]*"extensionAllowedProposedApi":.*/\t"extensionAllowedProposedApi": ["ms-vscode.vscode-js-profile-flame", "ms-vscode.vscode-js-profile-table", "ms-vscode.github-browser", "ms-vscode.github-richnav"],/' \
+           -e '/^[[:blank:]]*"extensionSyncedKeys/d' \
+           /usr/lib/code/product.json
+   fi
+   if [ -f /usr/share/vscodium-bin/resources/app/product.json ]; then
+       sed -i -e 's/^[[:blank:]]*"nameLong":.*/\t"nameLong": "VSCodium",/' \
+           -e 's/^[[:blank:]]*"extensionAllowedProposedApi":.*/\t"extensionAllowedProposedApi": ["ms-vscode.vscode-js-profile-flame", "ms-vscode.vscode-js-profile-table", "ms-vscode.github-browser", "ms-vscode.github-richnav", "ms-vscode.remotehub", "ms-vscode.remotehub-insiders", "ms-vsliveshare.vsliveshare", "ms-vscode-remote.remote-ssh", "ms-vscode.cpptools", "ms-azuretools.vscode-docker", "visualstudioexptteam.vscodeintellicode", "ms-python.python"],/' \
+           -e '/^[[:blank:]]*"extensionSyncedKeys/d' \
+           -e '/^[[:blank:]]*"linkProtectionTrustedDomains/d' \
+           -e '/^[[:blank:]]*"serverDataFolderName/i\\t"linkProtectionTrustedDomains": ["https://open-vsx.org"],' \
+           /usr/share/vscodium-bin/resources/app/product.json
+   fi
 else
-  sed -i -e 's/^[[:blank:]]*"nameLong":.*/\t"nameLong": "Visual Studio Code",/' \
-    -e 's/^[[:blank:]]*"extensionAllowedProposedApi":.*/\t"extensionAllowedProposedApi": ["GitHub.codespaces", "GitHub.vscode-pull-request-github-insiders", "GitHub.vscode-pull-request-github", "Microsoft.vscode-nmake-tools", "ms-ai-tools.notebook-renderers", "ms-dotnettools.dotnet-interactive-vscode", "ms-python.gather", "ms-python.python", "ms-toolsai.jupyter", "ms-toolsai.vscode-ai", "ms-toolsai.vscode-ai-remote", "ms-vscode-remote.remote-containers-nightly", "ms-vscode-remote.remote-containers", "ms-vscode-remote.remote-ssh-edit-nightly", "ms-vscode-remote.remote-ssh-edit", "ms-vscode-remote.remote-ssh-nightly", "ms-vscode-remote.remote-ssh", "ms-vscode-remote.remote-wsl-nightly", "ms-vscode-remote.remote-wsl", "ms-vscode-remote.remote-wsl-recommender", "ms-vscode-remote.vscode-remote-extensionpack-nightly", "ms-vscode-remote.vscode-remote-extensionpack", "ms-vscode.azure-account", "ms-vscode.azure-sphere-tools-ui", "ms-vscode.azure-sphere-tools", "ms-vscode.github-browser", "ms-vscode.github-richnav", "ms-vscode.js-debug-nightly", "ms-vscode.js-debug", "ms-vscode.lsif-browser", "ms-vscode.vscode-js-profile-flame", "ms-vscode.vscode-js-profile-table", "ms-vscode.vscode-selfhost-test-provider", "ms-vsliveshare.cloudenv-explorer", "ms-vsliveshare.cloudenv", "ms-vsliveshare.vsliveshare", "ms-vsonline.vsonline", "dbaeumer.vscode-eslint"],/' \
-    -e '/^[[:blank:]]*"extensionSyncedKeys/d' \
-    -e '/^[[:blank:]]*"extensionAllowedProposedApi/a\\t"extensionSyncedKeys": { "ritwickdey.liveserver": ["liveServer.setup.version"] }, "linkProtectionTrustedDomains": ["https:\/\/*.visualstudio.com", "https:\/\/*.microsoft.com", "https:\/\/aka.ms", "https:\/\/vscode-auth.github.com", "https:\/\/*.gallerycdn.vsassets.io", "https:\/\/github.com\/microsoft\/", "https:\/\/github.com\/MicrosoftDocs\/", "https:\/\/login.microsoftonline.com"], "auth": { "loginUrl": "https:\/\/login.microsoftonline.com\/common\/oauth2\/authorize", "tokenUrl": "https:\/\/login.microsoftonline.com\/common\/oauth2\/token", "redirectUrl": "https:\/\/vscode-redirect.azurewebsites.net\/", "clientId": "aebc6443-996d-45c2-90f0-388ff96faa56" }, "configurationSync.store": { "url": "https:\/\/vscode-sync.trafficmanager.net\/", "stableUrl": "https:\/\/vscode-sync.trafficmanager.net\/", "insidersUrl": "https:\/\/vscode-sync-insiders.trafficmanager.net\/", "canSwitch": false, "authenticationProviders": { "microsoft": { "scopes": ["https:\/\/management.core.windows.net\/.default", "offline_access"] }, "github": { "scopes": ["user:email"] } } },' \
-    /usr/lib/code/product.json
+   if [ -f /usr/lib/code/product.json ]; then
+       sed -i -e 's/^[[:blank:]]*"nameLong":.*/\t"nameLong": "Visual Studio Code",/' \
+           -e 's/^[[:blank:]]*"extensionAllowedProposedApi":.*/\t"extensionAllowedProposedApi": ["GitHub.codespaces", "GitHub.vscode-pull-request-github-insiders", "GitHub.vscode-pull-request-github", "Microsoft.vscode-nmake-tools", "ms-ai-tools.notebook-renderers", "ms-dotnettools.dotnet-interactive-vscode", "ms-python.gather", "ms-python.python", "ms-toolsai.jupyter", "ms-toolsai.vscode-ai", "ms-toolsai.vscode-ai-remote", "ms-vscode-remote.remote-containers-nightly", "ms-vscode-remote.remote-containers", "ms-vscode-remote.remote-ssh-edit-nightly", "ms-vscode-remote.remote-ssh-edit", "ms-vscode-remote.remote-ssh-nightly", "ms-vscode-remote.remote-ssh", "ms-vscode-remote.remote-wsl-nightly", "ms-vscode-remote.remote-wsl", "ms-vscode-remote.remote-wsl-recommender", "ms-vscode-remote.vscode-remote-extensionpack-nightly", "ms-vscode-remote.vscode-remote-extensionpack", "ms-vscode.azure-account", "ms-vscode.azure-sphere-tools-ui", "ms-vscode.azure-sphere-tools", "ms-vscode.github-browser", "ms-vscode.github-richnav", "ms-vscode.js-debug-nightly", "ms-vscode.js-debug", "ms-vscode.lsif-browser", "ms-vscode.vscode-js-profile-flame", "ms-vscode.vscode-js-profile-table", "ms-vscode.vscode-selfhost-test-provider", "ms-vsliveshare.cloudenv-explorer", "ms-vsliveshare.cloudenv", "ms-vsliveshare.vsliveshare", "ms-vsonline.vsonline", "dbaeumer.vscode-eslint"],/' \
+           -e '/^[[:blank:]]*"extensionSyncedKeys/d' \
+           -e '/^[[:blank:]]*"extensionAllowedProposedApi/a\\t"extensionSyncedKeys": { "ritwickdey.liveserver": ["liveServer.setup.version"] }, "linkProtectionTrustedDomains": ["https:\/\/*.visualstudio.com", "https:\/\/*.microsoft.com", "https:\/\/aka.ms", "https:\/\/vscode-auth.github.com", "https:\/\/*.gallerycdn.vsassets.io", "https:\/\/github.com\/microsoft\/", "https:\/\/github.com\/MicrosoftDocs\/", "https:\/\/login.microsoftonline.com"], "auth": { "loginUrl": "https:\/\/login.microsoftonline.com\/common\/oauth2\/authorize", "tokenUrl": "https:\/\/login.microsoftonline.com\/common\/oauth2\/token", "redirectUrl": "https:\/\/vscode-redirect.azurewebsites.net\/", "clientId": "aebc6443-996d-45c2-90f0-388ff96faa56" }, "configurationSync.store": { "url": "https:\/\/vscode-sync.trafficmanager.net\/", "stableUrl": "https:\/\/vscode-sync.trafficmanager.net\/", "insidersUrl": "https:\/\/vscode-sync-insiders.trafficmanager.net\/", "canSwitch": false, "authenticationProviders": { "microsoft": { "scopes": ["https:\/\/management.core.windows.net\/.default", "offline_access"] }, "github": { "scopes": ["user:email"] } } },' \
+           /usr/lib/code/product.json
+   fi
+   if [ -f /usr/share/vscodium-bin/resources/app/product.json ]; then
+       sed -i -e 's/^[[:blank:]]*"nameLong":.*/\t"nameLong": "Visual Studio Code",/' \
+           -e 's/^[[:blank:]]*"extensionAllowedProposedApi":.*/\t"extensionAllowedProposedApi": ["GitHub.codespaces", "GitHub.vscode-pull-request-github-insiders", "GitHub.vscode-pull-request-github", "Microsoft.vscode-nmake-tools", "ms-ai-tools.notebook-renderers", "ms-dotnettools.dotnet-interactive-vscode", "ms-python.gather", "ms-python.python", "ms-toolsai.jupyter", "ms-toolsai.vscode-ai", "ms-toolsai.vscode-ai-remote", "ms-vscode-remote.remote-containers-nightly", "ms-vscode-remote.remote-containers", "ms-vscode-remote.remote-ssh-edit-nightly", "ms-vscode-remote.remote-ssh-edit", "ms-vscode-remote.remote-ssh-nightly", "ms-vscode-remote.remote-ssh", "ms-vscode-remote.remote-wsl-nightly", "ms-vscode-remote.remote-wsl", "ms-vscode-remote.remote-wsl-recommender", "ms-vscode-remote.vscode-remote-extensionpack-nightly", "ms-vscode-remote.vscode-remote-extensionpack", "ms-vscode.azure-account", "ms-vscode.azure-sphere-tools-ui", "ms-vscode.azure-sphere-tools", "ms-vscode.github-browser", "ms-vscode.github-richnav", "ms-vscode.js-debug-nightly", "ms-vscode.js-debug", "ms-vscode.lsif-browser", "ms-vscode.vscode-js-profile-flame", "ms-vscode.vscode-js-profile-table", "ms-vscode.vscode-selfhost-test-provider", "ms-vsliveshare.cloudenv-explorer", "ms-vsliveshare.cloudenv", "ms-vsliveshare.vsliveshare", "ms-vsonline.vsonline", "dbaeumer.vscode-eslint"],/' \
+           -e '/^[[:blank:]]*"extensionSyncedKeys/d' \
+           -e '/^[[:blank:]]*"extensionAllowedProposedApi/a\\t"extensionSyncedKeys": { "ritwickdey.liveserver": ["liveServer.setup.version"] }, "linkProtectionTrustedDomains": ["https:\/\/*.visualstudio.com", "https:\/\/*.microsoft.com", "https:\/\/aka.ms", "https:\/\/vscode-auth.github.com", "https:\/\/*.gallerycdn.vsassets.io", "https:\/\/github.com\/microsoft\/", "https:\/\/github.com\/MicrosoftDocs\/", "https:\/\/login.microsoftonline.com"], "auth": { "loginUrl": "https:\/\/login.microsoftonline.com\/common\/oauth2\/authorize", "tokenUrl": "https:\/\/login.microsoftonline.com\/common\/oauth2\/token", "redirectUrl": "https:\/\/vscode-redirect.azurewebsites.net\/", "clientId": "aebc6443-996d-45c2-90f0-388ff96faa56" }, "configurationSync.store": { "url": "https:\/\/vscode-sync.trafficmanager.net\/", "stableUrl": "https:\/\/vscode-sync.trafficmanager.net\/", "insidersUrl": "https:\/\/vscode-sync-insiders.trafficmanager.net\/", "canSwitch": false, "authenticationProviders": { "microsoft": { "scopes": ["https:\/\/management.core.windows.net\/.default", "offline_access"] }, "github": { "scopes": ["user:email"] } } },' \
+           -e '/^[[:blank:]]*"linkProtectionTrustedDomains/d' \
+           /usr/share/vscodium-bin/resources/app/product.json
+   fi
 fi

sainnhe commented on 2021-04-06 09:01

Hello, I'm the maintainer of code-marketplace. I recently added support for blocked extensions like remote-ssh and pylance, and also the builtin settings sync. You can consider adding these features to your package, see the pinned comment here.


Since the patch file contains many parts that are changed frequently, I think it might be better to use sed instead of patch to modify product.json. You can consider changing your code, too.


Another thing is that, the support of blocked extensions and settings sync is actually done via tokens like extensionAllowedProposedApi and extensionSyncedKeys which are directly copied from visual-studio-code-bin and visual-studio-code-insiders-bin, but they might be changed frequently, and I can't guarantee to keep them always up to date, so can we maintain these packages together?

Since the newest version of code-marketplace and code-features(-insiders) uses shell script to implement the patching, I think it's possible to support both code oss and vscodium in one package by detecting the installation path, by doing so we can save a lot of work.