Arch Linux User Repository

This package should not be marked as out of date unless it stops working. If that's the case, proving a diff to get it working is hugely appreciated. See the latest comments for potential solutions and conversation regarding the issue.

Hello, I'm the maintainer of code-marketplace. I recently added support for blocked extensions like remote-ssh and pylance, and also the builtin settings sync. You can consider adding these features to your package, see the pinned comment here.

Since the patch file contains many parts that are changed frequently, I think it might be better to use sed instead of patch to modify product.json. You can consider changing your code, too.

Another thing is that, the support of blocked extensions and settings sync is actually done via tokens like extensionAllowedProposedApi and extensionSyncedKeys which are directly copied from visual-studio-code-bin and visual-studio-code-insiders-bin, but they might be changed frequently, and I can't guarantee to keep them always up to date, so can we maintain these packages together?

Since the newest version of code-marketplace and code-features(-insiders) uses shell script to implement the patching, I think it's possible to support both code oss and vscodium in one package by detecting the installation path, by doing so we can save a lot of work.

GOD DAMn it

@CoolGenie can you post your relevant product.json lines? search for extensionsGallery and post a couple (5 or so) lines before and after that line

Hello, Again the patch error appears

patching file /usr/share/vscodium-bin/resources/app/product.json
Unreversed patch detected!  Ignore -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file /usr/share/vscodium-bin/resources/app/product.json.rej
error: command failed to execute correctly
(1/1) reinstalling vscodium-bin-marketplace                                                                                                                        [####################################################################################################] 100%
patching file /usr/share/vscodium-bin/resources/app/product.json
Hunk #1 succeeded at 137 with fuzz 2.
Hunk #2 succeeded at 152 with fuzz 2.

@sperg512 indeed, now it seems ok. thanks.

@coxackie ok i believe i've fixed it, try it now

@coxackie actually, I think the product.json changed significantly. I just checked and it's the exact same as yours, though I'm not getting the same errors. Later today I'll get a fix out.

@sperg512 If this issue happens only to me, feel free to unflag it from being out-of-date. It happened again with the 1.53.1 update. I don't know how it is possible that we get different product.json files...

My product.json starts with:

{
  "nameShort": "VSCodium",
  "nameLong": "VSCodium",
  "applicationName": "codium",
  "dataFolderName": ".vscode-oss",
  "win32MutexName": "vscodium",
  "licenseName": "MIT",
  "licenseUrl": "https://github.com/microsoft/vscode/blob/master/LICENSE.txt",
  "win32DirName": "VSCodium",
  "win32NameVersion": "VSCodium",

Lines 143-154 are

  "linkProtectionTrustedDomains": ["https://open-vsx.org"],
  "serverDataFolderName": ".vscode-server-oss",
  "commit": "8490d3dde47c57ba65ec40dd192d014fd2113496",
  "date": "2021-02-07T22:11:04.635Z",
  "checksums": {
    "vs/base/parts/sandbox/electron-browser/preload.js": "MUMCvm6iaIqaXHwrKp2iqw",
    "vs/workbench/workbench.desktop.main.js": "PEF0e60OlqpgNhUl8Tp8Mw",
    "vs/workbench/workbench.desktop.main.css": "BJFlGB2Mco0wkZ9J8NuHtg",
    "vs/workbench/services/extensions/node/extensionHostProcess.js": "v0mlOi9e/XiGfrdOxA7mYg",
    "vs/code/electron-browser/workbench/workbench.html": "FA7IN1fg7dReTGbMS997BQ",
    "vs/code/electron-browser/workbench/workbench.js": "i9bcRl/GLU9touwW05IMfA"
  }

I can change everything manually at this point, of course, but I do not understand how there is discrepancy from yours. I even did a complete clean install of vscodium-bin.

@coxackie interesting, what's in those lines in your product.json?

After updating to 1.53.0, I get:

patching file /usr/share/vscodium-bin/resources/app/product.json
Hunk #1 FAILED at 1.
Hunk #2 succeeded at 152 with fuzz 2.
1 out of 2 hunks FAILED -- saving rejects to file /usr/share/vscodium-bin/resources/app/product.json.rej
error: command failed to execute correctly

Here are the contents of /usr/share/vscodium-bin/resources/app/product.json.rej:

*** product.json  2020-12-03 19:59:40.000000000 -0500
--- product_new.json    2020-12-04 08:39:09.547338599 -0500
***************
*** 1,9 ****
  {
    "serverDataFolderName": ".vscode-server-oss",
-   "linkProtectionTrustedDomains": ["https://open-vsx.org"],
    "extensionsGallery": {
!     "itemUrl": "https://open-vsx.org/vscode/item",
!     "serviceUrl": "https://open-vsx.org/vscode/gallery"
    },
    "quality": "stable",
    "keyboardShortcutsUrlWin": "https://go.microsoft.com/fwlink/?linkid=832145",
--- 1,9 ----
  {
    "serverDataFolderName": ".vscode-server-oss",
    "extensionsGallery": {
!     "serviceUrl": "https://marketplace.visualstudio.com/_apis/public/gallery",
!     "cacheUrl": "https://vscode.blob.core.windows.net/gallery/index",
!     "itemUrl": "https://marketplace.visualstudio.com/items"
    },
    "quality": "stable",
    "keyboardShortcutsUrlWin": "https://go.microsoft.com/fwlink/?linkid=832145",