Package Details: walc 0.3.3-2

Git Clone URL: https://aur.archlinux.org/walc.git (read-only, click to copy)
Package Base: walc
Description: An unofficial WhatsApp Desktop client for linux systems.
Upstream URL: https://github.com/WAClient/WALC
Keywords: internet messaging whatsapp whatsapp-web
Licenses: GPL3
Conflicts: walc
Provides: walc
Submitter: MisconceivedSec
Maintainer: HaCk0
Last Packager: HaCk0
Votes: 0
Popularity: 0.000000
First Submitted: 2022-05-28 15:52 (UTC)
Last Updated: 2024-04-30 10:00 (UTC)

Latest Comments

« First ‹ Previous 1 2

MisconceivedSec commented on 2022-06-24 05:27 (UTC) (edited on 2022-06-24 05:28 (UTC) by MisconceivedSec)

Hey @opensorcerer, thank you for pointing that out to me, as this is my first PKGBUILD I just wrote everything into the package() function as if it were a bash script.
As per your advice, I split the process into the correct functions, and used gendesk for creating the desktop entry.
Thanks a lot.

opensorcerer commented on 2022-06-23 18:11 (UTC) (edited on 2022-06-23 18:14 (UTC) by opensorcerer)

The build process (npm install, npm run) should be in build(), everything before that in prepare(). package() should only be used for putting what needs to be in the .zst into $pkg, see the manual.

Also, small typo in L29:

StarupNotify=true"[…]

You could consider using gendesk for Desktop entry generation, see the wiki.

See also the Node.js packaging guidelines for more ideas for optimization.