Arch Linux User Repository

It looks like url of sources has changed...

Another option is to use static declarations for the affected variables, however the extern declaration is probably closer to the original.

diff --git a/PKGBUILD b/PKGBUILD
index f20f9c9..d0eb47b 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -5,7 +5,7 @@
 # Contributor: Andrea Scarpino <andrea@archlinux.org>

 pkgname=webalizer
-_geodbver=20190101
+_geodbver=20210401
 pkgver=2.23.08.${_geodbver}
 _pkgver=2.23-08
 pkgrel=4
@@ -22,7 +22,7 @@ source=(
   "webalizer-2.23-08-memmove.patch"
 )
 sha512sums=('219cae51d2e938e2d9327ce52c9c814e7436c821b05cb528dc88f548bdfbd7a6ad69c235b078d6af194c3a1d38029fde7dde9e8b81ad6fd93c236ca76a49811b'
-            '79eb8db5761a5943e50c7db3a09430d926d4e15e3a1e0f6d4d310030dc551d314cad5c5a998d327db851d52a69b41069cfd4d68b96ed671d68feb1e19124885d'
+            '7eb5708b913952b276d602da5fcfe7d6e79c999ea6b2f8dacbbe476715105c4775de5a828e79c01820737ea66c3509db16ed2ac82a08054414877d147b28ea1d'
             'bb23d68fed2f130c8a752d1b219974e44e3f32dd40ecf6b236cdbede58d4bfbb15a8901e5ee76fbfae1ce1bd3d3664b28d0bd79b85e15949ff420ec262be21c1'
             '538b7cf51303581df7d1710073d55563fda4c64841a6d7dac8d47e0b037975b9ad4ad4973db5807226480ecea0e0783c445400bd53b60d0d7308559946ce3b4a')

diff --git a/src/webalizer-2.23-08/dns_resolv.c b/src/webalizer-2.23-08/dns_resolv.c
index 925a46b..60ac64c 100644
--- a/src/webalizer-2.23-08/dns_resolv.c
+++ b/src/webalizer-2.23-08/dns_resolv.c
@@ -78,11 +78,11 @@ DBC      *geo_dbc  = NULL;                     /* GeoDB database cursor    */

 struct   dns_child child[MAXCHILD];            /* DNS child pipe data      */

-DNODEPTR host_table[MAXHASH];                  /* hostname/ip hash table   */
+static DNODEPTR host_table[MAXHASH];                  /* hostname/ip hash table   */

-char     buffer[BUFSIZE];                      /* log file record buffer   */
-char     tmp_buf[BUFSIZE];                     /* used to temp save above  */
-struct   utsname system_info;                  /* system info structure    */
+static char     buffer[BUFSIZE];                      /* log file record buffer   */
+static char     tmp_buf[BUFSIZE];                     /* used to temp save above  */
+static struct   utsname system_info;                  /* system info structure    */

 int      raiseSigChild = 1;

diff --git a/src/webalizer-2.23-08/hashtab.c b/src/webalizer-2.23-08/hashtab.c
index 814e096..e1f6992 100644
--- a/src/webalizer-2.23-08/hashtab.c
+++ b/src/webalizer-2.23-08/hashtab.c
@@ -85,7 +85,7 @@ ANODEPTR am_htab[MAXHASH];
 SNODEPTR sr_htab[MAXHASH];                    /* search string table      */
 INODEPTR im_htab[MAXHASH];                    /* ident table (username)   */
 #ifdef USE_DNS
-DNODEPTR host_table[MAXHASH];                 /* DNS hash table           */
+static DNODEPTR host_table[MAXHASH];                 /* DNS hash table           */
 #endif  /* USE_DNS */

 /*********************************************/
diff --git a/src/webalizer-2.23-08/hashtab.h b/src/webalizer-2.23-08/hashtab.h
index df5d3cf..e0353a6 100644
--- a/src/webalizer-2.23-08/hashtab.h
+++ b/src/webalizer-2.23-08/hashtab.h
@@ -74,7 +74,7 @@ extern ANODEPTR am_htab[MAXHASH];
 extern SNODEPTR sr_htab[MAXHASH];             /* search string table       */
 extern INODEPTR im_htab[MAXHASH];             /* ident table (username)    */
 #ifdef USE_DNS
-extern DNODEPTR host_table[MAXHASH];          /* DNS resolver table        */
+static DNODEPTR host_table[MAXHASH];          /* DNS resolver table        */
 #endif

 extern int    put_hnode(char *, int, u_int64_t, u_int64_t, double,

I was able to compile again by removing the buffer, tmp_buf, utsname and host_table definitions from dns_resolv.c, and adding them with extern-declarations to webalizer.h. I don't know if using a central buffer is possible here or if this will break things, I'll need to test it yet. host_table actually was already extern declared in hashtab.h, so I don't know why dns_resolv.c created it's own instance.

Apparently the error is caused by GCC 10, which changed the default from -fcommon to -fno-common, so the fix is close to the pre-GCC-10-behaviour: https://gcc.gnu.org/gcc-10/porting_to.html Adding -fcommon to the CFLAGS should also fix the issue, though.

diff --git a/PKGBUILD b/PKGBUILD
index f20f9c9..d0eb47b 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -5,7 +5,7 @@
 # Contributor: Andrea Scarpino <andrea@archlinux.org>

 pkgname=webalizer
-_geodbver=20190101
+_geodbver=20210401
 pkgver=2.23.08.${_geodbver}
 _pkgver=2.23-08
 pkgrel=4
@@ -22,7 +22,7 @@ source=(
   "webalizer-2.23-08-memmove.patch"
 )
 sha512sums=('219cae51d2e938e2d9327ce52c9c814e7436c821b05cb528dc88f548bdfbd7a6ad69c235b078d6af194c3a1d38029fde7dde9e8b81ad6fd93c236ca76a49811b'
-            '79eb8db5761a5943e50c7db3a09430d926d4e15e3a1e0f6d4d310030dc551d314cad5c5a998d327db851d52a69b41069cfd4d68b96ed671d68feb1e19124885d'
+            '7eb5708b913952b276d602da5fcfe7d6e79c999ea6b2f8dacbbe476715105c4775de5a828e79c01820737ea66c3509db16ed2ac82a08054414877d147b28ea1d'
             'bb23d68fed2f130c8a752d1b219974e44e3f32dd40ecf6b236cdbede58d4bfbb15a8901e5ee76fbfae1ce1bd3d3664b28d0bd79b85e15949ff420ec262be21c1'
             '538b7cf51303581df7d1710073d55563fda4c64841a6d7dac8d47e0b037975b9ad4ad4973db5807226480ecea0e0783c445400bd53b60d0d7308559946ce3b4a')

diff --git a/src/webalizer-2.23-08/dns_resolv.c b/src/webalizer-2.23-08/dns_resolv.c
index 925a46b..51da9dc 100644
--- a/src/webalizer-2.23-08/dns_resolv.c
+++ b/src/webalizer-2.23-08/dns_resolv.c
@@ -78,12 +78,6 @@ DBC      *geo_dbc  = NULL;                     /* GeoDB database cursor    */

 struct   dns_child child[MAXCHILD];            /* DNS child pipe data      */

-DNODEPTR host_table[MAXHASH];                  /* hostname/ip hash table   */
-
-char     buffer[BUFSIZE];                      /* log file record buffer   */
-char     tmp_buf[BUFSIZE];                     /* used to temp save above  */
-struct   utsname system_info;                  /* system info structure    */
-
 int      raiseSigChild = 1;

 time_t runtime;
diff --git a/src/webalizer-2.23-08/webalizer.h b/src/webalizer-2.23-08/webalizer.h
index 5fad7ac..d4d2075 100644
--- a/src/webalizer-2.23-08/webalizer.h
+++ b/src/webalizer-2.23-08/webalizer.h
@@ -299,4 +299,8 @@ extern u_int64_t jdate(int,int,int);
 extern char      from_hex(char);
 extern int       isipaddr(char *);

+extern struct    utsname system_info;        /* system info structure    */
+extern char      buffer[];                   /* log file record buffer   */
+extern char      tmp_buf[];                  /* used to temp save above  */
+
 #endif  /* _WEBALIZER_H */

I'm also getting the multiple definition errors when compiling. Any ideas?

Furthermore,

ftp://ftp.mrunix.net/pub/webalizer/geodb/webalizer-geodb-20190101.tgz

does not exist anymore. One may use the most recent version to the current date:

ftp://ftp.mrunix.net/pub/webalizer/geodb/webalizer-geodb-20210401.tgz

(just set _geodbver=20210401 in the PKGBUILD)

I'm getting the same error. Any solutions? Thanks.

Can't build this:

gcc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -D_FORTIFY_SOURCE=2 -DETCDIR=\"/etc\" -DGEODB_LOC=\"/usr/share/GeoDB\" 
-DPACKAGE_NAME=\"webalizer\" -DPACKAGE_TARNAME=\"webalizer\" -DPACKAGE_VERSION=\"V2.23\" -DPACKAGE_STRING=\"webalizer\ V2.23\" 
-DPACKAGE_BUGREPORT=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 
-DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_GETOPT_H=1 -DHAVE_MATH_H=1 
-DHAVE_SYS_SOCKET_H=1 -DUSE_GEOIP -DUSE_BZIP -DUSE_DNS  -c graphs.c
gcc -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -o webalizer webalizer.o hashtab.o linklist.o preserve.o parser.o output.o dns_resolv.o graphs.o -lGeoIP -lbz2 -ldb -lgd -lpng -lz -lm 
/usr/bin/ld: dns_resolv.o:(.bss+0x11c0): multiple definition of `buffer'; webalizer.o:(.bss+0x5040): first defined here
/usr/bin/ld: dns_resolv.o:(.bss+0x1c0): multiple definition of `tmp_buf'; webalizer.o:(.bss+0x4040): first defined here
/usr/bin/ld: dns_resolv.o:(.bss+0x21c0): multiple definition of `host_table'; hashtab.o:(.bss+0x0): first defined here
/usr/bin/ld: dns_resolv.o:(.bss+0x20): multiple definition of `system_info'; webalizer.o:(.bss+0x7760): first defined here
collect2: error: ld returned 1 exit status
make: *** [Makefile:47: webalizer] Error 1
==> ERROR: A failure occurred in build().

Hey, thanks for notifying me about this and providing the patch!

I have updated the package accordingly.

geodb v20170501 has been removed from upstream. Use this patch:

diff --git a/PKGBUILD b/PKGBUILD
index 57cc52f..abbf3ab 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -5,7 +5,7 @@
 # Contributor: Andrea Scarpino <andrea@archlinux.org>

 pkgname=webalizer
-_geodbver=20170501
+_geodbver=20190101
 pkgver=2.23.08.${_geodbver}
 _pkgver=2.23-08
 pkgrel=3
@@ -22,7 +22,7 @@ source=(
   "webalizer-2.23-08-memmove.patch"
 )
 sha512sums=('219cae51d2e938e2d9327ce52c9c814e7436c821b05cb528dc88f548bdfbd7a6ad69c235b078d6af194c3a1d38029fde7dde9e8b81ad6fd93c236ca76a49811b'
-            'fd6d3a2ab333806762af7600c8d043fb02a13089c43bb96e8afb1269e92c749329005b8f64d6439113b79d3ad080b1c2f70d54c42d72eb60cb08962d6ad86958'
+            '79eb8db5761a5943e50c7db3a09430d926d4e15e3a1e0f6d4d310030dc551d314cad5c5a998d327db851d52a69b41069cfd4d68b96ed671d68feb1e19124885d'
             'bb23d68fed2f130c8a752d1b219974e44e3f32dd40ecf6b236cdbede58d4bfbb15a8901e5ee76fbfae1ce1bd3d3664b28d0bd79b85e15949ff420ec262be21c1'
             '538b7cf51303581df7d1710073d55563fda4c64841a6d7dac8d47e0b037975b9ad4ad4973db5807226480ecea0e0783c445400bd53b60d0d7308559946ce3b4a')