Arch Linux User Repository

Many electron packages grab electron-flags.conf for custom flags, or have their own defined such as brave-flags.conf or slack-flags.conf. I'd like to propose doing so for WebCord as well.

Patch example:

diff --git a/.gitignore b/.gitignore
index 3e0458e..d87f5ec 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,4 +3,5 @@
 !.SRCINFO
 !PKGBUILD
 !webcord.desktop
+!webcord
 !buildInfo.json
diff --git a/PKGBUILD b/PKGBUILD
index 567a5d7..373e3f0 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -17,12 +17,14 @@ source=(
     "${_snapshot}.tar.gz::${url}/archive/v${pkgver}.tar.gz"
     "buildInfo.json"
     "webcord.desktop"
+    "webcord"
 )

 sha256sums=(
     '27723a752ca4750eda16b7a1f93b785160f5f85460cc3a395a86f75c917db62a'
     'c803c7227982fad22390a8d6d11f3707171d5e9b1a394731a6a07773eab75b1f'
     '5923151d1cc05d7e2ab0cb2103921f5f3985e08e48c74e7aa12003b32c0e2bae'
+    'f2c4bc5ba00e469aafb75a5435e6dcfe133aee44f6e9025a8b60ac4b6577078c'
 )

 prepare() {
@@ -61,6 +63,9 @@ package() {
     install -Dm644 "${source[2]}" \
         -t "${pkgdir}/usr/share/applications"

+    install -Dm755 "${source[3]}" \
+        -t "${pkgdir}${bin}"
+
     cd "${_snapshot}"

     cp -r --parents "package.json" "app" "sources/"{"assets","translations"} "node_modules" \
@@ -73,8 +78,6 @@ package() {
     ln -sT "${lib}/sources/assets/icons/app.png" "${pkgdir}${icons}/${pkgname}.png"

     local exec="${pkgdir}${bin}/${pkgname}"
-    echo -n "#!/bin/sh
-exec '${_electron}' '${lib}' \"\$@\"
-" > "${exec}"
-    chmod +x "${exec}"
+
+    echo -n "exec '${_electron}' '${lib}' \${USER_FLAGS} \"\$@\"" >> "${exec}"
 }
diff --git a/webcord b/webcord
new file mode 100755
index 0000000..87f6472
--- /dev/null
+++ b/webcord
@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+XDG_CONFIG_HOME="${XDG_CONFIG_HOME:-$HOME/.config}"
+
+# Allow users to override command-line options
+USER_FLAGS_FILE="$XDG_CONFIG_HOME/webcord-flags.conf"
+if [[ -f $USER_FLAGS_FILE ]]; then
+   USER_FLAGS="$(cat $USER_FLAGS_FILE | sed 's/#.*//')"
+fi
+

The above patch reads out flags from webcord-flags.conf, electron-flags.conf might be preferable.

Well, the app don't use any new functionality. 26-27 bumps were only to resolve bugs we are not affected here.

So I think for now there is more sense (and more convinient for users) to stick with Electron verison from the official repo.

The release page for 4.5.0 says it's using Electron 27 now, shouldn't the dependency here be updated accordingly?

It totally does. esbuild supports glob syntax since 0.19.0.

And the current package version in official repository is 0.19.4. So you somehow have an outdated package version.

@Hanabishi Nonsense. My system is up to date, and I always build in a clean chroot, as per https://wiki.archlinux.org/title/DeveloperWiki:Building_in_a_clean_chroot

And if you read the error, this has nothing to do with any out-of-date package or being unable to find libraries, etc. as would indicate an outdated system.

@eclairevoyant, update your system.

▲ [WARNING] Cannot find base config file "@tsconfig/strictest/tsconfig.json" [tsconfig.json]

    tsconfig.json:2:15:
      2 │     "extends": "@tsconfig/strictest/tsconfig.json",
        ╵                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

✘ [ERROR] Could not resolve "sources/code/**/*.ts"

  It looks like you are trying to use glob syntax (i.e. "*") with esbuild. This syntax is typically handled by your shell, and isn't handled by esbuild itself. You must expand glob syntax first before passing your paths to esbuild.

1 warning and 1 error
==> ERROR: A failure occurred in build().
    Aborting...

4.4.0-2 steps back to Electron 25 because of #452. At least temporarily.

Done.

The description needs to be updated to reflect the repository