Package Details: xchat-otr 0.3-2

Git Clone URL: (read-only)
Package Base: xchat-otr
Description: Off-the-Record Messaging (OTR) plugin for the XChat IRC client
Upstream URL:
Licenses: GPL
Submitter: reztho
Maintainer: reztho
Last Packager: reztho
Votes: 19
Popularity: 0.000000
First Submitted: 2009-05-03 14:33
Last Updated: 2015-10-11 11:03

Dependencies (5)

Required by (0)

Sources (2)

Latest Comments

reztho commented on 2013-11-19 14:47

I'm not going to update the package... it's not really needed as long as it still works.

1. Ok, it makes sense, although not so important. In this case it doesn't apply, but for other AUR packages maybe the only option is downloading the source from FTP. In those cases there is no other solution for the users than modifying the package to their needs.
2. There is no problem in being explicit when you can. It's "defensive programming", but IMHO the less context you need to remember when reading how a package works, the better for everyone.
3. {} isn't used for arrays in bash, arrays are (). Curly braces are for variable expansion which could be used for some useful things. Besides that, actually, for me, it makes it easier to read and make it less prone to failures. Look for other packages, I'm not the only one.
4. There was a time where those were really needed to prevent makepkg to fail. If you are a recent Arch user, you didn't know about that. Nowadays it's not needed.
5. The same than above. This is an ancient PKGBUILD. Check the date of first submission.
6. It's not silly and unnecessary to remove the license file. You already have the GPL2 license in the licenses package which you should already have in your system. What would be really silly is to fill your hard drive with the same file for every GPL package you install.

About the GPL/GPL2 license marking, check this file in your system:

And the wiki:

As long as the "or" still there in "L)GPL - (L)GPLv2 or any later version" and the GPL file (which it's you can check it's a symbolic link to the GPL2 file) remains the same, it's correct.

When pacman finally removes some of the features this package still uses, I'll update the package. Thanks.

kyrias commented on 2013-11-19 13:59

1) The `source` line should be changed to 'http://' instead of 'ftp://' as ftp is blocked for some people behind firewalls and such.
2) Why do you use the full paths all the time when you've `cd`'d into the directory already?
3) Don't enclose every variable in `{}`'s, they're not arrays and it makes it harder to read.
4) Remove all those nasty `|| return 1`'s
5) The build() function needs to be split up into build() and package()
6) The license array should be 'GPL2' since it's not licensed under 'GPL2 or later' which is what 'GPL' is for. And why remove the installed LICENSE file? It's silly and unnecessary.

Here's a cleaned up one:

reztho commented on 2012-11-13 16:08

Thx, BlueMatt

BlueMatt commented on 2012-11-13 02:51

oh, and the cmake line needs -DLIBOTR_LIBRARY=/usr/lib/

BlueMatt commented on 2012-11-13 02:46

This needs a dep on libotr3 (not libotr) and a
find . -type f -print0 | xargs -0 sed -i 's|libotr/|libotr3/|g'
before the cmake line in the PKGBUILD to get it to build right.