Package Details: xournalpp-git 1.1.0.r104.gc6ae5c7fc-1

Git Clone URL: https://aur.archlinux.org/xournalpp-git.git (read-only, click to copy)
Package Base: xournalpp-git
Description: Xournal++ is a handwriting Notetaking software with PDF annotation support. Supports Pen input like Wacom Tablets.
Upstream URL: https://github.com/xournalpp/xournalpp
Keywords: annotation notebook pdf tablet
Licenses: GPL2
Conflicts: xournalpp
Submitter: ridikulusrat
Maintainer: youduda
Last Packager: youduda
Votes: 22
Popularity: 0.039828
First Submitted: 2015-10-18 01:29
Last Updated: 2021-11-17 00:44

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 9 10 Next › Last »

macxcool commented on 2018-11-23 17:32

I'm sorry. This is a bit beyond me and I don't have the time right now to learn how all of this fits together. I'd like to disown this package for now if someone is willing to take over. All I ask is that the MATHTEX option be left on.

siliconninja commented on 2018-11-23 17:24

After a few recent commits to change the CMakeLists.txt (to get GTK3 to be more compatible with the CMake build scripts), I get a patch merge error. This is because of this line in the PKGBUILD. https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=xournalpp-git#n29

==> Starting prepare()... patching file CMakeLists.txt Hunk #1 FAILED at 322. 1 out of 1 hunk FAILED -- saving rejects to file CMakeLists.txt.rej ==> ERROR: A failure occurred in prepare(). Aborting... Error making: xournalpp-git

You might want to change the patch. https://aur.archlinux.org/cgit/aur.git/tree/fixpoppler.patch?h=xournalpp-git

This is because Poppler 0.61.1 from Poppler's git sources is now being built if you say set (BUILD_POPPLER ON) after line 112 in the CMakeLists.txt in the root directory. (edit: not by default). https://github.com/xournalpp/xournalpp/blob/master/CMakeLists.txt#L120

https://github.com/xournalpp/xournalpp/blob/master/src/pdf/popplerdirect/workaround/CMakeLists.txt

You could change this to 0.67.0 or 0.69.0 if someone can redo the GooLikely workaround (https://github.com/swiftgeek/xournalpp/commit/12a409c8afc3c3ea8c8afebb67377c29e3d90035.patch) in https://github.com/xournalpp/xournalpp/blob/master/src/control/settings/MetadataManager.cpp

(Note that src/pdf/popplerdirect/workaround/ directory has no more 0.64.0 folder, and it's building from git instead of locally.)

macxcool commented on 2018-11-22 19:56

Perfect. Thanks youduda. I'll check out the changes tonight.

youduda commented on 2018-11-22 18:19

What I meant with "Once this is merged and all patches are removed" is that all patches that were previously applied including the fixpoppler.patch from me can be removed in the PKGBUILD file, because all of them are merged into the official repository. Due to that, currently xournalpp doesn't depend on the poppler-glib package. I adopted the PKGBUILD file yesterday to meet these changes.

JuniorJPDJ commented on 2018-11-22 17:16

@youduda your commit was merged and package doesn't compile again with patch. I commented patching in pkgbuild and got it working on my side.

youduda commented on 2018-11-22 00:33

As there are currently a huge amount of changes to the build process and code the patch is already outdated agian. I created a pull request (https://github.com/xournalpp/xournalpp/pull/352) to merge an improved version of fixpoppler.patch into the official repository. Once this is merged and all patches are removed, building should work again, even with custom -DPOPPLER_GIT_VER.

macxcool commented on 2018-11-21 23:16

I tried compiling without the fixpoppler.patch. It doesn't finish the install: CMake Error at cmake_install.cmake:69 (file): file INSTALL cannot find "/home/mark/build/arch/xournalpp-git/src/xournalpp/build/poppler-prefix/src/poppler-build/libpoppler.so.72.0.0"

macxcool commented on 2018-11-21 23:00

Please don't flag packages out-of-date just because something needs to be fixed. Out-of-date means that there has been a release upstream or something like that. In this case the new gtk3 requirement was a valid reason. The lack of need for the patch is not. I will check into getting rid of the patch and will update if it isn't needed anymore.

macxcool commented on 2018-11-21 12:16

I'm trying out your PKGBUILD, youduda. If it works for me as well, I'll upload it.

youduda commented on 2018-11-20 23:49

It will take some time until compiling with poppler 0.71 will work see https://github.com/xournalpp/xournalpp/issues/283. This PKGBUILD file currently works for me: https://github.com/youduda/xournalpp-git/blob/master/PKGBUILD