Arch Linux User Repository

Hi maintainer.

Please exercise caution regarding the comment left by user friday13

The comment is a copy of a previous one left by user MarsSeed. The link goes to a github repository with NO CHANGES OR BUGFIXES

The only change in the NUbem000 repo is the addition of a mysterious binary file called xwinwrap.

This is extremely suspicious to me.

I believe this could be a potential vector for attack, though I have not tried anything myself as I no longer use X11.

Thank you.

But there is a newer fork with some bug fixes https://github.com/NUbem000/xwinwrap

@MarsSeed Thanks, I'll switch to this fork.

ujjwal96 hasn't updated his source since 2017.

But there is a newer fork with some bug fixes (last commit in 2021):

https://github.com/takase1121/xwinwrap.git

Thanks! I updated the PKGBUILD with the changes from your diff.

Unfortunately I no longer have the time to maintain this package as it is not used on my systems anymore.

Here's git diff to fix building in a clean chroot, try to correct the license, and clean up a lot of unnecessary cruft in the PKGBUILD:

diff --git a/LICENSE b/LICENSE
new file mode 100644
index 0000000..f9692fa
--- /dev/null
+++ b/LICENSE
@@ -0,0 +1,22 @@
+Copyright © 2005 Novell, Inc.
+
+Permission to use, copy, modify, distribute, and sell this software
+and its documentation for any purpose is hereby granted without
+fee, provided that the above copyright notice appear in all copies
+and that both that copyright notice and this permission notice
+appear in supporting documentation, and that the name of
+Novell, Inc. not be used in advertising or publicity pertaining to
+distribution of the software without specific, written prior permission.
+Novell, Inc. makes no representations about the suitability of this
+software for any purpose. It is provided "as is" without express or
+implied warranty.
+
+NOVELL, INC. DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE,
+INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN
+NO EVENT SHALL NOVELL, INC. BE LIABLE FOR ANY SPECIAL, INDIRECT OR
+CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS
+OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT,
+NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION
+WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+
+Author: David Reveman <davidr@novell.com>
diff --git a/PKGBUILD b/PKGBUILD
index 4129a8b..25b223e 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -3,73 +3,36 @@
 ##

 _gitname=xwinwrap
-# shellcheck disable=SC2034
 pkgname=xwinwrap-git
-# shellcheck disable=SC2034
 pkgdesc="Fork of XwinWrap from ujjwal96 on GitHub"
-# shellcheck disable=SC2034
 pkgver=r5.ec32e9b
-# shellcheck disable=SC2034
 pkgrel=1
-# shellcheck disable=SC2034
-arch=('any')
-# shellcheck disable=SC2034
+arch=('x86_64')
 makedepends=('git')
-# shellcheck disable=SC2034
-depends=()
-# shellcheck disable=SC2034
-optdepends=()
-# shellcheck disable=SC2034
+depends=('libx11' 'libxext' 'libxrender')
 provides=('xwinwrap')
-# shellcheck disable=SC2034
 conflicts=('xwinwrap')
-# shellcheck disable=SC2034
-license=('Other/Open Source')
-# shellcheck disable=SC2034
+license=(custom)
 url="https://github.com/ujjwal96/xwinwrap"
-
-##
-# The SHA256 is constantly changing since this is
-# pulled from git so skip the verification check
-##
-# shellcheck disable=SC2034
-sha256sums=('SKIP')
-# shellcheck disable=SC2034
-source=("${_gitname}::git+${url}#branch=master")
-
-###############################################################################
+source=("git+${url}#branch=master"
+        LICENSE)
+sha256sums=('SKIP'
+            '9b445615c864519effd483f60c9877de671708f6c3807841ef1514490ae61903')

 pkgver() {
-  # shellcheck disable=SC2154
-  cd "$srcdir/$_gitname" || {
-        msg "Error couldn't cd into $srcdir/$_gitname"
-        return 1
-  }
-
-  # From
-  # https://wiki.archlinux.org/index.php/VCS_package_guidelines#The_pkgver.28.29_function
-  # If there are no tags then use number of revisions since beginning of the history:
+  cd $_gitname
   printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"
 }

 build() {
-  # shellcheck disable=SC2154
-  cd "$srcdir/$_gitname" || {
-        msg "Error couldn't cd into $srcdir/$_gitname"
-        return 1
-  }
-
-  make
+  make -C $_gitname
 }

 package() {
-  cd "$srcdir/$_gitname" || {
-        msg "Error couldn't cd into $srcdir/$_gitname"
-        return 1
-  }
+  # From https://bazaar.launchpad.net/~shantanu-goel/xwinwrap/devel/view/head:/xwinwrap.c
+  install -Dm644 LICENSE "${pkgdir}"/usr/share/licenses/$pkgname/LICENSE

-  chmod 755 xwinwrap
-  mkdir -p "${pkgdir}/usr/bin"
-  cp xwinwrap "${pkgdir}/usr/bin/xwinwrap"
+  cd $_gitname
+  install -D xwinwrap "${pkgdir}"/usr/bin/xwinwrap
 }