Arch Linux User Repository

Wonderful, thanks for your swift action.

Thanks, I really appreciate those suggestions! I've added them in. They definitely make a lot more sense.

PS: One could even argue that all makefiles, text files etc cetera in the doc directory is the source for the html documentation so that only html and css should be copied to the final doc directory. E.g.:

install -dm0755 "${pkgdir}/usr/share/doc/${pkgname}/ja"
install -m0644 doc/*.{css,html} "${pkgdir}/usr/share/doc/${pkgname}/"
install -m0644 doc/ja/*.{css,html} "${pkgdir}/usr/share/doc/${pkgname}/ja/"

However, you are the packager and I respect your decision.

Thanks for packaging yash.

It seems in v2.55-1 yash.1 and ja/yash.1 (each weighing in at around 400 kB) are copied to "${pkgdir}/usr/share/doc/${pkgname}", although these manpages are already installed in compressed form in the official manpage hierarchy. May I suggest that these be removed from the package. E.g. in package() after the cp -r doc/* stanza:

rm "${pkgdir}/usr/share/doc/${pkgname}/yash.1"
rm "${pkgdir}/usr/share/doc/${pkgname}/ja/yash.1"

Cheers.

Great, thanks.

Thanks for the suggestions. I've added all but two of them for the following reasons.

provides is not necessary as it's implicit due to yash already being the pkgname. conflicts would only apply to alternatives (like yash-git as you mentioned).

asciidoc does not appear to actually be needed to generate docs. They have already been generated prior to release. However, since I overlooked them before, they're now getting included in the package.

I have a couple of suggestions for the 2.54+ release:

These will conflict other yash packages (such as yash-git):

provides=('yash')
conflicts=('yash')

LTO can safely be enabled:

options=('lto')

It seems asciidoc is necessary for generation of documentation:

makedepends=('asciidoc')

For a package like yash it is prudent to enable a check() function:

check() {
  cd "${pkgname}-${pkgver}"
  make check
}

Enabling double brackets, while not strictly POSIX (I believe), doesn't harm those that don't use it. So in the configure block, we could add:

--enable-double-bracket \

after the line with --enable-dirstack \. That means that all --enable-* will be enabled.

Architectures can be expanded to:

arch=('i686' 'x86_64' 'armv7h' 'aarch64')

Cheers.

Could you please update the url from sourceforge.jp to osdn.jp?

Thanks! <3

Please add ARM architechture to the PKGBUILD file.