Package Details: zfs-dkms 2.2.3-2

Git Clone URL: https://aur.archlinux.org/zfs-dkms.git (read-only, click to copy)
Package Base: zfs-dkms
Description: Kernel modules for the Zettabyte File System.
Upstream URL: https://zfsonlinux.org/
Licenses: CDDL
Provides: SPL-MODULE, zfs, ZFS-MODULE
Submitter: isiachi
Maintainer: kstolp
Last Packager: kstolp
Votes: 160
Popularity: 1.50
First Submitted: 2015-08-31 12:01 (UTC)
Last Updated: 2024-03-13 08:43 (UTC)

Pinned Comments

kstolp commented on 2023-09-29 00:34 (UTC)

When requesting changes, please include detailed reasoning for the change.

kstolp commented on 2023-01-07 09:31 (UTC)

If you receive this error when trying to build, it is because you have not imported the GPG keys used for verification.

==> ERROR: One or more PGP signatures could not be verified!

You have two options:

1) Import the two keys into your keyring. ArchWiki article. You can find the key IDs in the PKGBUILD file, in the validpgpkeys array. (recommended)

2) Alternatively, you can skip this verification by passing the --skippgpcheck argument to makepkg when building. (not recommended)

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 9 10 .. 58 Next › Last »

mabod commented on 2023-11-30 07:03 (UTC)

@bsdice: Have you experienced a performance hit of init_on_alloc? I am aware about the discussion e.g https://github.com/openzfs/zfs/issues/9910 But I do not see any performance difference with several fio benchmarks with multiple parallel threads.

bsdice commented on 2023-11-29 17:46 (UTC) (edited on 2023-11-29 17:47 (UTC) by bsdice)

Personally I am on LTS kernel 6.1 for most machines and will keep in file /etc/modprobe.d/zfs.conf the lines options zfs zfs_bclone_enabled=0 and also options zfs zfs_dmu_offset_next_sync=0 until some grass has grown over the issue. Say a year or two, at least until the next revision of ZFS test suite includes tests for this sort of corruption.

There might be a performance hit with zfs_dmu_offset_next_sync=1 so I keep it off.

I don't need block cloning and also am willing to let LZ4 shrink any hole of zeros instead of ZFS handling sparseness. I realize on VM thin provisioned workloads with many holes things might look different i.e. ProxMox setups.

I also will keep init_on_alloc=0 init_on_free=0 as kernel parameters because of the performance hit for ZFS.

urbenlegend commented on 2023-11-29 17:36 (UTC)

Thanks @kstolp! Appreciate you being so on the ball with all of this!

kstolp commented on 2023-11-29 17:32 (UTC)

@urbenlegend No. As of 2.2.1-2, you do not need to set zfs_dmu_offset_next_sync. The underlying issue was identified and fixed in PR#15571.

urbenlegend commented on 2023-11-29 16:25 (UTC)

As of 2.2.1-2, do we still need zfs_dmu_offset_next_sync=0?

air-g4p commented on 2023-11-25 00:02 (UTC) (edited on 2023-11-25 00:03 (UTC) by air-g4p)

@kstolp Thank you for your much appreciated efforts. zfs-dkms 2.2.1-1 compiles, installs and runs correctly against the current kernel versions of linux, -zen and -hardened.

Cheers

mabod commented on 2023-11-23 17:39 (UTC)

For all who are interested in this topic please read the correpsoning threads on github. E.g. https://github.com/openzfs/zfs/issues/15554 or https://github.com/openzfs/zfs/issues/15526

Summary in short: The issue is also present in zfs version 2.1.x; It seems that block cloning which was introduced with 2.2.0 makes the bug more likely to be triggered. But it can also happen in 2.1.13 without block cloning. Although this is much more unlikely.

It seems that zfs_dmu_offset_next_sync=0 prevents the bug in all cases. Please add this to your system as explained earlier.

FrederickZh commented on 2023-11-23 15:15 (UTC) (edited on 2023-11-23 15:23 (UTC) by FrederickZh)

Another one: If you use ZFS on LUKS, you probably want to

  1. Stay on ZFS v2.2.0
  2. Patch block cloning yourself

Reference: https://github.com/openzfs/zfs/issues/15533

There was a small conflict when applying https://github.com/openzfs/zfs/commit/87e9e828655c250ce064874ff5df16f870c0a52e, and I resolved it at https://github.com/Frederick888/zfs/compare/zfs-2.2.0...zfs-2.2.0-backport-disable-bclone if anyone's interested.

But of course if you haven't zpool upgraded, you can always downgrade ZFS further.

Edit: The thing is that I'm not sure if any of these can be detected by zpool scrub...

mabod commented on 2023-11-23 13:01 (UTC)

block cloning is disabled as of zfs 2.2.1 No need to set options zfs zfs_bclone_enabled=0

Also, you can change the values not only during module load but also during runtime. Simply execute the following command:

echo 0 >/sys/module/zfs/parameters/zfs_dmu_offset_next_sync

FrederickZh commented on 2023-11-23 12:01 (UTC)

Please also add module parameter zfs_dmu_offset_next_sync=0 as per https://github.com/openzfs/zfs/issues/15526#issuecomment-1823857131, folks.

Now it seems as long as you are using coreutils >= 9, even if you didn't zpool upgrade or enable block_cloning, the issue can still happen. It traces back to ZFS v2.1.x.

You can do this by adding a /etc/modprobe.d/zfs.conf with the contents below:

options zfs zfs_bclone_enabled=0
options zfs zfs_dmu_offset_next_sync=0

Re-generate initramfs images if needed, then reboot.

« First ‹ Previous 1 2 3 4 5 6 7 8 9 10 .. 58 Next › Last »