Arch Linux User Repository

I have taken your advice and have started my own package: <https://aur.archlinux.org/packages/zswap/>

I recommended it for replacement because it solves several things with the current zramswap script: 1) uses zramctl 2) allows the existence of zram devices beforehand 3) removes only swap zram devices when called to stop 4) suppports effcient swap reset 5) allows different parameters for each zram module. -- the +2 is to ensure there are 2 free zram devices for other purposes -- the /7 is because the output has 7 lines per zram devices when using bash.

nice, and: 1) i suggest you create a separate package with the -git suffix as per https://wiki.archlinux.org/index.php/VCS_package_guidelines 2) looking at your scripts, it seems to be configured by editing the .sh file directly. this is a general no-no and should be changed to source the config from /etc. 3) just as a quality of code improvement recommendation, you should document your code more - at least the magical constants (num_devices+2, ...raw))/7, ...).

# Contributor: ifaigios <ifaigios_at_gmail_dot_com> # Contributor: Alyssa Hung <deciare@isisiew.org> # Contributor: Matt Brennan # Contributor: falconindy # Contributor: adee # Contributor: mystilleef # Contributor: Mark Lee <mark@markelee.com> pkgname=zramswap pkgver=2 pkgrel=1 pkgdesc="Sets up zram-based swap devices on boot" arch=('any') url="https://github.com/bluerider/zramswap.git" license=('MIT') depends=('bash' 'util-linux') makedepends=('git') source=("git+$url") sha256sums=('SKIP') package() { install -Dm755 "${srcdir}/${pkgname}/zramswap.sh" "${pkgdir}/usr/lib/systemd/scripts/zramswap.sh" install -Dm644 "${srcdir}/${pkgname}/zramswap.service" "${pkgdir}/usr/lib/systemd/system/zramswap.service" }

probably because zramctl was non-existent at the time this package got created... still, peeking quicky at the current solution, there doesn't seem to be much more than modprobe+mkswap+swapon which is the same as systemd-swap uses for zram. zramctl is used there only at the "stop" phase (why not in the "start"?): https://github.com/Nefelim4ag/systemd-swap/blob/master/systemd-swap.sh ...but i might be mistaken - feel free to correct me. patches are welcome and i'll be happy to merge them.

I agree with bluerider, zramctl is already in the Community repository as is systemd-swap. Why not just make a pkgbuild script to install, setup and use these two already existing packages.

Is there a reason why this script doesn't just use zramctl?

Change type unit to simple, improve system start time, and not break zramswap script. [Unit] Description=Zram-based swap (compressed RAM block devices) [Service] ExecStart=/usr/lib/systemd/scripts/zramctrl start ExecStop=/usr/lib/systemd/scripts/zramctrl stop RemainAfterExit=yes [Install] WantedBy=multi-user.target

@beta990: only for swapping You can use it for tmp by aur/zram or by handwork script.