Arch Linux User Repository

Fixed build errors.

@dreieck You can adopt the package to make these changes if you want. I'm not using it anymore myself.

build() fails for me with

==> Starting build()...
mkdir: cannot create directory ‘/home/[...]/.cache/yay/audiotag-thumbnailer/pkg/audiotag-thumbnailer’: Permission denied
mkdir: cannot create directory ‘/home/[...]/.cache/yay/audiotag-thumbnailer/pkg/audiotag-thumbnailer’: Permission denied
==> ERROR: A failure occurred in build().

Please remove your current content of build(), since you are not building anything. You double it (with an error) in package().

Also, consider removing the mkdir -p-line and instead add -D to the install calls.

gconf needs to be a make dependency since gconfpkg is used in audiotag-thumbnailer.install.

And the following packages are needed as dependencies: python2-pillow, python2.

And you need to change in audiotag-thumbnailer the first line #!/usr/bin/python to #!/usr/bin/python2.

And audiotag-thumbnailer.install is errorneous, too: usr/sbin/gconfpkg needs either be /usr/sbin/gconfpkg (absolute patj) or just gconfpkg. And ${pkgname} is not defined in the install script, you must specify it explicitly.
(DIDN'T YOU TEST YOUR PACKAGE?)

And actually, you can completely remove the audiotag-thumbnailer.install and then also the gconf make dependency, since it is provided by pacman hooks automatically.

And you must install a license into /usr/share/licenses/${pkgname}/ since custom:WTFPL is not a common license in /usr/share/licenses/common/.

Diffs for ↗ fixed PKGBUILD, for ↗ fixed audiotag-thumbnailer.install and for ↗ fixed audiotag-thumbnailer:

--- PKGBUILD.org    2023-07-28 13:15:16.187424063 +0200
+++ PKGBUILD    2023-07-28 13:40:25.797527802 +0200
@@ -5,23 +5,20 @@
 pkgver=0.1
-pkgrel=2
+pkgrel=3
 pkgdesc="A nautilus thumbnailer for MP3 and OGG files"
 arch=('any')
-url=""
+url="https://aur.archlinux.org/packages/audiotag-thumbnailer"
 license=("custom:WTFPL")
-depends=('python2-mutagen')
-install=$pkgname.install
-source=("$pkgname" "$pkgname.schemas")
-sha256sums=('f58b15d8702b1fc0a91fe8e4949df7d23f85290b41c0004c490102b3593e339e'
-            '978074b71b4a2ea9ad17890b23ef27733e2567414d6e87defdd562c1a36affbc')
-
-build() {
-   cd $srcdir
-   mkdir -p $pkgdir/usr/{share/gconf/schemas,bin}
-   install -m644 audiotag-thumbnailer.schemas $pkgdir/usr/share/gconf/schemas
-   install -m755 audiotag-thumbnailer $pkgdir/usr/bin
-}
+depends=('python2' 'python2-mutagen' 'python2-pillow')
+source=("$pkgname" "$pkgname.schemas" 'COPYING')
+sha256sums=('f3dedebd1a6e2c784b6585f7d6fe5430102e5347cdc99df227253db9cad4f0fb'
+            '978074b71b4a2ea9ad17890b23ef27733e2567414d6e87defdd562c1a36affbc'
+            'e6d7fd05263cbec72b7e73baa86ca76b27fc419767f64f74762bcb8fba05f037')

 package () {
-  install -Dm644 "$pkgname.schemas" "$pkgdir/usr/share/gconf/schemas/$pkgname.schemas"
-   install -m755 "$pkgname" "$pkgdir/usr/bin/$pkgname"
+   cd "$srcdir"
+   
+   install -Dvm644 audiotag-thumbnailer.schemas "$pkgdir/usr/share/gconf/schemas/audiotag-thumbnailer.schemas"
+   install -Dvm755 audiotag-thumbnailer "$pkgdir/usr/bin/audiotag-thumbnailer"
+   
+   install -Dvm644 COPYING "$pkgdir/usr/share/licenses/$pkgname/COPYING"
 }

--- audiotag-thumbnailer.install.orig   2023-07-28 13:20:52.460780508 +0200
+++ audiotag-thumbnailer.install    2023-07-28 13:27:22.664140652 +0200
@@ -3,3 +3,3 @@
 post_install() {
-  usr/sbin/gconfpkg --install ${pkgname}
+  gconfpkg --install audiotag-thumbnailer
 }
@@ -15,3 +15,3 @@
 pre_remove() {
-  usr/sbin/gconfpkg --uninstall ${pkgname}
+  gconfpkg --uninstall audiotag-thumbnailer
 }

--- audiotag-thumbnailer.org    2023-07-28 13:31:57.757492889 +0200
+++ audiotag-thumbnailer    2023-07-28 13:32:33.587495351 +0200
@@ -1 +1 @@
-#!/usr/bin/python
+#!/usr/bin/python2

And the ↗ created file COPYING, extracted from audiotag-thumbnailer:

#            DO WHAT THE FUCK YOU WANT TO PUBLIC LICENSE 
#                     Version 2, December 2004 
# 
#  Copyright (C) 2011 solsTiCe d'Hiver <solstice.dhiver@gmail.com>
#  Copyright (C) 2004 Sam Hocevar <sam@hocevar.net> 
# 
#  Everyone is permitted to copy and distribute verbatim or modified 
#  copies of this license document, and changing it is allowed as long 
#  as the name is changed. 
# 
#             DO WHAT THE FUCK YOU WANT TO PUBLIC LICENSE 
#    TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION 
# 
#   0. You just DO WHAT THE FUCK YOU WANT TO.

Please fix. Regards and thanks for maintaining!

And consider switching to python3.

Package broken; please kindly fix or delete.