Arch Linux User Repository

While updating to the latest version (needed to use the new browser extension), could you also change the icon installed by this package so it uses the one provided in the source code? The icon which is used by other installers (Windows, AppImage, macOS) is located under \resources\build an it is named icon.png

Thank you for the Desktop entry file fix.

Now, I'd like to point out that buttercup-desktop binary should not be installed under /usr/share. As stated in FHS spec, this folder is for architecture independant files.

The binary should go directly under /usr/bin or /usr/local/bin (which is the same under Arch) OR under /opt (but this location could be debatable). So, you should remove the symlink at the end of package() and just install buttercup-desktop under /usr/bin (you can keep that name or simply use "buttercup").

Please, update the .desktop file. The Exec key is missing minimally an argument to handle URI (to handle Buttercup protocol scheme): %u. Also, the MimeType key is missing, which should tells xdg-settings to add the app to handle the buttercup protocol scheme: MimeType=x-scheme-handler/buttercup;

I suggest you base the rework on the buttercup.desktop file you can extract from the AppImage package. As it is, the desktop integration is incomplete and may lead to Buttercup being unable to add online vaults where identification is needed (Google Drive for example).

now ok. thx.

Thanks @Technetium1. Will check that in a clean chroot.

Failing to build due to multiple errors, here's a log.

buttercup-desktop: /share è già presente nel filesystem

EDIT: Here's an update... I tried later in the day and the build succeeded. Retaining the original details below for history.

I am getting "ERR!" (code E404) entries during the build phase of the package:

==> Starting build()...
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'Buttercup@2.14.2',
npm WARN EBADENGINE   required: { node: '>=16', npm: '>=7' },
npm WARN EBADENGINE   current: { node: 'v14.18.3', npm: '8.4.0' }
npm WARN EBADENGINE }
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated popper.js@1.16.1: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated polished@1.9.3: polished@2.X is no longer supported. Please upgrade to @latest for important bug and security fixes.
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm notice 
npm notice New minor version of npm available! 8.4.0 -> 8.5.0
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.0>
npm notice Run `npm install -g npm@8.5.0` to update!
npm notice 
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@types/debug/-/debug-4.1.7.tgz - Not found
npm ERR! 404 
npm ERR! 404  '@types/debug@https://registry.npmjs.org/@types/debug/-/debug-4.1.7.tgz' is not in this registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /var/tmp/pamac-build-<userid>/buttercup-desktop/src/npm-cache/_logs/2022-02-12T16_05_19_892Z-debug-0.log
==> ERROR: A failure occurred in build().
    Aborting...

Thanks jeffvanss, after creating a fresh chroot I am no getting the same error. Will investigate.

Error: ==> Starting build()... npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142 npm WARN deprecated popper.js@1.16.1: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1 npm WARN deprecated har-validator@5.1.5: this library is no longer supported npm WARN deprecated polished@1.9.3: polished@2.X is no longer supported. Please upgrade to @latest for important bug and security fixes. npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.

added 1345 packages, and audited 1346 packages in 1m

140 packages are looking for funding run npm fund for details

9 vulnerabilities (1 low, 6 moderate, 2 high)

To address all issues, run: npm audit fix

Run npm audit for details. npm notice npm notice New minor version of npm available! 8.4.1 -> 8.5.0 npm notice Changelog: https://github.com/npm/cli/releases/tag/v8.5.0 npm notice Run npm install -g npm@8.5.0 to update! npm notice

Buttercup@2.14.2 build run-s clean build:renderer build:main

Buttercup@2.14.2 clean rimraf build dist

Buttercup@2.14.2 build:renderer webpack --config webpack.config.js --mode production

assets by info 530 KiB [immutable] assets by path .woff2 178 KiB 14 assets assets by path .png 233 KiB 8 assets assets by path .woff 119 KiB asset 82c6b79084c6bd37a016dee9520ad0c1.woff 119 KiB [emitted] [immutable] [from: node_modules/@buttercup/ui/dist/fonts/inter-all-400-normal.woff] (auxiliary name: main) asset 289dd5c3d64cba22f640.woff 81 bytes [emitted] [immutable] [from: node_modules/@buttercup/ui/dist/fonts/inter-all-400-normal.woff] (auxiliary name: main) assets by path icons/.png 62.4 KiB asset icons/website.png 22.1 KiB [emitted] [from: node_modules/@buttercup/ui/dist/icons/website.png] [copied] asset icons/ssh.png 12.5 KiB [emitted] [from: node_modules/@buttercup/ui/dist/icons/ssh.png] [copied] asset icons/login.png 11.4 KiB [emitted] [from: node_modules/@buttercup/ui/dist/icons/login.png] [copied] asset icons/note.png 9.03 KiB [emitted] [from: node_modules/@buttercup/ui/dist/icons/note.png] [copied] asset icons/credit-card.png 7.34 KiB [emitted] [from: node_modules/@buttercup/ui/dist/icons/credit-card.png] [copied] asset index.js 3.84 MiB [emitted] [minimized] (name: main) 1 related asset asset index.html 309 bytes [emitted] orphan modules 1.21 MiB [orphan] 208 modules runtime modules 3.62 KiB 9 modules javascript modules 5.31 MiB 464 modules asset modules 70.3 KiB (javascript) 655 bytes (asset) modules by mime type image/svg+xml 70 KiB 14 modules modules by path ./ 336 bytes (javascript) 655 bytes (asset) ./node_modules/@buttercup/ui/dist/fonts/inter-cyrillic-ext-400-normal.woff2 42 bytes (javascript) 82 bytes (asset) [built] [code generated] + 7 modules json modules 81.3 KiB ./source/shared/i18n/translations/en.json 8.13 KiB [built] [code generated] ./source/shared/i18n/translations/ca_es.json 8.16 KiB [built] [code generated] ./source/shared/i18n/translations/de.json 9.06 KiB [built] [code generated] + 6 modules webpack 5.67.0 compiled successfully in 39989 ms

Buttercup@2.14.2 build:main tsc --build tsconfig.json

npm notice npm notice New minor version of npm available! 8.4.1 -> 8.5.0 npm notice Changelog: https://github.com/npm/cli/releases/tag/v8.5.0 npm notice Run npm install -g npm@8.5.0 to update! npm notice

Buttercup@2.14.2 package:linux electron-builder --linux

• electron-builder version=22.11.11 os=5.16.8-arch1-1 • loaded configuration file=package.json ("build" field) • writing effective config file=dist/builder-effective-config.yaml • rebuilding native dependencies dependencies=keytar@7.7.0 platform=linux arch=x64 • install prebuilt binary name=keytar version=7.7.0 platform=linux arch=x64 napi= • packaging platform=linux arch=x64 electron=15.3.5 appOutDir=dist/linux-unpacked • downloading url=https://github.com/electron/electron/releases/download/v15.3.5/electron-v15.3.5-linux-x64.zip size=98 MB parts=8 • downloaded url=https://github.com/electron/electron/releases/download/v15.3.5/electron-v15.3.5-linux-x64.zip duration=28.529s • building target=AppImage arch=x64 file=dist/Buttercup-linux-x86_64.AppImage • rebuilding native dependencies dependencies=keytar@7.7.0 platform=linux arch=armv7l • install prebuilt binary name=keytar version=7.7.0 platform=linux arch=armv7l napi= • build native dependency from sources name=keytar version=7.7.0 platform=linux arch=armv7l napi= reason=prebuild-install failed with error (run with env DEBUG=electron-builder to get more information) error=prebuild-install info begin Prebuild-install version 6.1.4 prebuild-install WARN install prebuilt binaries enforced with --force! prebuild-install WARN install prebuilt binaries may be out of date! prebuild-install info looking for local prebuild @ prebuilds/keytar-v7.7.0-napi-v3-linux-armv7l.tar.gz prebuild-install info looking for cached prebuild @ /home/jeff/.npm/_prebuilds/c396fd-keytar-v7.7.0-napi-v3-linux-armv7l.tar.gz prebuild-install http request GET https://github.com/atom/node-keytar/releases/download/v7.7.0/keytar-v7.7.0-napi-v3-linux-armv7l.tar.gz prebuild-install http 404 https://github.com/atom/node-keytar/releases/download/v7.7.0/keytar-v7.7.0-napi-v3-linux-armv7l.tar.gz prebuild-install WARN install No prebuilt binaries found (target=3 runtime=napi arch=armv7l libc= platform=linux)

• downloading url=https://github.com/electron-userland/electron-builder-binaries/releases/download/appimage-12.0.1/appimage-12.0.1.7z size=1.6 MB parts=1 • downloaded url=https://github.com/electron-userland/electron-builder-binaries/releases/download/appimage-12.0.1/appimage-12.0.1.7z duration=1.919s ⨯ cannot execute cause=exit status 1 errorOut=npm ERR! code 1 npm ERR! path /home/jeff/.cache/yay/buttercup-desktop/src/buttercup-desktop-2.14.2/node_modules/keytar npm ERR! command failed npm ERR! command sh -c prebuild-install || npm run build npm ERR! > keytar@7.7.0 build npm ERR! > node-gyp rebuild npm ERR! prebuild-install WARN install No prebuilt binaries found (target=3 runtime=napi arch=arm libc= platform=linux) npm ERR! gyp info it worked if it ends with ok npm ERR! gyp info using node-gyp@8.4.1 npm ERR! gyp info using node@17.3.0 | linux | x64 npm ERR! gyp info find Python using Python version 3.10.2 found at "/usr/bin/python3" npm ERR! gyp http GET https://electronjs.org/headers/v15.3.5/node-v15.3.5-headers.tar.gz npm ERR! gyp http 200 https://gh-contractor-zcbenz.s3.amazonaws.com/atom-shell/dist/v15.3.5/node-v15.3.5-headers.tar.gz npm ERR! gyp http GET https://electronjs.org/headers/v15.3.5/SHASUMS256.txt npm ERR! gyp http 200 https://gh-contractor-zcbenz.s3.amazonaws.com/atom-shell/dist/v15.3.5/SHASUMS256.txt npm ERR! gyp info spawn /usr/bin/python3 npm ERR! gyp info spawn args [ npm ERR! gyp info spawn args '/home/jeff/.cache/yay/buttercup-desktop/src/buttercup-desktop-2.14.2/node_modules/node-gyp/gyp/gyp_main.py', npm ERR! gyp info spawn args 'binding.gyp', npm ERR! gyp info spawn args '-f', npm ERR! gyp info spawn args 'make', npm ERR! gyp info spawn args '-I', npm ERR! gyp info spawn args '/home/jeff/.cache/yay/buttercup-desktop/src/buttercup-desktop-2.14.2/node_modules/keytar/build/config.gypi', npm ERR! gyp info spawn args '-I', npm ERR! gyp info spawn args '/home/jeff/.cache/yay/buttercup-desktop/src/buttercup-desktop-2.14.2/node_modules/node-gyp/addon.gypi', npm ERR! gyp info spawn args '-I', npm ERR! gyp info spawn args '/home/jeff/.electron-gyp/15.3.5/include/node/common.gypi', npm ERR! gyp info spawn args '-Dlibrary=shared_library', npm ERR! gyp info spawn args '-Dvisibility=default', npm ERR! gyp info spawn args '-Dnode_root_dir=/home/jeff/.electron-gyp/15.3.5', npm ERR! gyp info spawn args '-Dnode_gyp_dir=/home/jeff/.cache/yay/buttercup-desktop/src/buttercup-desktop-2.14.2/node_modules/node-gyp', npm ERR! gyp info spawn args '-Dnode_lib_file=/home/jeff/.electron-gyp/15.3.5/<(target_arch)/node.lib', npm ERR! gyp info spawn args '-Dmodule_root_dir=/home/jeff/.cache/yay/buttercup-desktop/src/buttercup-desktop-2.14.2/node_modules/keytar', npm ERR! gyp info spawn args '-Dnode_engine=v8', npm ERR! gyp info spawn args '--depth=.', npm ERR! gyp info spawn args '--no-parallel', npm ERR! gyp info spawn args '--generator-output', npm ERR! gyp info spawn args 'build', npm ERR! gyp info spawn args '-Goutput_dir=.' npm ERR! gyp info spawn args ] npm ERR! gyp: name 'openssl_fips' is not defined while evaluating condition 'openssl_fips != ""' in binding.gyp while trying to load binding.gyp npm ERR! gyp ERR! configure error npm ERR! gyp ERR! stack Error: gyp failed with exit code: 1 npm ERR! gyp ERR! stack at ChildProcess.onCpExit (/home/jeff/.cache/yay/buttercup-desktop/src/buttercup-desktop-2.14.2/node_modules/node-gyp/lib/configure.js:259:16) npm ERR! gyp ERR! stack at ChildProcess.emit (node:events:390:28) npm ERR! gyp ERR! stack at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12) npm ERR! gyp ERR! System Linux 5.16.8-arch1-1 npm ERR! gyp ERR! command "/usr/bin/node" "/home/jeff/.cache/yay/buttercup-desktop/src/buttercup-desktop-2.14.2/node_modules/.bin/node-gyp" "rebuild" npm ERR! gyp ERR! cwd /home/jeff/.cache/yay/buttercup-desktop/src/buttercup-desktop-2.14.2/node_modules/keytar npm ERR! gyp ERR! node -v v17.3.0 npm ERR! gyp ERR! node-gyp -v v8.4.1 npm ERR! gyp ERR! not ok

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jeff/.npm/_logs/2022-02-12T11_43_36_458Z-debug-0.log

                command=/usr/bin/node /usr/lib/node_modules/npm/bin/npm-cli.js rebuild keytar@7.7.0
                workingDir=

==> ERROR: A failure occurred in build(). Aborting... -> error making: buttercup-desktop