Arch Linux User Repository

version bumped to 23.02.01

intelmetool compilation issue addressed

@slact Could you please add the sed command to prepare() as described by @je-vv, please?

Can you add a pciutils dependency. to solve the problem of compilation reporting errors? Thank you!

pciutils /usr/include/pci/header.h

That Makefile is an upstream one, right? So it seems an upstream bug. That said, a sed command in prepare() is required, otherwise this package doesn't build, :(

Perhaps @slact has an account on their bug tracker system, https://ticket.coreboot.org, and can file the bug on them... I once wrote to their general mailing list, and never got a reply back, :(

BTW, thanks a lot @Parker8283. Here it's the sed addition to prepare():

prepare() {
  cd "coreboot-$pkgver"
  patch -p0 < ../ifdtools-nowerror.patch
  sed -i 's|CFLAGS  ?=|CFLAGS  +=|' util/intelmetool/Makefile
}

I am unable to build the intelmetool on my system, as I get the following output:

==> Starting build()...
make: Entering directory '/home/parker/.cache/yay/coreboot-utils/src/coreboot-4.22.01/util/amdfwtool'
make: Nothing to be done for 'all'.
make: Leaving directory '/home/parker/.cache/yay/coreboot-utils/src/coreboot-4.22.01/util/amdfwtool'
make: Entering directory '/home/parker/.cache/yay/coreboot-utils/src/coreboot-4.22.01/util/cbfstool'
make: Leaving directory '/home/parker/.cache/yay/coreboot-utils/src/coreboot-4.22.01/util/cbfstool'
make: Entering directory '/home/parker/.cache/yay/coreboot-utils/src/coreboot-4.22.01/util/cbmem'
make: Nothing to be done for 'all'.
make: Leaving directory '/home/parker/.cache/yay/coreboot-utils/src/coreboot-4.22.01/util/cbmem'
make: Entering directory '/home/parker/.cache/yay/coreboot-utils/src/coreboot-4.22.01/util/ectool'
make: Nothing to be done for 'all'.
make: Leaving directory '/home/parker/.cache/yay/coreboot-utils/src/coreboot-4.22.01/util/ectool'
make: Entering directory '/home/parker/.cache/yay/coreboot-utils/src/coreboot-4.22.01/util/ifdtool'
make: '../ifdtool/ifdtool' is up to date.
make: Leaving directory '/home/parker/.cache/yay/coreboot-utils/src/coreboot-4.22.01/util/ifdtool'
make: Entering directory '/home/parker/.cache/yay/coreboot-utils/src/coreboot-4.22.01/util/intelmetool'
cc -march=native -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection   -c -o me_status.o me_status.c

Checking for development libraries: pci and zlib... me_status.c:4:10: fatal error: commonlib/bsd/helpers.h: No such file or directory
    4 | #include <commonlib/bsd/helpers.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [<builtin>: me_status.o] Error 1
make: *** Waiting for unfinished jobs....
found.
make: Leaving directory '/home/parker/.cache/yay/coreboot-utils/src/coreboot-4.22.01/util/intelmetool'
==> ERROR: A failure occurred in build().
    Aborting...

After some investigation, it is likely due to the Makefile for intelmetool doing a ?= for CFLAGS, and since makepkg sets its own CFLAGS, the CFLAGS in intelmetool do not get set. Unsure if this is an upstream bug or a something that this package should patch (or maybe this is user error?)

I got around this by simply changing the ?= to a +=, and it compiled fine after that. Unsure if that's the best solution, but it's what I did.

Really good to see a non git version. Cloning and fetching from coreboot is really hard on bad internet connections... Thanks a lot !