Arch Linux User Repository

Hi there! I only just got your email from months ago :( I'm glad I could help! Congratulations on your first package too, it's always a great feeling :)

I do have a couple more suggestions:

• You don't need the pkgver() function. It's redundant because you're specifying an exact version already.

• You don't need to use git to download the code at all. I highly recommend using the tarball that gitlab provides for all tags automatically:

https://gitlab.com/ethanbakerdev/cpick/-/archive/v1.0.2/cpick-v1.0.2.tar.gz

This will also allow you to provide a checksum for the file, so that it isn't just skipped. You'll also then be able to remove 'git' as a make dependency.

Also the source for this package is a git repository that isn't even referring to a specific tag, rather than a properly versioned release. You should either re-submit this package with a '-git' suffix, or change it so it uses versioned build artifacts.

You should probably review the following documentation on the subject:

https://wiki.archlinux.org/index.php/Arch_package_guidelines https://wiki.archlinux.org/index.php/Creating_packages https://wiki.archlinux.org/index.php/VCS_package_guidelines

Why is sudo used to build the binary? Root permissions should never be required to build anything, it's why makepkg has a specific check in place to not run as root.

It also means the package completely fails to build inside a clean chroot using Arch's official packaging tools for doing so.