Package Details: exfalso 4.5.0-1

Git Clone URL: https://aur.archlinux.org/exfalso.git (read-only, click to copy)
Package Base: exfalso
Description: Music player and music library manager
Upstream URL: https://quodlibet.readthedocs.io/
Licenses: GPL2
Conflicts: quodlibet
Submitter: LA-MJ
Maintainer: LA-MJ
Last Packager: LA-MJ
Votes: 1
Popularity: 0.000000
First Submitted: 2021-12-30 15:48 (UTC)
Last Updated: 2023-05-20 21:40 (UTC)

Latest Comments

LA-MJ commented on 2022-12-07 07:15 (UTC)

Sure, if you have a patch ready, please share. I will look into it on the weekend otherwise.

luciferin commented on 2022-12-06 20:31 (UTC)

Any chance of a bump to 4.5.0? I am getting errors due to the tests too, is there any downside to disabling them? I commented them out and was able to build successfully.

I version bumped the pkgbuild and commented out the patch lines and confirmed 4.5.0 builds correctly.

LA-MJ commented on 2022-01-03 16:23 (UTC)

I explicitly wanted to stay at tag 4.4.0 here so that I don't need to debug more issues than absolutely necessary.

But those tests keeping being annoying. I'll think about disabling them in PKGBUILD.

gbernard commented on 2022-01-03 10:14 (UTC) (edited on 2022-01-03 10:15 (UTC) by gbernard)

Temporarily removing mypy solves the problem.

$ sudo pacman -Rncs mypy
checking dependencies...

Packages (3) python-mypy_extensions-0.4.3-5  python-typed-ast-1.5.1-1  mypy-0.930-1

Total Removed Size:  15.41 MiB

:: Do you want to remove these packages? [Y/n] 
:: Processing package changes...
(1/3) removing mypy                                                                  [################################################] 100%
(2/3) removing python-typed-ast                                                      [################################################] 100%
(3/3) removing python-mypy_extensions                                                [################################################] 100%
:: Running post-transaction hooks...
(1/1) Arming ConditionNeedsUpdate...

gbernard commented on 2022-01-03 10:06 (UTC) (edited on 2022-01-03 10:09 (UTC) by gbernard)

Hi,

A problem on the tests on two different machines with version 4.4.0-3:

...
=================================== FAILURES ===================================
____________________________ TestMypy.test_project _____________________________

self = <tests.quality.test_mypy.TestMypy object at 0x7ff22a9d56c0>

    def test_project(self):
        root = Path(get_module_dir(quodlibet))
        assert Path.cwd() == root.parent, "MyPy must be run from project root"
        out, err, status = api.run([str(root)])
>       assert status == 0, "Failed mypy checks: \n" + "\n".join([out, err])
E       AssertionError: Failed mypy checks: 
E         quodlibet/packages/senf/__init__.pyi: error: Source file found twice under different module names: "quodlibet.packages.senf" and "senf"
E         quodlibet/packages/senf/__init__.pyi: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info
E         Found 1 error in 1 file (errors prevented further checking)
E         
E         
E       assert 2 == 0
E         +2
E         -0
...
=========================== short test summary info ============================
FAILED tests/quality/test_mypy.py::TestMypy::test_project - AssertionError: F...
= 1 failed, 4375 passed, 32 skipped, 7 deselected, 137 warnings in 92.14s (0:01:32) =
==> ERROR: A failure occurred in check().
    Aborting...

An idea ?