Arch Linux User Repository

What worked for me was

pamac checkupdates -a --devel
pamac upgrade -a --devel

Where -a stands for aur and --devel for development packages.

Since the --devel flag checks if behind the development packages (like "*-git" packages) there are any newer versions, it will update to the latest version of the package in git and not require and update on the aur listing

Please stop flagging this AUR as out-of-date unless you have tried these:

If you use a proper AUR helper (e.g paru, yay) this AUR will be use the latest commit of the Github repo. If you use pamac, it will not update based on the latest commit automatically and you should do pamac install --upgrade flameshot-git to force it to check for upgrades. Therefore, this AUR cannot become out-of-date unless the Github URL or dependencies get out of date.

add kguiaddons5 to the depends list please

Package should be built in clean chroot before committing updates.

Would you please elaborate more. I'm interested to know if this can also be automated.

Elaboration is on Arch Wiki: Building in a clean chroot. The command you need for your Makefile is described there.

pkgver() needs to be updated to #.r#.g# format, without v prefix. See VCS package guidelines

In ... you can find exactly the line we have used in flameshot-git AUR. Therefore,not only we are on par with the guideline, but the code we have is verbatim copy of the sample the AUR guideline provided.

VCS package guidelines, 2.6.1 Git lists options in order of preference. The format #.r#.g# is clearly preferred. The format you have chosen has condition for use: "If there are no tags..." Since the project does have tagged released, the package version should be in the preferred format #.r#.g#.

Versions in this format #.r#.g# are more useful than r#.# because it immediately communicates where a particular build is tracking with respect to the releases.

Tagging on your project frequently occurs outside the master branch. So it does take more effort than git describe to obtain a useful version string.

_tag=$(git tag | grep -Ev '[a-z]{2}' | sort -V | tail -1)
_revision=$(git rev-list --count $_tag..HEAD)
_commit=$(git rev-parse --short=7 HEAD)

printf '%s.r%s.g%s' "${_tag#v}" "$_revision" "$_commit"

Remove irrelevant comments: first-line "mode", "Contribution Instructions", "version numbers".

...

Those comments appear to have been copied/pasted from some old tutorial. A portion does not even appear relevent to this PKGBUILD. They are better moved to a different document or replaced with links to relevant ArchWiki pages.

Do not use -j$(nproc...). Users set this themselves in makepkg.conf.

There is no mention in the guideline that indicates this is wrong.

Regardless of whether there is a specific guideline, overriding user preferences is disrespectful. Rather than force all users to use a specific setting, users could be instructed on how to configure makepkg.

Instead of teaching less technical users... since it is AUR, technical users can modify it to their liking before installing.

If I took the "instead of teaching" approach, your PKGBUILD would still be unbuildable.

Sure, experienced "technical users" can fix packages before installing, but packages that are well maintained don't have to be fixed.

What did you expect "less technical users" to do with a broken PKGBUILD with numerous defects that would not build for over 1.5 years?

Awesome, installation from the AUR now working flawlessly (at least for me), thanks @mehrad

Thanks to @Vedun, @Rolv, @Kage-Yami, @xiota, and @etrigan63 for the info, suggestions and elaborations. I updated the PKGBUILD and SRCINFO accordingly. Also I added a part in Makefile to handle SRCINFO generation to avoid some of the raised issues.

Regarding @xiota comment:

Thanks for the detailed constructive comment and suggestuions.

Provides should be for flameshot, not flameshot-git.

Thanks, fixed.

kguiaddons5 should be depends, not makedepends. This was reported back in Feb 2022.

Fixed.

Package should be built in clean chroot before committing updates.

Would you please elaborate more. I'm interested to know if this can also be automated.

.SRCINFO should be generated before committing updates. See AUR submission guidelines

Thanks, noted, and Makefile thanks to your comment now handles this too.

pkgver() needs to be updated to #.r#.g# format, without v prefix. See VCS package guidelines

In the VCS package guidelines they literally state "See PKGBUILD-vcs.proto for generic examples showing the intended output." and when you click on the link and scroll down to line 49 you can find exactly the line we have used in flameshot-git AUR. Therefore,not only we are on par with the guideline, but the code we have is verbatim copy of the sample the AUR guideline provided.

Remove irrelevant comments: first-line "mode", "Contribution Instructions", "version numbers".

The first line is not a comment although it is in form of a comment, and the contribution instructions are there to help new and/or less techie users make sense of what is going on, and to help them know how to contribute. If you don't find those comments relevant, feel free to treat them like the interpreter: as comments :)

Do not use -j$(nproc...). Users set this themselves in makepkg.conf.

There is no mention in the guideline that indicates this is wrong. I agree that people can define MAKEFLAGS variable in their makepkg.conf, but the reality is that they don't, which means we get complaints all the time that the build time is long. Instead of teaching less technical users, we went the other rout of setting a relatively high core count, but since it is AUR, technical users can modify it to their liking before installing. We already spare one core for the rest of the system to function without issues during the build process.

Recommend to remove @borgman_jeremy from comaintainers list. User has no other packages and has no AUR activity since Sep 2020.

Thanks for your concern. Jeremy stepped down as the head dev of Flameshot some months back, but he has not stepped down/away from maintaining this repo, therefore, he is and will be listed as long as he is interested in co-maintaining this repo.

It appears you are missing a dependency. You need to add extra/kguiaddons5 explicitly as many window managers do not install it by default. hyprland being one of them.

• Provides should be for flameshot, not flameshot-git.
• kguiaddons5 should be depends, not optdepends. This was reported back in Feb 2022.
• Package should be built in clean chroot before committing updates.
• .SRCINFO should be generated before committing updates. See AUR submission guidelines
• pkgver() needs to be updated to #.r#.g# format, without v prefix. See VCS package guidelines
• Remove irrelevant comments: first-line "mode", "Contribution Instructions", "version numbers".
• Do not use -j$(nproc...). Users set this themselves in makepkg.conf.
• Recommend to remove @borgman_jeremy from comaintainers list. User has no other packages and has no AUR activity since Sep 2020.

It appears that kguiaddons5 is a mandatory make dependency - attempting to build in a clean chroot with aurto fails. However, building with yay (when I've got kguiaddons5 already installed on my system) does succeed.

Full error from chroot build

CMake Warning at src/CMakeLists.txt:14 (find_package):
  By not providing "FindKF5GuiAddons.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "KF5GuiAddons", but CMake did not find one.

  Could not find a package configuration file provided by "KF5GuiAddons" with
  any of the following names:

    KF5GuiAddonsConfig.cmake
    kf5guiaddons-config.cmake

  Add the installation prefix of "KF5GuiAddons" to CMAKE_PREFIX_PATH or set
  "KF5GuiAddons_DIR" to a directory containing one of the above files.  If
  "KF5GuiAddons" provides a separate development package or SDK, be sure it
  has been installed.


Flameshot predefined color palette large: false
-- Found Git: /usr/bin/git (found version "2.42.0") 
git found: /usr/bin/git in version     2.42.0
FLAMESHOT_GIT_HASH: fa29bcb4
-- Configuring done (0.6s)
CMake Error at src/CMakeLists.txt:217 (target_link_libraries):
  Target "flameshot" links to:

    KF5::GuiAddons

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.



-- Generating done (0.0s)
CMake Generate step failed.  Build files cannot be regenerated correctly.

I'm also unable to get this package to build. Says I am missing kguiaddons but I checked and shouldn't the package be kguiaddons5?

EDIT: can confirm, after editing the PKGBUILD and changing kguiaddons to kguiaddons5, package builds and installs correctly.

For anyone else who wants to install, this worked for me: grab the PKGBUILD from the top right of this page under Package Actions and put it in a random, empty directory. Edit it and just add a 5 after kguiaddons. Then, in that directory run makepkg, then sudo pacman -U flameshot-git-r1938.fa29bcb4-1-x86_64.pkg.tar.zst

The package is not being assembled.
Output in the terminal:

...
CMake Deprecation Warning at external/Qt-Color-Widgets/color_widgets_designer_plugin/CMakeLists.txt:17 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.


CMake Warning at src/CMakeLists.txt:14 (find_package):
  By not providing "FindKF5GuiAddons.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "KF5GuiAddons", but CMake did not find one.

  Could not find a package configuration file provided by "KF5GuiAddons" with
  any of the following names:

    KF5GuiAddonsConfig.cmake
    kf5guiaddons-config.cmake

  Add the installation prefix of "KF5GuiAddons" to CMAKE_PREFIX_PATH or set
  "KF5GuiAddons_DIR" to a directory containing one of the above files.  If
  "KF5GuiAddons" provides a separate development package or SDK, be sure it
  has been installed.


Flameshot predefined color palette large: false
-- Found Git: /usr/bin/git (found version "2.42.0")
git found: /usr/bin/git in version     2.42.0
FLAMESHOT_GIT_HASH: ad390603
-- Configuring done (4.5s)
CMake Error at src/CMakeLists.txt:217 (target_link_libraries):
  Target "flameshot" links to:

    KF5::GuiAddons

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.
...

@kyechou Please read the PKGBUILD: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=flameshot-git#n61