Package Details: freedroidrpg-git 1.0rc2.r20.g642f6a95a-1

Git Clone URL: https://aur.archlinux.org/freedroidrpg-git.git (read-only, click to copy)
Package Base: freedroidrpg-git
Description: a mature science fiction role playing game set in the future
Upstream URL: http://www.freedroid.org
Licenses: GPL
Conflicts: freedroidrpg
Provides: freedroidrpg
Submitter: viachaslavic
Maintainer: viachaslavic
Last Packager: viachaslavic
Votes: 1
Popularity: 0.000000
First Submitted: 2017-11-20 03:31 (UTC)
Last Updated: 2020-05-28 17:59 (UTC)

Latest Comments

viachaslavic commented on 2020-05-28 18:01 (UTC)

@rafaelff Accepted. Thanks!

rafaelff commented on 2020-05-27 11:54 (UTC) (edited on 2020-05-27 11:54 (UTC) by rafaelff)

Hey there! Please see below some suggestions to improve your PKGBUILD:

The following dependencies are already satisfied, so can be safely removed from 'depends' array: * libogg by libvorbis * libgl by glu * glu by glew

The following packages can be removed from 'makedepends' array as they are part of base-devel package group, just like gcc and other packages not listed here. (base-devel is assumed to be installed for AUR packages, so its packages can be ommitted): * autoconf * gettext * automake

List the packages from optdepends (python, lua, espeak) in 'makedepends' array also. Why: packages in optdepends do not get installed during build time, and the software will not find them if not installed, so by listing them in makedepends you make sure they are installed during build, but not mandatory when installed.

'pkgver()' function could have the command git describe --long | sed 's|-|.r|;s|-|.|' for a version "1.0rc2.r20.g642f6a95a". Advantages: shows current version (1.0 rc2), shows number of commits since last tagging (r20), and still shows the latest commit hash. Plus is smaller.