Arch Linux User Repository

It would be nice to have the patch I mentioned before applied, so I don't have to keep modifying the PKGBUILD. The suggested changes are also shown in the Arch Linux CMake package guidelines: https://wiki.archlinux.org/title/CMake_package_guidelines#Template

I had to apply the following patch to make this package build if the default generator is something other than make (e.g., ninja).

diff --git a/PKGBUILD b/PKGBUILD
index b38654c..d6bdadf 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -30,12 +30,12 @@ build() {
     -DGTSAM_INSTALL_GEOGRAPHICLIB=OFF \
     -DGTSAM_USE_SYSTEM_EIGEN=ON \
     ..
-  make
+  cmake --build .
 }

 package() {
   cd "${srcdir}/${pkgname}-${pkgver}/build"
-  make DESTDIR="${pkgdir}" install
+  DESTDIR="${pkgdir}" cmake --install .
   install -Dm644 "${srcdir}/${pkgname}-${pkgver}/LICENSE" "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
 }

@kartikmohta thanks for the offer, means a lot! However, my time with gtsam might end soon, besides, having someone else look at the changes is definitely better for quality. If you could set up a github mirror for you PKGBUILDs using aurpublish(https://github.com/eli-schwartz/aurpublish) that would be even better tho. Then I could submit PRs directly.

Right now I'm just trying to vet out warnings and seeing if some of these 3rdParty codebases can be vendored out.

/> It's only used for some tests which we don't build anyway.

Ah yes it seems like you are right. There is the following line:

gtsam/navigation/GPSFactor.h:58:   * Use GeographicLib to convert from geographic (latitude and longitude) coordinates

that mentions GepgraphiLib but nothing from GeographLib is required for the *.cpp version of that file. The rest of the mentions (and includes) are in the navigation/tests.

@acxz I can add you as a co-maintainer of this and the other gtsam-* packages if you are willing to help and are also regularly using it. I don't really use gtsam these days.

As far as I can see, geographiclib is not really a dependency. It's only used for some tests which we don't build anyway.

@kartikmohta Even though geographiclib is vendored in the GTSAM codebase, they check to see if a system level package is installed before installing their own copy. For example this is what I see in my cmake output with the geographiclib package installed: -- Found GeographicLib: /usr/lib Can you add geographiclib as dep?

Sweet thank you!

@acxz Added a separate gtsam-mkl package with MKL enabled. I was not sure of enabling MKL in this package even if it's installed since the official docs say, "best performance is usually achieved with MKL disabled. We therefore advise you to benchmark your problem before using MKL."

@kartikmohta I have intel-mkl installed however, when I build this pakcage, I see the following message during the cmake stage:

-- Could NOT find MKL (missing: MKL_LIBRARIES) 

This patch resolved the issue for me: https://github.com/borglab/gtsam/pull/300