Package Details: jrnl-git v2.8.4.beta.r11.gba8a59b2-1

Git Clone URL: https://aur.archlinux.org/jrnl-git.git (read-only, click to copy)
Package Base: jrnl-git
Description: Collect your thoughts and notes without leaving the command line
Upstream URL: https://jrnl.sh/
Licenses: GPL3
Conflicts: jrnl
Submitter: ckafi
Maintainer: None
Last Packager: esrh
Votes: 3
Popularity: 0.000000
First Submitted: 2015-08-13 19:38 (UTC)
Last Updated: 2021-11-30 00:34 (UTC)

Latest Comments

1 2 Next › Last »

esrh commented on 2021-11-30 00:36 (UTC)

Update: I genuinely couldn't figure out any other way to properly run check(). Upstream switched to pytest which only works inside of the poetry environment. Currently, the pkgbuild creates a poetry environment, installs deps, runs tests, and then deletes the virtual environment. Feel free to skip check if you wish.

esrh commented on 2021-06-08 19:38 (UTC) (edited on 2021-06-08 19:56 (UTC) by esrh)

Poetry installs to a virtual environment - after installing all the dependencies to that venv as well. I didn't have much time yesterday(i was just trying to get everything to work foolproof), but i'll try to find a proper fix by today. To be honest, i didn't know about the consequences of hacking the package step, thanks.

The reason i was basically forced to skip package is because for some reason, pytest fails without having make install run first (poetry build is not sufficient), but check() runs after build() not package(). I think what I'll do for now is remove the pytest check instead, which i shouldve done in the beginning.

edit: done, this is still not a complete fix though. (yet)

mindless_canary commented on 2021-06-08 06:01 (UTC) (edited on 2021-06-08 06:03 (UTC) by mindless_canary)

Skipping the package() section with a true is creates an empty package. That's certainly a quite bad fix, cause it makes installed files untraceable.

The other problem is that I can't figure out where make install in the build() section writes files to. (nowhere in my PATH at least)

Sorry, I'm not a python programmer. This is basically my first contact to poetry.

esrh commented on 2021-06-07 19:48 (UTC) (edited on 2021-06-07 19:49 (UTC) by esrh)

Short term fix is out. For now, i've decided to go with the poetry/make install process. This is imo suboptimal for several reasons -- but it is headache free.

I'm working on fixing the non-poetry install; pytest seems to be breaking.

mindless_canary commented on 2021-06-04 20:54 (UTC)

This package misses dependencies - python-ansiwrap - python-keyring - python-parsedatetime

and still fails checks.

Please fix this.

esrh commented on 2021-03-16 21:27 (UTC) (edited on 2021-03-16 21:29 (UTC) by esrh)

Fixed. I am not going to use the makefile because that requires poetry which requires a bunch of other dependencies as well. Furthermore, pylint seems to fail. I'm trying to sort it out with the upstream.

I did however include black style checks, which apparently fails on setup.py so I included a step to patch that file in prepare().

GiantPanurge commented on 2021-03-15 12:38 (UTC)

The check() step is currently quite noisy. Can you update the call to behave to format the output to one of progress, progress2, or progress3? Alternately, can you just use the Makefile's test target? This runs the unittests and style checks as well

esrh commented on 2021-02-07 16:26 (UTC)

Adopted the package, hopefully everything is fixed now.

pbateman commented on 2020-08-18 11:14 (UTC) (edited on 2020-08-18 11:16 (UTC) by pbateman)

Currently doesn't build on standard up-to-date install (python 3.8.5):

poetry install The "black" dependency specifies the "allows-prereleases" property, which is deprecated. Use "allow-prereleases" instead. The currently activated Python version 3.8.5 is not supported by the project (>=3.6.0, <3.8.0). Trying to find and use a compatible version.

[NoCompatiblePythonVersionFound] Poetry was unable to find a compatible version. If you have one, you can explicitly use it via the "env use" command. make: *** [Makefile:29: install] Error 1 ==> ERROR: A failure occurred in package(). Aborting... :: failed to build jrnl-git package(s)