Arch Linux User Repository

There was a second occurrance of the same bug I fixed the other day... which I fixed earlier today. There should be no more crashes at all with 4.5.2! Please let me know if anyone still experiences any 😭

@Rhinoceros - i get what you're saying. i'll take another look at the syntax and see if i can use sed to strip out the optimization and source-fortification.

Thanks @jghodd that looks good. I had another thought, and I'm not sure if my original idea was a bit faulty.

What if users had their CFLAGS as -O3, say? It's probably more robust to explicitly append -O0 instead of assuming users have -O2.

I couldn't find much documentation on -Wp,-D_FORTIFY_SOURCE=2 though, so I'm not sure what the default replacement is.

@Rhinoceros - I don't disagree with your point about hard-coding CFLAGS. it could bite you later on down the line.

How about this:

build() {
  export CFLAGS="${CFLAGS/" -O2"/""}"
  export CFLAGS="${CFLAGS/" -Wp,-D_FORTIFY_SOURCE=2"/""}"

  cd "${_pkgname}-${pkgver}"
  ./autogen.sh
  ./configure --prefix=/usr --enable-status-notifier
  make
}

This works, btw.

I can't comment on the authentication issues, as I don't use the updater. Probably better to report it upstream, since it's presumably not a packaging error.

Thanks for the info with CFLAGS. However, in theory I don't really like explicitly listing all the options, because unrelated flags in the users' defaults will potentially be overwritten. Instead, I'm fairly sure I can just add additional flags that will overrule the previous flags. So instead of writing out the whole set of flags and omitting -O2, I could just append to the users' current flags with

CFLAGS+=' -O0'

This is the default -O value, i.e. equivalent to having no flag.

However, I'm not sure how to overrule -Wp,-D_FORTIFY_SOURCE=2, and my Googling turns up nothing. Any ideas?

I'd still like to know why I have to authenticate every time, despite my username having been added to the kalu group.

You can leave makepkg.conf alone. Here's the change to PKGBUILD that works:

build() {
  export CFLAGS="-march=x86-64 -mtune=generic -pipe -fno-plt -fexceptions \
        -Wformat -Werror=format-security \
        -fstack-clash-protection -fcf-protection \
        -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer"

  cd "${_pkgname}-${pkgver}"
  ./autogen.sh
  ./configure --prefix=/usr --enable-status-notifier
  make
}

The options that are not needed are both "-O2" and "-Wp,-D_FORTIFY_SOURCE=2".

One other issue is that despite adding my user name to group and gshadow, kalu is now throwing up an authentication window every time i want to do an update. didn't used to do that if your username was in the kalu group.

the only consolation is that removing optimizations from makepkg.conf only affects AURs and not all packages. at least I hope so.

@Thulima + @Rhinoceros - OK. figured it out. optimization needs to be removed from CFLAGS in /etc/makepkg.conf. in other words, edit makepkg.conf, find CFLAGS, and delete "-O2" from it. the obvious issue with this is that we don't really want to permanently remove optimization from makepkg.conf. is there some way to remove that optimization with some setting in PKGBUILD? i'm guessing we can set CFLAGS in the build function, just not sure where would be appropriate...

Edit: btw, -D_FORTIFY_SOURCE=2 throws warnings when -O2 is removed. not sure how to resolve this. also, tried setting CFLAGS in build(), but it didn't take, so i'm guessing we need some other solution to get rid of the -O option from CFLAGS.