Package Base Details: libjpeg-xl-git

Git Clone URL: https://aur.archlinux.org/libjpeg-xl-git.git (read-only, click to copy)
Keywords: jpegxl jxl libjpegxl
Submitter: dbermond
Maintainer: dbermond
Last Packager: dbermond
Votes: 5
Popularity: 0.71
First Submitted: 2020-02-01 14:20
Last Updated: 2021-02-07 15:29

Latest Comments

« First ‹ Previous 1 2 3 4 5 Next › Last »

dbermond commented on 2020-05-06 22:31

@andrius4669 It's better to use all submodules that are explicitly declared by upstream. Package is now fixed.

andrius4669 commented on 2020-05-06 20:58

Well, actually, mingw-std-threads is not actually being used or even referenced at all if MINGW is not defined. So fix what is not exactly cleanest but works for me well is:

diff --git a/PKGBUILD b/PKGBUILD
index 0d68e71..9495c4f 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -25,7 +25,6 @@ source=('git+https://gitlab.com/wg1/jpeg-xl.git'
         'git+https://github.com/google/brunsli.git'
         'git+https://github.com/webmproject/sjpeg.git'
         'git+https://skia.googlesource.com/skcms.git'
-        'git+https://github.com/meganz/mingw-std-threads.git'
         '010-libjpeg-xl-git-remove-werror.patch'
         '020-libjpeg-xl-git-fix-headers-install-path.patch'
         '030-libjpeg-xl-git-fix-gdk-pixbuf-install-path.patch'
@@ -38,7 +37,6 @@ sha256sums=('SKIP'
             'SKIP'
             'SKIP'
             'SKIP'
-            'SKIP'
             '0f538f216f7fca8611efd5d638b521eb2c3b1fb716720afb371f034b3165c90c'
             'c2ea669a2afd94b6582921c893e0b382cd632c12d0a9c2358f955fd6cccffdc3'
             '1666790b92321fbf5859abe50c7355c91b0eddd7381529f35f052e71913c3bf0'
@@ -46,6 +44,7 @@ sha256sums=('SKIP'

 prepare() {
     git -C jpeg-xl submodule init
+    git -C jpeg-xl submodule deinit --force third_party/mingw-std-threads
     git -C jpeg-xl config --local submodule.third_party/brotli.url "${srcdir}/brotli"
     git -C jpeg-xl config --local submodule.third_party/lodepng.url "${srcdir}/lodepng"
     git -C jpeg-xl config --local submodule.third_party/lcms.url "${srcdir}/Little-CMS"
@@ -53,7 +52,6 @@ prepare() {
     git -C jpeg-xl config --local submodule.third_party/brunsli.url "${srcdir}/brunsli"
     git -C jpeg-xl config --local submodule.third_party/sjpeg.url "${srcdir}/sjpeg"
     git -C jpeg-xl config --local submodule.third_party/skcms.url "${srcdir}/skcms"
-    git -C jpeg-xl config --local submodule.third_party/mingw-std-threads.url "${srcdir}/mingw-std-threads"
     git -C jpeg-xl submodule update
     patch -d jpeg-xl -Np1 -i "${srcdir}/010-libjpeg-xl-git-remove-werror.patch"
     patch -d jpeg-xl -Np1 -i "${srcdir}/020-libjpeg-xl-git-fix-headers-install-path.patch"

dbermond commented on 2020-05-06 20:47

I've identified what's happening. It seems that the commit referenced by submodule mingw-std-threads was moved. Maybe it was on the git master branch but now it's not on master branch anymore and not on any branch currently. I'll push a fix.

My git sources on $SRCDEST were still pointing to that old state, so I could not reproduce the issue.

andrius4669 commented on 2020-05-06 20:16

Non-makepkg based git submodule update:

$ git submodule update
Cloning into '/home/anon/jpeg-xl/third_party/brotli'...
Cloning into '/home/anon/jpeg-xl/third_party/brunsli'...
Cloning into '/home/anon/jpeg-xl/third_party/googletest'...
Cloning into '/home/anon/jpeg-xl/third_party/lcms'...
Cloning into '/home/anon/jpeg-xl/third_party/lodepng'...
Cloning into '/home/anon/jpeg-xl/third_party/mingw-std-threads'...
Cloning into '/home/anon/jpeg-xl/third_party/sjpeg'...
Cloning into '/home/anon/jpeg-xl/third_party/skcms'...
Submodule path 'third_party/brotli': checked out '35ef5c554d888bef217d449346067de05e269b30'
Submodule path 'third_party/brunsli': checked out 'ede60d8bae3c10c56e64a0001f7b354c5a086ca3'
Submodule path 'third_party/googletest': checked out '0ea2d8f8fa1601abb9ce713b7414e7b86f90bc61'
Submodule path 'third_party/lcms': checked out '65c63bf549d78253c14b30b3d62cb668bbbe612c'
Submodule path 'third_party/lodepng': checked out '48e5364ef48ec2408f44c727657ac1b6703185f8'
remote: Enumerating objects: 4, done.
remote: Counting objects: 100% (4/4), done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 4 (delta 0), reused 2 (delta 0), pack-reused 0
Unpacking objects: 100% (4/4), 2.00 KiB | 1023.00 KiB/s, done.
From https://github.com/meganz/mingw-std-threads
 * branch            baca8abcfa9576d1682e049c46c4805230aeda5b -> FETCH_HEAD
Submodule path 'third_party/mingw-std-threads': checked out 'baca8abcfa9576d1682e049c46c4805230aeda5b'
Submodule path 'third_party/sjpeg': checked out '868ab558fad70fcbe8863ba4e85179eeb81cc840'
Submodule path 'third_party/skcms': checked out '64374756e03700d649f897dbd98c95e78c30c7da'

There is clearly something different about mingw-std-threads repo compared to others.. but I have no idea how to get it working yet.

andrius4669 commented on 2020-05-06 19:57

can confirm. same issue with both pikaur and pure makepkg

RubenKelevra commented on 2020-05-06 13:42

@dbermond

I already did choose the cleanBuild option on yay.

I also tried to download the files from aur and use makepkg, which also fails.

Sure that your package just builds fine because you have something cached? Because I cannot build it on multiple machines...

dbermond commented on 2020-05-01 18:18

@RubenKelevra Package is building fine. I have no problems with the git submodule mingw-std-threads.

Try to delete any possible old sources of mingw-std-threads from your $SRCDEST directory (and/or from the directory where PKGBUILD is placed), and also make sure that you're using plain makepkg with the cleanbuild option.

RubenKelevra commented on 2020-04-30 15:11

@dbermond

that's great news,

but sadly the package won't build anymore :(

==> Starting prepare()...
Submodule 'third_party/brotli' (https://github.com/google/brotli) registered for path 'third_party/brotli'
Submodule 'third_party/brunsli' (https://github.com/google/brunsli.git) registered for path 'third_party/brunsli'
Submodule 'third_party/googletest' (https://github.com/google/googletest) registered for path 'third_party/googletest'
Submodule 'third_party/lcms' (https://github.com/mm2/Little-CMS) registered for path 'third_party/lcms'
Submodule 'third_party/lodepng' (https://github.com/lvandeve/lodepng) registered for path 'third_party/lodepng'
Submodule 'third_party/mingw-std-threads' (https://github.com/meganz/mingw-std-threads) registered for path 'third_party/mingw-std-threads'
Submodule 'third_party/sjpeg' (https://github.com/webmproject/sjpeg.git) registered for path 'third_party/sjpeg'
Submodule 'third_party/skcms' (https://skia.googlesource.com/skcms) registered for path 'third_party/skcms'
Cloning into '/home/ruben/.cache/yay/libjpeg-xl-git/src/jpeg-xl/third_party/brotli'...
done.
Cloning into '/home/ruben/.cache/yay/libjpeg-xl-git/src/jpeg-xl/third_party/brunsli'...
done.
Cloning into '/home/ruben/.cache/yay/libjpeg-xl-git/src/jpeg-xl/third_party/googletest'...
done.
Cloning into '/home/ruben/.cache/yay/libjpeg-xl-git/src/jpeg-xl/third_party/lcms'...
done.
Cloning into '/home/ruben/.cache/yay/libjpeg-xl-git/src/jpeg-xl/third_party/lodepng'...
done.
Cloning into '/home/ruben/.cache/yay/libjpeg-xl-git/src/jpeg-xl/third_party/mingw-std-threads'...
done.
Cloning into '/home/ruben/.cache/yay/libjpeg-xl-git/src/jpeg-xl/third_party/sjpeg'...
done.
Cloning into '/home/ruben/.cache/yay/libjpeg-xl-git/src/jpeg-xl/third_party/skcms'...
done.
Submodule path 'third_party/brotli': checked out '35ef5c554d888bef217d449346067de05e269b30'
Submodule path 'third_party/brunsli': checked out 'ede60d8bae3c10c56e64a0001f7b354c5a086ca3'
Submodule path 'third_party/googletest': checked out '0ea2d8f8fa1601abb9ce713b7414e7b86f90bc61'
Submodule path 'third_party/lcms': checked out '65c63bf549d78253c14b30b3d62cb668bbbe612c'
Submodule path 'third_party/lodepng': checked out '48e5364ef48ec2408f44c727657ac1b6703185f8'
fatal: git upload-pack: not our ref baca8abcfa9576d1682e049c46c4805230aeda5b
fatal: remote error: upload-pack: not our ref baca8abcfa9576d1682e049c46c4805230aeda5b
Fetched in submodule path 'third_party/mingw-std-threads', but it did not contain baca8abcfa9576d1682e049c46c4805230aeda5b. Direct fetching of that commit failed.
==> ERROR: A failure occurred in prepare().
    Aborting...
Error making: libjpeg-xl-git

dbermond commented on 2020-04-22 01:38

Quoting from upstream Readme: "JPEG XL no longer requires a particular CPU. The software chooses and uses the best available instruction set for the current CPU".

So there is no need to worry about sse4.1 and avx2 instruction sets anymore.

dbermond commented on 2020-04-22 01:38

@RubenKelevra Fixed. Working fine now.