Arch Linux User Repository

works now, IDK :thinking: Thanks anyway

Hey @meijin, are you sure that you're doing a clean build using the latest pkgbuild? That patch isn't present anymore, so it looks like you haven't pulled the latest.

cat modes_reader.c.rej
--- modes_reader.c  2023-07-29 19:28:28.326973012 -0600
+++ modes_reader.c  2023-07-29 19:34:48.801995009 -0600
@@ -503,6 +503,19 @@
 {
     float lat, lon, alt;

+#if PY_MAJOR_VERSION >= 3 && PY_MINOR_VERSION >=11
+    lat = PyFloat_Unpack4(data + 4, 1);
+    if (lat == -1.0 && PyErr_Occurred())
+        return NULL;
+
+    lon = PyFloat_Unpack4(data + 8, 1);
+    if (lon == -1.0 && PyErr_Occurred())
+        return NULL;
+
+    alt = PyFloat_Unpack4(data + 12, 1);
+    if (alt == -1.0 && PyErr_Occurred())
+        return NULL;
+#else
     lat = _PyFloat_Unpack4(data + 4, 1);
     if (lat == -1.0 && PyErr_Occurred())
         return NULL;

I am failing to update the package with:

==> Extracting sources...
  -> Creating working copy of mlat-client git repo...
Cloning into 'mlat-client'...
done.
Switched to a new branch 'makepkg'
==> Starting prepare()...
patching file modes_reader.c
Hunk #1 FAILED at 503.
Hunk #2 succeeded at 524 with fuzz 1 (offset 10 lines).
1 out of 2 hunks FAILED -- saving rejects to file modes_reader.c.rej

@PanisSupraOmnia
OK, in light of your comments, I have edited my code at github ( https://github.com/abcd567a/archlinux-piaware )

I feel it is now in conformity with Arch Linux standards and practices.

Please have a look when you find time. Thank you.

@PanisSupraOmnia
Thank you for your review & comments about my composite repo. "archlinux-piaware" at Github.
I will shortly review it and will try to remove discrepancies pointed out by you.
Thanks again for your review.

Alright, finally got an update pushed. Please let me know if anyone runs into any issues with it. For now at least I'm going to leave it pointing to the dev branch, since this is a VCS package and it seems that the merges to master are relatively infrequent.

@abcd567, I did see your combined repo. However, I personally would not adopt your method as it currently stands, as at a quick glance I see a number of issues. Your PKGBUILD, for example, does not separate depends and makedepends, and rather than utilize the build() function you are doing everything in the package() step. Additionally, your install script uses pacman -Sy to install dependencies, which is explicitly unsupported as this can result in partial upgrades.

@PanisSupraOmnia
Have you seen PKGBUILD at my Github repo "https://github.com/abcd567a/archlinux-piaware" ?
It builds a self-contained composite package, as it builds following 3 components enclosed inside the piaware package which it builds:

piaware
faup1090-fa
fa-mlat-client

I have used this technique of composite-packaging since Feb 2021
(https://discussions.flightaware.com/t/how-to-install-dump1090-fa-and-piaware-on-arch-linux-x64-86-and-on-alarmpi-armv7-aarch64/42366/14)

Subsequently using this compost-package technique, I created my above linked Github repository in May 2022.

Great, seen your Github repository and latest commit.

By the way, the mlat-client's dev branch was merged with master branch about a month ago, and both are now v0.2.13.

Good that you have added makedepends = python-wheel. I have forgotten to add it in my comments here.

If you like, you may look at my following repositories at Github:

https://github.com/abcd567a/archlinux-piaware

https://github.com/abcd567a/archlinux-dump1090-fa

https://github.com/abcd567a/piaware-ubuntu-debian-amd64

.

Yes, I'm aware. Point is that I don't currently have my piaware tracker set up, so I don't have a way to fully test it for a few days. The changes to the package step are already something I've handled, but hadn't pushed to AUR due to lack of testing. I mostly just needed to test that using python-build and python-installer works correctly.

For reference, here's the commit that I've pushed to GitHub: https://github.com/PanisSupraOmnia/pkgbuilds/commit/ce464b0653e2393a5f571c768da3dc3846724c61