| Git Clone URL: | https://aur.archlinux.org/onedrive-abraunegg-git.git (read-only, click to copy) |
|---|---|
| Package Base: | onedrive-abraunegg-git |
| Description: | Free OneDrive client written in D - abraunegg's fork |
| Upstream URL: | https://github.com/abraunegg/onedrive |
| Licenses: | GPL3 |
| Conflicts: | onedrive |
| Provides: | onedrive |
| Submitter: | depau |
| Maintainer: | lgm |
| Last Packager: | depau |
| Votes: | 24 |
| Popularity: | 0.000000 |
| First Submitted: | 2018-07-31 00:19 (UTC) |
| Last Updated: | 2019-05-01 22:20 (UTC) |
@Depau, @abraunegg :
The logrotate.d folder is installed under /usr/etc/, not sure if that's intended.
If not, the configure call in build() could be changed to:
./configure sysconfdir=/etc --enable-notifications=yes --enable-completions=yes --prefix=/usr
to install this into /etc/. Note the missing dashes, because --sysconfdir is not defined as an option but just as a variable $sysconfdir inside the configure script.
@mblumenstingl I have included your patch, thank you
@abraunegg Having a clean build environment is none of the PKGBUILD's business, it's the user's job to clean it up. Most AUR helpers will do that for you. I added the make flags as you suggested, it builds. Let me know if any other changes are required :)
PKGBUILD patch so the package builds fine with https://github.com/abraunegg/onedrive/commit/daec620c1a2e8f84a87761d9db891219bb27c6a8:
--- PKGBUILD.orig 2019-04-24 17:46:47.826619867 +0200
+++ PKGBUILD 2019-04-24 17:50:50.083276671 +0200
@@ -29,10 +29,13 @@
}
build() {
- make PREFIX=/usr -C $_pkgname
+ cd $_pkgname
+
+ ./configure --enable-notifications --enable-completions --prefix=/usr
+ make
}
package() {
- make COMPLETIONS=1 NOTIFICATIONS=1 PREFIX=/usr DESTDIR="$pkgdir" -C $_pkgname install
+ make DESTDIR="$pkgdir" -C $_pkgname install
install -Dm644 $_pkgname/config "$pkgdir/usr/share/onedrive/config.default"
}
After reading @abraunegg's most recent comment and some fiddling with the configure script, I have figured out that this PKGBUILD works fine, although I hope I'm not missing anything.
Anyways, thx for the software and for packaging this. Cheers !
EDIT Not sure about the prepare() function though; I preferred not to touch it.
@Depau Also, in the pkgbuild file you have the following:
prepare() {
sed -i 's/std\.c\./core.stdc./g' $_pkgname/src/sqlite.d
}
This should not need to be in the PKGBUILD file. Suggest also to ensure that your running a clean build, your make line should be:
make clean; make COMPLETIONS=1 NOTIFICATIONS=1 PREFIX=/usr DESTDIR="$pkgdir" -C $_pkgname install
Also - #287 introduced ./configure capability using pkg-config, so potentially could be updated to use that & ./configure <ARG> as well
@Depau Please can you check this package. 2 issues raised (#472, #474) where the @prefix@ not replaced in onedrive.service when using this package, thus the service fails to start. Please can you check.
@abraunegg done.
@Depau Might be worth checking / tweaking this git package based on latest master
I have created the package https://aur.archlinux.org/packages/onedrive-abraunegg/ which updates on every release.
https://aur.archlinux.org/packages/onedrive-bin/ @abraunegg @Pete
Pinned Comments
depau commented on 2018-10-08 13:25 (UTC) (edited on 2018-12-02 14:46 (UTC) by depau)
Guys, stop flagging this package as out of date. It's a freaking GIT package pulling from master, how the hell is it not up to date?
If it doesn't build it doesn't mean it's out of date.
If upstream broke the build, report an issue to upstream.
If this PKGBUILD needs changes to build with the latest commits, add a comment.