Arch Linux User Repository

Hi @jshap

Can I trouble you to merge the following patch:

From 32b7cf269889c51a308f044c729ec17455474dfa Mon Sep 17 00:00:00 2001
From: Andres Rodriguez <andresr@valvesoftware.com>
Date: Wed, 3 May 2023 11:51:50 -0400
Subject: [PATCH] Fix application windows not being associated with the
 .desktop files

This fixes a case where pinning a p4v window to the taskbar would
result in clicking said pinned icon failing to launch p4v.
---
 p4admin.desktop | 1 +
 p4merge.desktop | 1 +
 p4v.desktop     | 1 +
 3 files changed, 3 insertions(+)

diff --git a/p4admin.desktop b/p4admin.desktop
index 29c3648..a0f7fa8 100644
--- a/p4admin.desktop
+++ b/p4admin.desktop
@@ -6,3 +6,4 @@ Icon=p4admin
 Terminal=false
 Type=Application
 Categories=GNOME;Application;Development;
+StartupWMClass=p4admin.bin
diff --git a/p4merge.desktop b/p4merge.desktop
index f625f54..c1acf9c 100644
--- a/p4merge.desktop
+++ b/p4merge.desktop
@@ -6,3 +6,4 @@ Icon=p4merge
 Terminal=false
 Type=Application
 Categories=GNOME;Application;Development;
+StartupWMClass=p4merge.bin
diff --git a/p4v.desktop b/p4v.desktop
index 00baccc..dddd71e 100644
--- a/p4v.desktop
+++ b/p4v.desktop
@@ -6,3 +6,4 @@ Icon=p4v
 Terminal=false
 Type=Application
 Categories=GNOME;Application;Development;
+StartupWMClass=p4v.bin
-- 
2.40.0

sha256sum the latest tgz and update the last entry of sha256sums in PKGBUILD.

❯ sha256sum 20230428-p4v-2023.1.2419860.tgz
47850fa271c7c1ec28698de9d97840bfce543541211fa2feeb99d80a7cb6dbaf  20230428-p4v-2023.1.2419860.tgz

❯ git diff
diff --git a/PKGBUILD b/PKGBUILD
index 74f912406785..5776e8330422 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -24,7 +24,7 @@ sha256sums=('1fc7ea925fdcb38915f191b6a9c85fb46db9ef501dbaa077e8f38876c5e8fda0'
             '10e470c6099459a072565494c4fd21cc1f4198f1024fe6fdeb6c77ea7e594827'
             '139c5e4951ea9ab040912ef1f9705de16a37d32fdf7b8c7116eb5a785829c634'
             'c4ed3aef62b1bbf2d16ce4cceb65dc49ab9635b38e2fed0a595fe259283a9f32'
-            '69a12951f3e43a06f61974b2813e4837cf4f180f5057a0dabe8dbe9de13abf7e')
+            '47850fa271c7c1ec28698de9d97840bfce543541211fa2feeb99d80a7cb6dbaf')

 # Perforce Software (Package Signing) <support+packaging@perforce.com>
 # validpgpkeys=('7123CB760FF18869'

Hello @jshap I had the same issue. In PKGBUILD I didn't had the same checksum for 20230322-p4v-2023.1.2419860.tgz I replaced it by the checksum I found and it worked 47850fa271c7c1ec28698de9d97840bfce543541211fa2feeb99d80a7cb6dbaf

@dront78 Can you provide more details about why the checksum on 2023.1.2419860 failed because it works for me and is still the posted SHA256SUM that they release.

Version p4v-2022.3.2370885 is failing the validation check

==> Making package: p4v 2022.3.2370885-1 (Wed Feb 22 10:11:28 2023)
==> Retrieving sources...
  -> Found p4v.desktop
  -> Found p4admin.desktop
  -> Found p4merge.desktop
  -> Found LICENSE
  -> Downloading 20230222-p4v-2022.3.2370885.tgz...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   784    0   784    0     0   3050      0 --:--:-- --:--:-- --:--:--  3050
100  121M  100  121M    0     0  31.5M      0  0:00:03  0:00:03 --:--:-- 42.2M
==> Validating source files with sha256sums...
    p4v.desktop ... Passed
    p4admin.desktop ... Passed
    p4merge.desktop ... Passed
    LICENSE ... Passed
    20230222-p4v-2022.3.2370885.tgz ... FAILED
==> ERROR: One or more files did not pass the validity check!
==> ERROR: Could not download sources.

with 2020.3.2059355-1 I get this :

==> ERROR: One or more files did not pass the validity check!

I get this file donwloaded (with its sha256)

a5550587ded1fde03831610242a29d50ddf0f3f5475cb384443c3bb4a1b7ea72  20210104-p4v-2020.3.2059355.tgz

yes you're right, fixed.

Shouldn't this have qt5-base as a dependency? It doesn't start without qt5-base installed.