Arch Linux User Repository

Sorry, I missed your previous comment about the version. But that requirement is already satisfied:

$ makepkg -C --nobuild && source PKGBUILD && srcdir="src" && (pkgver) && while git -C src/pass-notify/ checkout -q HEAD~; do (pkgver); done
0.4.0
0.3.0
0.2.0.r1.g656b698
0.2.0
0.1.0.r1.g2915566
0.1.0

$ vercmp 0.2.0 0.2.0.r1.g656b698
-1

$

$ vercmp 0.2.0.r1.g656b698 0.3.0
-1

Thanks! Fixed now.

This package installs stuff into /usr/local/, which must not happen. /usr/local/ is solely to be used for stuff installed manually outside of packages.

In detail, it installs /usr/local/bin/passmenu-notify.

Please install directly as /usr/bin/passmenu-notify.

You can achieve this by changing the installation command to

make PREFIX="${pkgdir}/usr/bin" DESTDIR="${pkgdir}" install

Thanks for maintaining,
regards!

Another point:

This package uses the latest git checkout. The version should increase with every git commit, so please add some appropriate stuff to the pkgver() function (i.e. adding commit count).

pkgver() could look like this:

pkgver() {
  cd "${srcdir}/pass-notify/"

  _ver="$(git describe --tags | sed 's|^[vV]||' | sed 's|-[^-]*$||' | tr '-' '+')"
  _rev="$(git rev-list --count HEAD)"
  _date="$(git log -1 --date=format:"%Y%m%d" --format="%ad")"
  _hash="$(git rev-parse --short HEAD)"

  if [ -z "${_ver}" ]; then
    error "Version could not be determined."
    return 1
  else
    printf '%s' "${_ver}.r${_rev}.${_date}.${_hash}"
  fi
}

which currently produces 0.4.0.r6.20220529.8026c31.

Or is somehow guaranteed that every single commit will increment the main version number of the software?

Regards!

Good point, thanks!

Please add

• provides=("pass-notify=${pkgver}") and
• pass-notify to the conflicts array.

Thanks for maintaining!

Ok, this package (pass-patched-passmenu-notify-git) is now superseded by the new passmenu-notify-git package which solves this in a better way so you can stay in sync with pass upstream instead of this ancient fork. I'm marking pass-patched-passmenu-notify-git as out of date with no intent to update again. Thanks again for the poke!

Hmyeah, this is pretty ancient at this point. This is probably better done as an extension now. Thanks for the poke!

This fails to build for me in a clean chroot. The error is in prepare().

Starting prepare()...
patching file contrib/dmenu/passmenu
Hunk #2 succeeded at 26 with fuzz 1.
patching file src/password-store.sh
Hunk #1 succeeded at 144 (offset 25 lines).
Hunk #2 FAILED at 155.
1 out of 2 hunks FAILED

More details:

==> Making package: pass-patched-passmenu-notify-git latest-3 (Tue 24 Nov 2020 01:58:16 PM EST)
==> Checking runtime dependencies...
==> Installing missing dependencies...
resolving dependencies...
looking for conflicting packages...

Packages (13) libice-1.0.10-3  libsm-1.2.3-2  libx11-1.7.0-1  libxau-1.0.9-3  libxcb-1.14-1  libxdmcp-1.1.3-3  libxext-1.3.4-3  libxmu-1.1.3-2  libxt-1.2.0-2
              xcb-proto-1.14.1-1  xorgproto-2020.1-1  tree-1.8.0-2  xclip-0.13-3

Total Installed Size:  19.66 MiB

:: Proceed with installation? [Y/n] 
(13/13) checking keys in keyring                                                                       [############################################################] 100%
(13/13) checking package integrity                                                                     [############################################################] 100%
(13/13) loading package files                                                                          [############################################################] 100%
(13/13) checking for file conflicts                                                                    [############################################################] 100%
:: Processing package changes...
( 1/13) installing xcb-proto                                                                           [############################################################] 100%
( 2/13) installing libxdmcp                                                                            [############################################################] 100%
( 3/13) installing libxau                                                                              [############################################################] 100%
( 4/13) installing libxcb                                                                              [############################################################] 100%
( 5/13) installing xorgproto                                                                           [############################################################] 100%
( 6/13) installing libx11                                                                              [############################################################] 100%
( 7/13) installing libxext                                                                             [############################################################] 100%
( 8/13) installing libice                                                                              [############################################################] 100%
( 9/13) installing libsm                                                                               [############################################################] 100%
(10/13) installing libxt                                                                               [############################################################] 100%
(11/13) installing libxmu                                                                              [############################################################] 100%
(12/13) installing xclip                                                                               [############################################################] 100%
(13/13) installing tree                                                                                [############################################################] 100%
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Found passmenu-notify.patch
  -> Found password-store-master.tar.xz
==> WARNING: Skipping all source file integrity checks.
==> Extracting sources...
  -> Extracting password-store-master.tar.xz with bsdtar
==> Starting prepare()...
patching file contrib/dmenu/passmenu
Hunk #2 succeeded at 26 with fuzz 1.
patching file src/password-store.sh
Hunk #1 succeeded at 144 (offset 25 lines).
Hunk #2 FAILED at 155.
1 out of 2 hunks FAILED -- saving rejects to file src/password-store.sh.rej
==> ERROR: A failure occurred in prepare().
    Aborting...
==> ERROR: Build failed, check /mnt/chroots/arch/user/build

Here is the content of the file src/password-store.sh.rej

--- src/password-store.sh
+++ src/password-store.sh
@@ -155,7 +159,13 @@ clip() {

                echo "$before" | base64 -d | xclip -selection "$X_SELECTION"
        ) 2>/dev/null & disown
-       echo "Copied $2 to clipboard. Will clear in $CLIP_TIME seconds."
+
+       local copied_message="Copied $2 to clipboard. Will clear in $CLIP_TIME seconds."
+       echo "$copied_message"
+
+       if function_exists 'PASSWORD_STORE_POST_COPY_HOOK'; then
+               PASSWORD_STORE_POST_COPY_HOOK "$2" "$copied_message"
+       fi
}
tmpdir() {
        [[ -n $SECURE_TMPDIR ]] && return