Arch Linux User Repository

Finally fixed, thanks for the patch!

Hello, I have some small changes for this PKGBUILD:

-removed unnecessary lines from top

-removed unneeded build deps

-simplified license install path (current one is also wrong, because python on arch is 3.11"

diff

diff --git a/PKGBUILD b/PKGBUILD
index 79c3ab8..9d694c8 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,17 +1,15 @@
-# PKGBUILD generated by pipman
-# Python package author: Stefan Marsiske <s@ctrlc.hu>
 # Maintainer: Hauke Rehfeld <aur.archlinux.org@haukerehfeld.de>
 _name="pysodium"
 pkgname="python-${_name}"
 pkgver=0.7.12
 _pkgsubdir="${_name}-${pkgver}"
-pkgrel=2
+pkgrel=3
 pkgdesc="python libsodium wrapper"
 arch=(any)
 url="https://github.com/stef/pysodium"
 license=(BSD)
-makedepends=("python" "python-pip" "python-wheel" python-build python-installer python-setuptools)
 depends=("libsodium" "python")
+makedepends=("python-build" "python-installer" "python-setuptools" "python-wheel")
 source=("https://files.pythonhosted.org/packages/source/${_name::1}/$_name/${_pkgsubdir}.tar.gz")
 sha256sums=('3e9005c770dca021889b2fe77db7ffa3c2e98fcac7e3cc1e8e157b9ed78f1fc8')

@@ -24,7 +22,7 @@ package() {
   cd "$_pkgsubdir"
   python -m installer --destdir="$pkgdir" dist/*.whl

-  install -Dm644 "$pkgdir/usr/lib/python3.10/site-packages/${_name}-0.7.12.dist-info/LICENSE.txt" -t "$pkgdir/usr/share/licenses/$pkgname/"
+  install -Dm644 LICENSE.txt -t "$pkgdir/usr/share/licenses/$pkgname/"
 }

 check(){

Thanks it works!

Thanks! Should be fixed. I was calling tests wrongly, no idea why it worked on my system though :shrug:

Thanks! I also need two changes to make it build:

• Append python-setuptools to makedepends
• Add export PYTHONPATH="$PWD/.." before python test_pysodium.py

@yan12125 finally found time to update according to your suggestions, can you take a look?

Well, generally it's preferred to let makepkg download source files instead of downloading things in build(). makepkg can guarantee downloaded files are the same as what package maintainers got (via checksums), not something else replaced or hacked.

Other changes are minor improvements: add check(), fix shebang to get rid of a namcap warning & remove site-packages/test, which often results in conflicts with other packages.

By the way, python-wheel is needed for the current PKGBUILD, otherwise egg-info is installed instead of dist-info, and the last command in package() fails.

Can you explain what your PKGBUILD improves? What's wrong with using pip to install the package?

Here is an updated PKGBUILD with various fixes/improvements: https://fars.ee/1qYz