Arch Linux User Repository

On March 14, 2022, upstream has migrated the external 3rd party libraries to git submodules, which has broken compilation with the current PKGBUILD. I modified it to accommodate the upstream change and fix the build (on my end, at least):

--- PKGBUILD.old        2022-04-13 10:22:21.891833693 +0200
+++ PKGBUILD    2022-04-13 10:27:50.464368320 +0200
@@ -3,9 +3,9 @@

pkgname=vvvvvv-git
binname=vvvvvv
-pkgver=20201123.9f5f697
+pkgver=20220410.e16c1557
_pkgver=git
-pkgrel=2
+pkgrel=1
pkgdesc='A retro-styled 2D platformer'
arch=('i686' 'x86_64')
url='https://thelettervsixtim.es/'
@@ -16,12 +16,22 @@
conflicts=('vvvvvv')
source=(
    "git+https://github.com/TerryCavanagh/VVVVVV.git"
+    "git+https://github.com/FNA-XNA/FAudio.git"
+    "git+https://github.com/lvandeve/lodepng.git"
+    "git+https://github.com/icculus/physfs.git"
+    "git+https://github.com/leethomason/tinyxml2.git"
+    "git+https://github.com/nemtrif/utfcpp.git"
    "${binname}.desktop"
    "${binname}.sh"
    "https://thelettervsixtim.es/makeandplay/data.zip"
)
sha256sums=(
    'SKIP'
+    'SKIP'
+    'SKIP'
+    'SKIP'
+    'SKIP'
+    'SKIP'
    '8c704e92e6abc8172d7d9fe726f1a0bba4b8630682745d6daf1f34ce12e0e3e4'
    '883913125c4630d16fe0081d9a96bf65f2bc08ace7fa345613669d827a8ea7c1'
    '6fae3cdec06062d05827d4181c438153f3ea3900437a44db73bcd29799fe57e0'
@@ -34,7 +44,15 @@
}

prepare() {
-  cd VVVVVV/desktop_version
+  # Initialize submodules
+  cd VVVVVV
+  git submodule init
+  for submod in FAudio lodepng physfs tinyxml2 utfcpp; do
+    git config submodule.$submod.url "$srcdir/$submod"
+  done
+  git submodule update
+
+  cd desktop_version

echo "Please note: the retrieved data.zip is for personal use only without redistribution"
echo "See also: /usr/share/licenses/vvvvvv-git/LICENSE.md and https://thelettervsixtim.es/makeandplay/"

Fixed, apparently I forgot to clean my own build directory when doing the final compile check. Sorry for that

The following change to the PKGBUILD seems to break the package() phase on my end:

-   source = http://www.flibitijibibo.com/vvvvvv-mp-11192019-bin
+   source = https://thelettervsixtim.es/makeandplay/data.zip

This results in the error:

yay -Sy vvvvvv-git
...
==> Making package: vvvvvv-git 20201123.9f5f697-1 (Mon 30 Nov 2020 12:58:20 AM CET)
... (all goes well)
[100%] Built target VVVVVV
==> Entering fakeroot environment...
==> Starting package()...
/home/rw/.cache/yay/vvvvvv-git/PKGBUILD: line 60: cd: /tmp/makepkg/vvvvvv-git/src/data: No such file or directory
==> ERROR: A failure occurred in package().
    Aborting...
error making: vvvvvv-git

I think the problem here is that contrary to what the offending line 60 seems to assume (i.e. cd "${srcdir}/data"), there is no data directory, but only a data.zip file in $srcdir. You should probably ensure this file is unpacked, I guess.

You should use /usr/lib instead of /opt, just like mame.

dbus is needed for building.

The binary name apparently changed in commit a977f497250ba218e6c8b4722205df22348cc3fc, so I've updated the PKGBUILD to reflect this.

I also ran into an issue where -Werror was always enabled, so I've fixed this in 833b2fbf1d14b6d85b97ddeb3ae830f1988ae2c2. (this fixes the issue with edentity[testeditor])

I found out that my previous problem came about from the inclusion of -O2 in my CXXFLAGS. Upstream is aware of the offending code.

However, I'm experiencing a different, unrelated problem during the package() stage:

==> Starting package()...
install: cannot stat 'vvvvvv.x86_64': No such file or directory
==> ERROR: A failure occurred in package().

Indeed, there is no such file in ${srcdir}/VVVVVV/desktop_version/build. There is a working binary called VVVVVV in that folder, however.

@kleintux Upstream says it's more likely a problem with the PKGBUILD. Indeed, if I do everything in build() manually in a fresh repo, it builds fine.

Kind of sounds like a bug in my setup (although my /etc/makepkg.conf is relatively vanilla). In the fresh repo, I've manually exported all env vars in makepkg.conf, and then ran make clean + make, but then it also builds fine. Anyone has an idea whats up? How could only makepkg produce this error?

EDIT: See also the comments in the github thread I linked above. Might be upstream anyway.

I'm getting the following build error (weird how all warnings are treated as errors apparently, although I'm not familiar with cpp/game development)

/tmp/makepkg/vvvvvv-git/src/VVVVVV/desktop_version/src/editor.cpp: In member function ‘void editorclass::findstartpoint(Game&)’:
/tmp/makepkg/vvvvvv-git/src/VVVVVV/desktop_version/src/editor.cpp:1597:45: error: array subscript -1 is below array bounds of ‘edentities [3000]’ [-Werror=array-bounds]
 1597 |         game.edsavedir=1-edentity[testeditor].p1;
      |                          ~~~~~~~~~~~~~~~~~~~^
/tmp/makepkg/vvvvvv-git/src/VVVVVV/desktop_version/src/editor.cpp:2207:19: note: while referencing ‘edentity’
 2207 | extern edentities edentity[3000];
      |                   ^~~~~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [CMakeFiles/VVVVVV.dir/build.make:89: CMakeFiles/VVVVVV.dir/src/editor.cpp.o] Error 1