Package Details: spotdl 4.2.5-5

Git Clone URL: https://aur.archlinux.org/spotdl.git (read-only, click to copy)
Package Base: spotdl
Description: Download your Spotify playlists and songs along with album art and metadata (from YouTube if a match is found).
Upstream URL: https://github.com/spotDL/spotify-downloader
Keywords: download-music mp3 music playlists song song-lyrics spotify youtube-music
Licenses: MIT
Conflicts: python-spotdl
Provides: python-spotdl
Replaces: python-spotdl
Submitter: zoorat
Maintainer: zoorat (pekkarr, aminvakil)
Last Packager: pekkarr
Votes: 20
Popularity: 0.90
First Submitted: 2024-03-31 19:44 (UTC)
Last Updated: 2024-04-27 11:57 (UTC)

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 9 Next › Last »

aminvakil commented on 2022-05-20 16:28 (UTC)

@pekkarr Would you mind opening a PR to fix it, I'll open a PR in the next days if no one else does.

@txtsd Thank you for bringing this up!

txtsd commented on 2022-05-20 10:09 (UTC)

Thanks for the fix!

pekkarr commented on 2022-05-20 10:02 (UTC)

Yes, it's an upstream bug. The setup.cfg defines packages = find:, which apparently means that setuptools automatically searches all the packages from the sdist and installs them, including the tests package. Changing that line to packages = spotdl fixes the problem.

aminvakil commented on 2022-05-20 09:49 (UTC)

@pekkarr I'll remove it after CI gets green here (https://github.com/aminvakil/aur/pull/139).

But shouldn't this gets fixed upstream? Why it installs any folder directly in site-packages?

pekkarr commented on 2022-05-20 09:36 (UTC)

According to the Python package guidelines tests directory should not be installed.

txtsd commented on 2022-05-20 09:30 (UTC)

See the comments on icoextract which has since fixed the issue on its end.

aminvakil commented on 2022-05-20 09:29 (UTC)

@txtsd Oh, can you please name the other package too?

txtsd commented on 2022-05-20 09:27 (UTC)

It conflicts with other packages that erroneously install the tests folder like this:

error: failed to commit transaction (conflicting files)
icoextract: /usr/lib/python3.10/site-packages/tests/__init__.py exists in filesystem (owned by python-spotdl)
icoextract: /usr/lib/python3.10/site-packages/tests/__pycache__/__init__.cpython-310.opt-1.pyc exists in filesystem (owned by python-spotdl)
icoextract: /usr/lib/python3.10/site-packages/tests/__pycache__/__init__.cpython-310.pyc exists in filesystem (owned by python-spotdl)

aminvakil commented on 2022-05-20 09:23 (UTC)

@txtsd Thanks for your suggestion, there isn't a should for this (at least I have not seen removing tests folder in Arch official guidelines) and AFAICS for this package tests package is only 4 MB.

txtsd commented on 2022-05-19 15:37 (UTC)

No package should be installing the tests folder.

Please add this to the package() function:

local site_packages=$(python -c "import site; print(site.getsitepackages()[0])")
rm -rf "${pkgdir}${site_packages}/tests/"

« First ‹ Previous 1 2 3 4 5 6 7 8 9 Next › Last »