Arch Linux User Repository

I don't want to be that guy, but:

• If the package builds using makepkg -s, I don't care if your AUR helper doesn't work, it's a problem with your AUR helper and needs to be fixed there. Here's the build log for the latest version: https://gist.github.com/Edu4rdSHL/929a7eba81165da5166c4d0974d0e96f
• I can't reproduce the current electron issue with v30, and seems that only a few users are having the issue. So I don't see any reason to downgrade the electron version for everyone. Plus, Athonathonathon put a workaround for it, which seems to be related to the current Chrome breakage on Wayland setups.

The Wayland issue has been fixed from 1.5.1-2 onwards.

The funny sed and find magic that you have in the buildscript causes the build to fail if slack-desktop is installed.

This is because slack-desktop creates a folder, /usr/lib/slack/resources/app.asar.unpacked/node_modules/electron-native-auth, however this folder does not actually contain electron. It only contains a bin and build directory. And, because of the ordering of directories due to find, this directory occurs last. It is just by happenstance that /usr/lib/electron22 and /usr/lib/electron25 come after other valid matches, such as /usr/lib/node_modules/@bitwarden/cli/node_modules/electron-to-chromium, /usr/lib/code/out/vs/code/electron-main, /usr/lib/code/out/vs/code/electron-sandbox, /usr/lib/code/out/vs/base/parts/sandbox/electron-sandbox, /usr/lib/code/out/vs/platform/profiling/electron-sandbox, and /usr/lib/geogebra/resources/app/node_modules/electron-store.

I looked at how you're matching a valid version of electron, and that's probably not a good way. Might be better to do smth like which electron and grab that path instead.

Package now looks for any electron installation in /usr/lib/.

The build fails with those electron packages because there is no /usr/lib/electron if they are your only electron package. I'll try to see if I can sed the correct /usr/lib/electron* path to electron-builder in the PKGBUILD.

And for the second issue, it looks like it's just using the path of its executable (in this case electron) for the .desktop file, but without any parameters. This might be something that can be fixed on vencord's/vesktop's side.

There is also an issue where enabling autostart will generate a shortcut in .config/autostart that instead of starting /usr/bin/vencord-desktop starts /usr/lib/electron25/electron so the user needs to either manually fix it or create their own startup shortcut.

If using an AUR version of Electron (tested with electron27-bin and electron28-bin) instead of the one in the Extra repository the build fails with:

• copying Electron  source=/usr/lib/electron destination=/tmp/makepkg/vencord-desktop/src/Vesktop-0.4.3/dist/linux-unpacked
⨯ ENOENT: no such file or directory, rename '/tmp/makepkg/vencord-desktop/src/Vesktop-0.4.3/dist/linux-unpacked/electron' -> '/tmp/makepkg/vencord-desktop/src/Vesktop-0.4.3/dist/linux-unpacked/vencorddesktop'  failedTask=build stackTrace=Error: ENOENT: no such file or directory, rename '/tmp/makepkg/vencord-desktop/src/Vesktop-0.4.3/dist/linux-unpacked/electron' -> '/tmp/makepkg/vencord-desktop/src/Vesktop-0.4.3/dist/linux-unpacked/vencorddesktop'
ELIFECYCLE  Command failed with exit code 1.
==> ERROR: A failure occurred in build().