summarylogtreecommitdiffstats
path: root/0008-asus-wmi-deprecate-bios-features.patch
diff options
context:
space:
mode:
authorTaijian2024-06-22 17:18:34 +0200
committerTaijian2024-06-22 17:18:34 +0200
commitca794d215234324a098d3095db5e2fb404a51bd6 (patch)
tree94f05131584767eb80b45e7d65e5016ebdf5c5ab /0008-asus-wmi-deprecate-bios-features.patch
parent81c1be2adc2da072b2f9d1e407a50f813c376477 (diff)
downloadaur-ca794d215234324a098d3095db5e2fb404a51bd6.tar.gz
update to 6.9.6
Diffstat (limited to '0008-asus-wmi-deprecate-bios-features.patch')
-rw-r--r--0008-asus-wmi-deprecate-bios-features.patch592
1 files changed, 592 insertions, 0 deletions
diff --git a/0008-asus-wmi-deprecate-bios-features.patch b/0008-asus-wmi-deprecate-bios-features.patch
new file mode 100644
index 000000000000..3eb5d138cdac
--- /dev/null
+++ b/0008-asus-wmi-deprecate-bios-features.patch
@@ -0,0 +1,592 @@
+From 0c31b9b182c43ac0e72c04ce9e0f9fa4b7f62271 Mon Sep 17 00:00:00 2001
+From: "Luke D. Jones" <luke@ljones.dev>
+Date: Mon, 3 Jun 2024 12:04:41 +1200
+Subject: [PATCH 8/8] asus-wmi: deprecate bios features
+
+Signed-off-by: Luke D. Jones <luke@ljones.dev>
+---
+ .../ABI/testing/sysfs-platform-asus-wmi | 17 +++
+ drivers/platform/x86/Kconfig | 8 ++
+ drivers/platform/x86/asus-wmi.c | 126 ++++++++++++++----
+ 3 files changed, 123 insertions(+), 28 deletions(-)
+
+diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi b/Documentation/ABI/testing/sysfs-platform-asus-wmi
+index 28144371a0f1..765d50b0d9df 100644
+--- a/Documentation/ABI/testing/sysfs-platform-asus-wmi
++++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi
+@@ -63,6 +63,7 @@ Date: Aug 2022
+ KernelVersion: 6.1
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ Switch the GPU hardware MUX mode. Laptops with this feature can
+ can be toggled to boot with only the dGPU (discrete mode) or in
+ standard Optimus/Hybrid mode. On switch a reboot is required:
+@@ -75,6 +76,7 @@ Date: Aug 2022
+ KernelVersion: 5.17
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ Disable discrete GPU:
+ * 0 - Enable dGPU,
+ * 1 - Disable dGPU
+@@ -84,6 +86,7 @@ Date: Aug 2022
+ KernelVersion: 5.17
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ Enable the external GPU paired with ROG X-Flow laptops.
+ Toggling this setting will also trigger ACPI to disable the dGPU:
+
+@@ -95,6 +98,7 @@ Date: Aug 2022
+ KernelVersion: 5.17
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ Enable an LCD response-time boost to reduce or remove ghosting:
+ * 0 - Disable,
+ * 1 - Enable
+@@ -104,6 +108,7 @@ Date: Jun 2023
+ KernelVersion: 6.5
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ Get the current charging mode being used:
+ * 1 - Barrel connected charger,
+ * 2 - USB-C charging
+@@ -114,6 +119,7 @@ Date: Jun 2023
+ KernelVersion: 6.5
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ Show if the egpu (XG Mobile) is correctly connected:
+ * 0 - False,
+ * 1 - True
+@@ -123,6 +129,7 @@ Date: Jun 2023
+ KernelVersion: 6.5
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ Change the mini-LED mode:
+ * 0 - Single-zone,
+ * 1 - Multi-zone
+@@ -133,6 +140,7 @@ Date: Apr 2024
+ KernelVersion: 6.10
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ List the available mini-led modes.
+
+ What: /sys/devices/platform/<platform>/ppt_pl1_spl
+@@ -140,6 +148,7 @@ Date: Jun 2023
+ KernelVersion: 6.5
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ Set the Package Power Target total of CPU: PL1 on Intel, SPL on AMD.
+ Shown on Intel+Nvidia or AMD+Nvidia based systems:
+
+@@ -150,6 +159,7 @@ Date: Jun 2023
+ KernelVersion: 6.5
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ Set the Slow Package Power Tracking Limit of CPU: PL2 on Intel, SPPT,
+ on AMD. Shown on Intel+Nvidia or AMD+Nvidia based systems:
+
+@@ -160,6 +170,7 @@ Date: Jun 2023
+ KernelVersion: 6.5
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ Set the Fast Package Power Tracking Limit of CPU. AMD+Nvidia only:
+ * min=5, max=250
+
+@@ -168,6 +179,7 @@ Date: Jun 2023
+ KernelVersion: 6.5
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ Set the APU SPPT limit. Shown on full AMD systems only:
+ * min=5, max=130
+
+@@ -176,6 +188,7 @@ Date: Jun 2023
+ KernelVersion: 6.5
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ Set the platform SPPT limit. Shown on full AMD systems only:
+ * min=5, max=130
+
+@@ -184,6 +197,7 @@ Date: Jun 2023
+ KernelVersion: 6.5
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ Set the dynamic boost limit of the Nvidia dGPU:
+ * min=5, max=25
+
+@@ -192,6 +206,7 @@ Date: Jun 2023
+ KernelVersion: 6.5
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ Set the target temperature limit of the Nvidia dGPU:
+ * min=75, max=87
+
+@@ -200,6 +215,7 @@ Date: Apr 2024
+ KernelVersion: 6.10
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ Set if the BIOS POST sound is played on boot.
+ * 0 - False,
+ * 1 - True
+@@ -209,6 +225,7 @@ Date: Apr 2024
+ KernelVersion: 6.10
+ Contact: "Luke Jones" <luke@ljones.dev>
+ Description:
++ DEPRECATED, WILL BE REMOVED SOON
+ Set if the MCU can go in to low-power mode on system sleep
+ * 0 - False,
+ * 1 - True
+diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
+index 296b5c9bfbb0..f2dbdaae0665 100644
+--- a/drivers/platform/x86/Kconfig
++++ b/drivers/platform/x86/Kconfig
+@@ -300,6 +300,14 @@ config ASUS_WMI
+ To compile this driver as a module, choose M here: the module will
+ be called asus-wmi.
+
++config ASUS_WMI_BIOS
++ bool "BIOS option support in WMI platform (DEPRECATED)"
++ depends on ASUS_WMI
++ help
++ Say Y to expose the configurable BIOS options through the asus-wmi
++ driver. This can be used with or without the new asus-bios driver as
++ the options are the same but the asus-bios driver has more features.
++
+ config ASUS_NB_WMI
+ tristate "Asus Notebook WMI Driver"
+ depends on ASUS_WMI
+diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
+index a6f2e5325a60..903f8340b5aa 100644
+--- a/drivers/platform/x86/asus-wmi.c
++++ b/drivers/platform/x86/asus-wmi.c
+@@ -269,11 +269,12 @@ struct asus_wmi {
+ u8 fan_boost_mode_mask;
+ u8 fan_boost_mode;
+
++
++ /* Tunables provided by ASUS for gaming laptops */
++ #if IS_ENABLED(CONFIG_ASUS_WMI_BIOS)
+ bool egpu_enable_available;
+ bool dgpu_disable_available;
+ u32 gpu_mux_dev;
+-
+- /* Tunables provided by ASUS for gaming laptops */
+ u32 ppt_pl2_sppt;
+ u32 ppt_pl1_spl;
+ u32 ppt_apu_sppt;
+@@ -281,6 +282,9 @@ struct asus_wmi {
+ u32 ppt_fppt;
+ u32 nv_dynamic_boost;
+ u32 nv_temp_target;
++ bool panel_overdrive_available;
++ u32 mini_led_dev_id;
++ #endif
+
+ u32 kbd_rgb_dev;
+ bool kbd_rgb_state_available;
+@@ -299,9 +303,6 @@ struct asus_wmi {
+ // The RSOC controls the maximum charging percentage.
+ bool battery_rsoc_available;
+
+- bool panel_overdrive_available;
+- u32 mini_led_dev_id;
+-
+ struct hotplug_slot hotplug_slot;
+ struct mutex hotplug_lock;
+ struct mutex wmi_lock;
+@@ -315,6 +316,15 @@ struct asus_wmi {
+ struct asus_wmi_driver *driver;
+ };
+
++#if IS_ENABLED(CONFIG_ASUS_WMI_BIOS)
++void asus_wmi_show_deprecated(void)
++{
++ pr_notice_once("Accessing attributes through /sys/bus/platform/asus_wmi is \
++ deprecated and will be removed in a future release. Please switch \
++ over to /sys/class/firmware_attributes.");
++}
++#endif
++
+ /* WMI ************************************************************************/
+
+ static int asus_wmi_evaluate_method3(u32 method_id,
+@@ -683,6 +693,7 @@ static void asus_wmi_tablet_mode_get_state(struct asus_wmi *asus)
+ }
+
+ /* Charging mode, 1=Barrel, 2=USB ******************************************/
++#if IS_ENABLED(CONFIG_ASUS_WMI_BIOS)
+ static ssize_t charge_mode_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+ {
+@@ -693,12 +704,16 @@ static ssize_t charge_mode_show(struct device *dev,
+ if (result < 0)
+ return result;
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "%d\n", value & 0xff);
+ }
+
+ static DEVICE_ATTR_RO(charge_mode);
++#endif
+
+ /* dGPU ********************************************************************/
++#if IS_ENABLED(CONFIG_ASUS_WMI_BIOS)
+ static ssize_t dgpu_disable_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+ {
+@@ -709,6 +724,8 @@ static ssize_t dgpu_disable_show(struct device *dev,
+ if (result < 0)
+ return result;
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "%d\n", result);
+ }
+
+@@ -762,8 +779,10 @@ static ssize_t dgpu_disable_store(struct device *dev,
+ return count;
+ }
+ static DEVICE_ATTR_RW(dgpu_disable);
++#endif
+
+ /* eGPU ********************************************************************/
++#if IS_ENABLED(CONFIG_ASUS_WMI_BIOS)
+ static ssize_t egpu_enable_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+ {
+@@ -774,6 +793,8 @@ static ssize_t egpu_enable_show(struct device *dev,
+ if (result < 0)
+ return result;
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "%d\n", result);
+ }
+
+@@ -830,8 +851,10 @@ static ssize_t egpu_enable_store(struct device *dev,
+ return count;
+ }
+ static DEVICE_ATTR_RW(egpu_enable);
++#endif
+
+ /* Is eGPU connected? *********************************************************/
++#if IS_ENABLED(CONFIG_ASUS_WMI_BIOS)
+ static ssize_t egpu_connected_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+ {
+@@ -842,12 +865,16 @@ static ssize_t egpu_connected_show(struct device *dev,
+ if (result < 0)
+ return result;
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "%d\n", result);
+ }
+
+ static DEVICE_ATTR_RO(egpu_connected);
++#endif
+
+ /* gpu mux switch *************************************************************/
++#if IS_ENABLED(CONFIG_ASUS_WMI_BIOS)
+ static ssize_t gpu_mux_mode_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+ {
+@@ -858,6 +885,8 @@ static ssize_t gpu_mux_mode_show(struct device *dev,
+ if (result < 0)
+ return result;
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "%d\n", result);
+ }
+
+@@ -916,6 +945,7 @@ static ssize_t gpu_mux_mode_store(struct device *dev,
+ return count;
+ }
+ static DEVICE_ATTR_RW(gpu_mux_mode);
++#endif
+
+ /* TUF Laptop Keyboard RGB Modes **********************************************/
+ static ssize_t kbd_rgb_mode_store(struct device *dev,
+@@ -1035,6 +1065,7 @@ static const struct attribute_group *kbd_rgb_mode_groups[] = {
+ };
+
+ /* Tunable: PPT: Intel=PL1, AMD=SPPT *****************************************/
++#if IS_ENABLED(CONFIG_ASUS_WMI_BIOS)
+ static ssize_t ppt_pl2_sppt_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t count)
+@@ -1073,6 +1104,8 @@ static ssize_t ppt_pl2_sppt_show(struct device *dev,
+ {
+ struct asus_wmi *asus = dev_get_drvdata(dev);
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "%u\n", asus->ppt_pl2_sppt);
+ }
+ static DEVICE_ATTR_RW(ppt_pl2_sppt);
+@@ -1115,6 +1148,8 @@ static ssize_t ppt_pl1_spl_show(struct device *dev,
+ {
+ struct asus_wmi *asus = dev_get_drvdata(dev);
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "%u\n", asus->ppt_pl1_spl);
+ }
+ static DEVICE_ATTR_RW(ppt_pl1_spl);
+@@ -1158,6 +1193,8 @@ static ssize_t ppt_fppt_show(struct device *dev,
+ {
+ struct asus_wmi *asus = dev_get_drvdata(dev);
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "%u\n", asus->ppt_fppt);
+ }
+ static DEVICE_ATTR_RW(ppt_fppt);
+@@ -1201,6 +1238,8 @@ static ssize_t ppt_apu_sppt_show(struct device *dev,
+ {
+ struct asus_wmi *asus = dev_get_drvdata(dev);
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "%u\n", asus->ppt_apu_sppt);
+ }
+ static DEVICE_ATTR_RW(ppt_apu_sppt);
+@@ -1244,6 +1283,8 @@ static ssize_t ppt_platform_sppt_show(struct device *dev,
+ {
+ struct asus_wmi *asus = dev_get_drvdata(dev);
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "%u\n", asus->ppt_platform_sppt);
+ }
+ static DEVICE_ATTR_RW(ppt_platform_sppt);
+@@ -1287,6 +1328,8 @@ static ssize_t nv_dynamic_boost_show(struct device *dev,
+ {
+ struct asus_wmi *asus = dev_get_drvdata(dev);
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "%u\n", asus->nv_dynamic_boost);
+ }
+ static DEVICE_ATTR_RW(nv_dynamic_boost);
+@@ -1330,11 +1373,15 @@ static ssize_t nv_temp_target_show(struct device *dev,
+ {
+ struct asus_wmi *asus = dev_get_drvdata(dev);
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "%u\n", asus->nv_temp_target);
+ }
+ static DEVICE_ATTR_RW(nv_temp_target);
++#endif
+
+ /* Ally MCU Powersave ********************************************************/
++#if IS_ENABLED(CONFIG_ASUS_WMI_BIOS)
+ static ssize_t mcu_powersave_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+ {
+@@ -1345,6 +1392,8 @@ static ssize_t mcu_powersave_show(struct device *dev,
+ if (result < 0)
+ return result;
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "%d\n", result);
+ }
+
+@@ -1380,6 +1429,7 @@ static ssize_t mcu_powersave_store(struct device *dev,
+ return count;
+ }
+ static DEVICE_ATTR_RW(mcu_powersave);
++#endif
+
+ /* Battery ********************************************************************/
+
+@@ -2209,6 +2259,7 @@ static int asus_wmi_rfkill_init(struct asus_wmi *asus)
+ }
+
+ /* Panel Overdrive ************************************************************/
++#if IS_ENABLED(CONFIG_ASUS_WMI_BIOS)
+ static ssize_t panel_od_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+ {
+@@ -2219,6 +2270,8 @@ static ssize_t panel_od_show(struct device *dev,
+ if (result < 0)
+ return result;
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "%d\n", result);
+ }
+
+@@ -2255,9 +2308,10 @@ static ssize_t panel_od_store(struct device *dev,
+ return count;
+ }
+ static DEVICE_ATTR_RW(panel_od);
++#endif
+
+ /* Bootup sound ***************************************************************/
+-
++#if IS_ENABLED(CONFIG_ASUS_WMI_BIOS)
+ static ssize_t boot_sound_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+ {
+@@ -2268,6 +2322,8 @@ static ssize_t boot_sound_show(struct device *dev,
+ if (result < 0)
+ return result;
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "%d\n", result);
+ }
+
+@@ -2303,8 +2359,10 @@ static ssize_t boot_sound_store(struct device *dev,
+ return count;
+ }
+ static DEVICE_ATTR_RW(boot_sound);
++#endif
+
+ /* Mini-LED mode **************************************************************/
++#if IS_ENABLED(CONFIG_ASUS_WMI_BIOS)
+ static ssize_t mini_led_mode_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+ {
+@@ -2335,6 +2393,8 @@ static ssize_t mini_led_mode_show(struct device *dev,
+ }
+ }
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "%d\n", value);
+ }
+
+@@ -2405,10 +2465,13 @@ static ssize_t available_mini_led_mode_show(struct device *dev,
+ return sysfs_emit(buf, "0 1 2\n");
+ }
+
++ asus_wmi_show_deprecated();
++
+ return sysfs_emit(buf, "0\n");
+ }
+
+ static DEVICE_ATTR_RO(available_mini_led_mode);
++#endif
+
+ /* Quirks *********************************************************************/
+
+@@ -4374,27 +4437,29 @@ static struct attribute *platform_attributes[] = {
+ &dev_attr_camera.attr,
+ &dev_attr_cardr.attr,
+ &dev_attr_touchpad.attr,
+- &dev_attr_charge_mode.attr,
+- &dev_attr_egpu_enable.attr,
+- &dev_attr_egpu_connected.attr,
+- &dev_attr_dgpu_disable.attr,
+- &dev_attr_gpu_mux_mode.attr,
+ &dev_attr_lid_resume.attr,
+ &dev_attr_als_enable.attr,
+ &dev_attr_fan_boost_mode.attr,
+ &dev_attr_throttle_thermal_policy.attr,
+- &dev_attr_ppt_pl2_sppt.attr,
+- &dev_attr_ppt_pl1_spl.attr,
+- &dev_attr_ppt_fppt.attr,
+- &dev_attr_ppt_apu_sppt.attr,
+- &dev_attr_ppt_platform_sppt.attr,
+- &dev_attr_nv_dynamic_boost.attr,
+- &dev_attr_nv_temp_target.attr,
+- &dev_attr_mcu_powersave.attr,
+- &dev_attr_boot_sound.attr,
+- &dev_attr_panel_od.attr,
+- &dev_attr_mini_led_mode.attr,
+- &dev_attr_available_mini_led_mode.attr,
++ #if IS_ENABLED(CONFIG_ASUS_WMI_BIOS)
++ &dev_attr_charge_mode.attr,
++ &dev_attr_egpu_enable.attr,
++ &dev_attr_egpu_connected.attr,
++ &dev_attr_dgpu_disable.attr,
++ &dev_attr_gpu_mux_mode.attr,
++ &dev_attr_ppt_pl2_sppt.attr,
++ &dev_attr_ppt_pl1_spl.attr,
++ &dev_attr_ppt_fppt.attr,
++ &dev_attr_ppt_apu_sppt.attr,
++ &dev_attr_ppt_platform_sppt.attr,
++ &dev_attr_nv_dynamic_boost.attr,
++ &dev_attr_nv_temp_target.attr,
++ &dev_attr_mcu_powersave.attr,
++ &dev_attr_boot_sound.attr,
++ &dev_attr_panel_od.attr,
++ &dev_attr_mini_led_mode.attr,
++ &dev_attr_available_mini_led_mode.attr,
++ #endif
+ NULL
+ };
+
+@@ -4416,7 +4481,13 @@ static umode_t asus_sysfs_is_visible(struct kobject *kobj,
+ devid = ASUS_WMI_DEVID_LID_RESUME;
+ else if (attr == &dev_attr_als_enable.attr)
+ devid = ASUS_WMI_DEVID_ALS_ENABLE;
+- else if (attr == &dev_attr_charge_mode.attr)
++ else if (attr == &dev_attr_fan_boost_mode.attr)
++ ok = asus->fan_boost_mode_available;
++ else if (attr == &dev_attr_throttle_thermal_policy.attr)
++ ok = asus->throttle_thermal_policy_available;
++
++ #if IS_ENABLED(CONFIG_ASUS_WMI_BIOS)
++ if (attr == &dev_attr_charge_mode.attr)
+ devid = ASUS_WMI_DEVID_CHARGE_MODE;
+ else if (attr == &dev_attr_egpu_enable.attr)
+ ok = asus->egpu_enable_available;
+@@ -4426,10 +4497,6 @@ static umode_t asus_sysfs_is_visible(struct kobject *kobj,
+ ok = asus->dgpu_disable_available;
+ else if (attr == &dev_attr_gpu_mux_mode.attr)
+ ok = asus->gpu_mux_dev != 0;
+- else if (attr == &dev_attr_fan_boost_mode.attr)
+- ok = asus->fan_boost_mode_available;
+- else if (attr == &dev_attr_throttle_thermal_policy.attr)
+- ok = asus->throttle_thermal_policy_available;
+ else if (attr == &dev_attr_ppt_pl2_sppt.attr)
+ devid = ASUS_WMI_DEVID_PPT_PL2_SPPT;
+ else if (attr == &dev_attr_ppt_pl1_spl.attr)
+@@ -4454,6 +4521,7 @@ static umode_t asus_sysfs_is_visible(struct kobject *kobj,
+ ok = asus->mini_led_dev_id != 0;
+ else if (attr == &dev_attr_available_mini_led_mode.attr)
+ ok = asus->mini_led_dev_id != 0;
++ #endif
+
+ if (devid != -1) {
+ ok = !(asus_wmi_get_devstate_simple(asus, devid) < 0);
+@@ -4694,6 +4762,7 @@ static int asus_wmi_add(struct platform_device *pdev)
+ goto fail_platform;
+
+ /* ensure defaults for tunables */
++ #if IS_ENABLED(CONFIG_ASUS_WMI_BIOS)
+ asus->ppt_pl2_sppt = 5;
+ asus->ppt_pl1_spl = 5;
+ asus->ppt_apu_sppt = 5;
+@@ -4717,6 +4786,7 @@ static int asus_wmi_add(struct platform_device *pdev)
+ asus->gpu_mux_dev = ASUS_WMI_DEVID_GPU_MUX;
+ else if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_GPU_MUX_VIVO))
+ asus->gpu_mux_dev = ASUS_WMI_DEVID_GPU_MUX_VIVO;
++ #endif
+
+ if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_TUF_RGB_MODE))
+ asus->kbd_rgb_dev = ASUS_WMI_DEVID_TUF_RGB_MODE;
+--
+2.45.1
+