blob: 9cde5a976120ec7bf40d3ca3f7b6f26a36982797 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
|
From 3e06125358a050cc6535befd4fbd5b4f160a56b9 Mon Sep 17 00:00:00 2001
From: Matt Jolly <kangie@gentoo.org>
Date: Tue, 25 Mar 2025 13:33:48 +1000
Subject: [PATCH] Remove nodejs version check
Added in https://github.com/chromium/chromium/commit/0ff8528999941d7182be6fc77aeb12a110a3cd86,
this change is only really useful for gclient checkouts and breaks the
ability for downstreams to provide their own, compatible, nodejs
version via the system package manager (or for use on arches other than
those that Google provides binaries for):
[ERR_ASSERTION]: Failed NodeJS version check: Expected version 'v22.11.0', but found 'v22.13.1'. Did you run 'gclient sync'
This is google development footgun protection, working around
poor development practices and gclient's inability to ensure
that the source tree is in a consistent state. We don't need it
here.
Signed-off-by: Matt Jolly <kangie@gentoo.org>
--- a/third_party/node/node.gni
+++ b/third_party/node/node.gni
@@ -36,15 +36,5 @@ template("node") {
}
}
- # Automatically add a dependency to ":check_version" to ensure NodeJS is
- # always running the expected version, except when the ':check_version'
- # target itself is running in which case it shouldn't depend on itself.
- if (get_label_info(":" + target_name, "label_no_toolchain") !=
- "//third_party/node:check_version") {
- if (!defined(deps)) {
- deps = []
- }
- deps += [ "//third_party/node:check_version" ]
- }
}
}
--
2.48.1
|