Arch Linux User Repository

@FrederickZh thanks for the backport

It seems we need to backport https://github.com/vmatare/thinkfan/commit/9a628fcb7f8e19e84e2bc030a66ba0ae2192731f

diff --git a/PKGBUILD b/PKGBUILD
index 8fcb2aa..7ec7102 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -14,15 +14,22 @@ depends=('libatasmart' 'yaml-cpp')
 optdepends=('lm_sensors: hwmon support')
 backup=('etc/systemd/system/thinkfan.service.d/override.conf')
 license=('GPL-3.0-or-later')
 source=("$pkgname-$pkgver.tar.gz::https://github.com/vmatare/$pkgname/archive/$pkgver.tar.gz"
+        'fix-cmake-warnings.patch'
         'thinkfan.service'
         'thinkpad_acpi.conf')
 sha256sums=('9466c8c82b7c4333b280fa66445ab26185ffbb4aada6bcb4a164eed742f8d78c'
+            '8ee1fbe82d29cda85be470d9d77f524f0030206d573d6d13f15d67742e6dc1a1'
             '625730e33fae251f3a1cc8259b222089fb45ada08e9cf5c816ea1cde6560e989'
             '28874576641b3cc1aa486e1bc9ed40eadfe8b13d6d3014016e31fedc5dc5195f')
 install=thinkfan.install

+prepare() {
+  cd "$srcdir/$pkgname-$pkgver"
+  patch -Np1 -i "$srcdir/fix-cmake-warnings.patch"
+}
+
 build() {
   cd "$srcdir/$pkgname-$pkgver"

   cmake . -DCMAKE_INSTALL_PREFIX=/usr -DUSE_ATASMART:BOOL=ON
diff --git a/fix-cmake-warnings.patch b/fix-cmake-warnings.patch
new file mode 100644
index 0000000..599ef56
--- /dev/null
+++ b/fix-cmake-warnings.patch
@@ -0,0 +1,33 @@
+From 679004c08731330adf2f8dd4c2ce7cf86408db55 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Victor=20Matar=C3=A9?= <matare@fh-aachen.de>
+Date: Tue, 15 Oct 2024 20:12:34 +0200
+Subject: [PATCH] fix cmake warnings
+
+[1] https://github.com/vmatare/thinkfan/commit/9a628fcb7f8e19e84e2bc030a66ba0ae2192731f
+
+Signed-off-by: Frederick Zhang <frederick888@tsundere.moe>
+---
+ CMakeLists.txt | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 66bf07e..0e81354 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -1,11 +1,11 @@
++cmake_minimum_required(VERSION 3.5)
++
+ project(thinkfan)
+ include(GNUInstallDirs)
+ 
+ set(THINKFAN_VERSION 1.3.1)
+ 
+-cmake_minimum_required(VERSION 3.0)
+-
+ # Generate absolute paths or something
+ cmake_policy(SET CMP0015 NEW)
+ 
+ find_package(PkgConfig)
+-- 
+2.49.0
+

Currently i get this error on the installation / compile. Someone have an idea? ;-) Thanks!

==> Starting build()...
CMake Warning (dev) at CMakeLists.txt:1 (project):
  cmake_minimum_required() should be called prior to this top-level project()
  call.  Please see the cmake-commands(7) manual for usage documentation of
  both commands.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- The C compiler identification is GNU 14.2.1
-- The CXX compiler identification is GNU 14.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:6 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: thinkfan-exit status 4
 -> Failed to install the following packages. Manual intervention is required:
thinkfan - exit status 4

@dude Thanks! I reinstall thinkfan, can fix this error.

/usr/bin/thinkfan: error while loading shared libraries: libyaml-cpp.so.0.7: cannot open shared object file: No such file or directory

@seqfault Don't symlink, just rebuild thinkfan whenever yaml-cpp gets updated.

now that yaml-cpp updated to 0.8.0 and thinkfan has 0.7.0 dependency hardcoded which likely won't be solved soon (see https://github.com/vmatare/thinkfan/issues/233), you can make a symlink and it'll work fine: sudo ln -s libyaml-cpp.so.0.8 /usr/lib/libyaml-cpp.so.0.7

Could you add the "-DUSE_LM_SENSORS:BOOL=ON" Switch to the cmake command? Its about this bug: https://github.com/vmatare/thinkfan/issues/229

@buzo Thanks, I missed that announcement.

Actually, base-devel is a meta package now, not a group any more – see this announcement. (See also the PKGBUILD Wiki page.)

@bachtiar Packages from the base-devel group are assumed to already be installed, so they aren't included in the build dependencies.