Arch Linux User Repository

If you have suggestions for changes, feel free to open a MR against the arrpc branch of https://gitlab.archlinux.org/freso/arrpc

If you have suggestions for changes, feel free to open a MR against the arrpc branch of https://gitlab.archlinux.org/freso/arrpc

Here is my proposed changes:

diff --git a/PKGBUILD b/PKGBUILD
index 1455fa6..6da0c02 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -2,12 +2,12 @@
 # Contributor: Scarlett Veldt <scarlett AT enby DOT site>
 pkgname=arrpc
 pkgver=3.5.0
-pkgrel=1
+pkgrel=2
 pkgdesc="Open Discord RPC server for atypical setups"
-arch=('x86_64' 'x86_64_v3')
+arch=('any')
 url="https://arrpc.openasar.dev/"
 license=('MIT')
-depends=("glibc" "gcc-libs")
+depends=("nodejs")
 makedepends=("npm")
 # for some reason stripping the binary breaks it
 options=(!strip)
@@ -17,7 +17,13 @@ source=("$pkgname-$pkgver.tar.gz::https://github.com/OpenAsar/arrpc/archive/refs
 sha256sums=('85f3c52b035af322789c749ad3910aca350d057ce97c98965bbf922acc74c68b'
             'dccc409ef768766d8d4141f8d89366e0bbecd30d9b08d4d31856b01f180c4005')

+build(){
+ cd "${srcdir}/${pkgname}-${pkgver}"
+ node update_db.js
+}
+
 package() {
+  cd "${srcdir}"
   npm install --cache "${srcdir}/npm-cache" \
     -g --prefix "${pkgdir}/usr" \
     "${srcdir}/${pkgname}-${pkgver}.tar.gz"

1. Change arch() to any as there are no compiled binaries in this package.
2. Remove glibc and gcc-libs from depends() as there are no compiled binaries in this package.
3. Add nodejs to depends as this package requries nodejs to run.
4. Update the game database use nodejs in build().

There is no need to do a npm pack or npm install in build() as the arrpc-$pkgver.tar.gz comes with all the node modules pre-vendored.

You can always use the tool namcap to do an automated quality control check on your packages.

@xpander

npm install and npm pack are not needed. The archive comes with all the node modules needed in arrpc-3.5.0/node_modules, which is just ws. npm pack is not needed as we do not use the archive that is generated by it; we already have everything needed to be done by npm inside of package().

the node update_db.js is the only thing valid in your PKGBUILD

The PKGBUILD is still broken. its also missing build() section at the moment

managed to build it with modifications:

# Maintainer: Frederik “Freso” S. Olesen <archlinux@freso.dk>
# Contributor: Scarlett Veldt <scarlett AT enby DOT site>
pkgname=arrpc
pkgver=3.5.0
pkgrel=1
pkgdesc="Open Discord RPC server for atypical setups"
arch=('x86_64' 'x86_64_v3')
url="https://arrpc.openasar.dev/"
license=('MIT')
depends=("glibc" "gcc-libs" "nodejs")
makedepends=("npm")
# for some reason stripping the binary breaks it
options=(!strip)
install=arrpc.install
source=("$pkgname-$pkgver.tar.gz::https://github.com/OpenAsar/arrpc/archive/refs/tags/${pkgver}.tar.gz"
        "arrpc.service")
sha256sums=('85f3c52b035af322789c749ad3910aca350d057ce97c98965bbf922acc74c68b'
            'dccc409ef768766d8d4141f8d89366e0bbecd30d9b08d4d31856b01f180c4005')
build() {
    cd "${pkgname}-${pkgver}" || exit 1
    node update_db.js
    npm install
    npm pack
}

package() {
  npm install --cache "${srcdir}/npm-cache" \
    -g --prefix "${pkgdir}/usr" \
    "${srcdir}/${pkgname}-${pkgver}.tar.gz"

  install -D -m644 "${pkgname}-${pkgver}"/LICENSE "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"
  install -D -m644 arrpc.service "${pkgdir}/usr/lib/systemd/user/arrpc.service"
} 

as schneensch commented: https://aur.archlinux.org/packages/arrpc#comment-978415 please add nodejs as a dependency.

Shouldn't nodejs be added as a dependency to the PKGBUILD, as arrpc doesn't run without it?

For anyone trying to make this work, here's a full PKGBUILD with BrianAllred's and k1f0's fixes. I had to use makepkg --sync --install --force but I finally got it installed and running, systemd unit and all:

# Maintainer: Frederik “Freso” S. Olesen <archlinux@freso.dk>
# Contributor: Scarlett Veldt <scarlett AT enby DOT site>
pkgname=arrpc
pkgver=3.4.0
pkgrel=3
pkgdesc="Open Discord RPC server for atypical setups"
arch=('x86_64' 'x86_64_v3')
url="https://arrpc.openasar.dev/"
license=('MIT')
depends=("glibc" "gcc-libs" "nodejs")
makedepends=("npm")
# for some reason stripping the binary breaks it
options=(!strip)
install=arrpc.install
source=("$pkgname-$pkgver.tar.gz::https://github.com/OpenAsar/arrpc/archive/refs/tags/${pkgver}.tar.gz"
    "arrpc.service")
sha256sums=('8f1f2054e70221922f30920c3ef11cfdded1ddf7425f73c808c033bdc18a0911'
    'dccc409ef768766d8d4141f8d89366e0bbecd30d9b08d4d31856b01f180c4005')
build() {
    cd "${pkgname}-${pkgver}" || exit 1
    node update_db.js
    npm install
    npm pack
}

package() {
    cd "${pkgname}-${pkgver}" || exit 1
    npm install --cache "${srcdir}/npm-cache" \
        -g --prefix "${pkgdir}/usr" \
        "${pkgname}-${pkgver}.tgz"

    install -D -m644 LICENSE "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"
    install -D -m644 ../arrpc.service "${pkgdir}/usr/lib/systemd/user/arrpc.service"
}

This needs nodejs as a runtime dependency. I removed it because none of my packages explicitly depended on it, and arrpc broke as a result.

/usr/bin/env: ‘node’: No such file or directory

Adjusted again, this should now do it, also uses the updater script to pull the newest detectable DB before installing.

+build() {
+  cd "${pkgname}-${pkgver}"
+  node update_db.js
+  npm install
+  npm pack
+}
+
 package() {
+  cd "${pkgname}-${pkgver}"
   npm install --cache "${srcdir}/npm-cache" \
     -g --prefix "${pkgdir}/usr" \
-    "${srcdir}/${pkgname}-${pkgver}.tar.gz"
+    "${pkgname}-${pkgver}.tgz"

-  install -D -m644 "${pkgname}-${pkgver}"/LICENSE "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"
-  install -D -m644 arrpc.service "${pkgdir}/usr/lib/systemd/user/arrpc.service"
+  install -D -m644 LICENSE "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"
+  install -D -m644 ../arrpc.service "${pkgdir}/usr/lib/systemd/user/arrpc.service"
 }

k1f0's solution works for me, you might have just made a typo? edit: It worked once, no longer. Cloning and running the GitHub source works.