Package Details: bandcamp-dl-git v0.0.16.r0.gcdf24c0-1

Git Clone URL: https://aur.archlinux.org/bandcamp-dl-git.git (read-only, click to copy)
Package Base: bandcamp-dl-git
Description: Download audio from bandcamp.com
Upstream URL: https://github.com/iheanyi/bandcamp-dl
Licenses: Unlicense
Conflicts: bandcamp-dl
Provides: bandcamp-dl
Submitter: cyrevolt
Maintainer: jneidel
Last Packager: jneidel
Votes: 7
Popularity: 0.29
First Submitted: 2020-10-13 17:23 (UTC)
Last Updated: 2024-09-12 15:52 (UTC)

Latest Comments

« First ‹ Previous 1 2

cyrevolt commented on 2020-10-17 09:14 (UTC)

@rien333 Yea the demjson thing is a bit unfortunate, agreed. We can see about a stable python-demjson package and/or ask and take over maintenance of the git one.

Agreed to the description, I will update it.

I went with sed because it won't fail now that the PR to fix the issue it was about has been merged. A patch would fail to apply, I think. Anyway, even that can be removed now.

iheanyi wrote that they are looking into further maintenance when they have the necessary means: https://github.com/iheanyi/bandcamp-dl/pull/171#issuecomment-710711132

At least we can download quite some music now without hassle. :)

rien333 commented on 2020-10-14 11:03 (UTC) (edited on 2020-10-14 11:04 (UTC) by rien333)

@cyrevolt I was just in the process of submitting this package, thanks for your work!

I wanted to wait a little bit, however, because python-demjson-git pulls a lot of python2 (make) dependencies, and for some reason also installs a python2 version of the demjson package (i.e. its basically incorrectly packaged, especially now python2 is being phased out everywhere). In fact, I'm having some issues installing it right now due to python2 problems. I've already notified the maintainer of python-demjson-git, but I'm not sure they'll respond.

I also did some small things differently, not sure if you like them (it was my first attempt at making an AUR package)

Instead of using a sed command to patch stuff, I did the following:

source=('git+https://github.com/iheanyi/bandcamp-dl'
        'https://github.com/iheanyi/bandcamp-dl/pull/171.patch')
sha256sums=('SKIP'
            '73b92bdd49c606d529de54d60a9097256019c00f7da36e8d1bbfe58dfb1679d2')
...
prepare() {
  cd "${srcdir}/bandcamp-dl"
  patch -p1 < ../171.patch
}

In terms of pkgdesc, I don't really dig iheanyi's description (nobody actually stylizes "BandCamp" or its domains using camel case, see e.g. the bandcamp wikipedia page). I came up with pkgdesc="Download auto-tagged audio from bandcamp" (its excellent auto-tagging ability is imo the main distinghuising feature of this downloader)

yochananmarqos commented on 2020-10-13 20:15 (UTC)

@cryrevolt: Ugh, that is confusing. May as well leave it as is, then. You might want to add bandcamp-downloader to provides() and conflicts(), though.

FYI, you can still view deleted AUR packages like this: https://aur.archlinux.org/cgit/aur.git/plain/PKGBUILD?h=bandcamp-dl

cyrevolt commented on 2020-10-13 19:00 (UTC) (edited on 2020-10-13 19:03 (UTC) by cyrevolt)

@yochananmarqos interesting point. The package is also called bandcamp-dl in Homebrew and the CLI tool has that name as well.

There is another one: https://github.com/Granitosaurus/bandcamp-downloader That was used in the bandcamp-dl AUR package https://aur.archlinux.org/packages/bandcamp-dl but that no longer shows up on AUR. However, you can still clone aur@aur.archlinux.org:bandcamp-dl.

Now I am really not sure what would be even more confusing. I chose to match the CLI command and repository name.

yochananmarqos commented on 2020-10-13 18:32 (UTC) (edited on 2020-10-13 18:33 (UTC) by yochananmarqos)

This package should be called bandcamp-downloader to match the Python package name and not to be confused with bandcamp_dl.

« First ‹ Previous 1 2