Arch Linux User Repository

The package builds both in a clean chroot and with yay

Please update to Cockpit File Sharing 4.2.13-2 and please fix build issues

build fails when trying to build with yay and with makepkg -i https://gist.github.com/OzzyHelix/480c642f45d7931d084918203ca55da6

@Lucki have you tried the change to the package function suggested here: https://aur.archlinux.org/packages/cockpit-file-sharing?O=0#comment-1026665

@michael_wzq does this build in a clean chroot for you?

This fails building.

==> Starting package()...
./bootstrap.sh
+ command -v sponge
+ command -v yarn
+ jq 'del(.packageManager)' ./package.json
+ sponge ./package.json
+ rm .yarnrc.yml .yarn -rf
+ yarn set version stable
cp -af system_files/* /build/cockpit-file-sharing/pkg/cockpit-file-sharing//
Installing file-sharing
Creating install directory
mkdir -p /build/cockpit-file-sharing/pkg/cockpit-file-sharing//usr/share/cockpit/file-sharing
cp: cannot stat 'system_files/*': No such file or directory

make: [Makefile:133: system-files-install] Error 1 (ignored)
Copying files
cp: cannot stat 'file-sharing/dist/*': No such file or directory
/bin/sh: line 3: rsync: command not found
make: *** [Makefile:116: plugin-install-file-sharing] Error 127
make: *** Waiting for unfinished jobs....
➤ YN0000: You don't seem to have Corepack enabled; we'll have to rely on yarnPath instead
➤ YN0000: Downloading https://repo.yarnpkg.com/4.9.2/packages/yarnpkg-cli/bin/yarn.js
➤ YN0000: Saving the new release in .yarn/releases/yarn-4.9.2.cjs
➤ YN0000: Done with warnings in 0s 194ms
+ yarn config set nodeLinker node-modules
➤ YN0000: Successfully set nodeLinker to 'node-modules'
==> ERROR: A failure occurred in package().

Ok actually figured it out

update package() to this

package() {
  cd "$srcdir/$pkgname" || exit 1
  make DESTDIR="$pkgdir/"
  make DESTDIR="$pkgdir/" install RESTART_COCKPIT=1
}

Comment out lines 20 and 21

REMOTE_TEST_HOST=192.168.123.5
REMOTE_TEST_USER=root

ok i tried a clean build with it, and it fails

some how running pkgbuild, fail to build, edit makefile, run pkgbuild again works

The package fails to build in a clean chroot because rsync is missing.

@RuneArch this is NOT a cyber security issue. It is trying to call home to a non public IP (192.168.123.5). I am pretty sure it is a bug in the make file (https://github.com/45Drives/cockpit-file-sharing/blob/main/Makefile) where plugin-install- fails at cp -af $/dist/ $(DESTDIR)$(INSTALL_PREFIX)/$*$(INSTALL_SUFFIX) and drops into a remote testing install. That said make files are black magic to me so I have no idea why it is failing or how to fix it.

My guess is it is an Arch issue of how/where the sources are getting unpacked as opposed to upstream, but again it is way over my head.

Not happy seeing this in the logs:

ssh: connect to host 192.168.123.5 port 22: Connection refused
rsync: connection unexpectedly closed (0 bytes received so far) [sender]
rsync error: unexplained error (code 255) at io.c(232) [sender=3.4.1]

Why would an installation package be attempting to ssh or rsync anything?

Nothing obvious in the PKGBUILD or the .git folder, so I'm presuming that a live downloaded package is attempting this... do we have a cyber security issue here?

[...]
dist/index.html                                       0.67 kB │ gzip:   0.36 kB
dist/assets/index-pxqS8i7E.css                    1,214.05 kB │ gzip: 157.74 kB
dist/assets/magic-string.es-Cb3vBffY-BR_V5wlq.js     21.45 kB │ gzip:   7.04 kB │ map:    81.40 kB
dist/assets/index-BxE0gm2N-CXx_dn26.js              221.86 kB │ gzip:  68.42 kB │ map:   794.39 kB
dist/assets/index-dZIUCUCY.js                     1,166.14 kB │ gzip: 639.08 kB │ map: 2,893.98 kB

(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
✓ built in 9.42s
Done building file-sharing

ssh: connect to host 192.168.123.5 port 22: Connection timed out
rsync: connection unexpectedly closed (0 bytes received so far) [sender]
rsync error: unexplained error (code 255) at io.c(232) [sender=3.4.1]
make: *** [Makefile:116: plugin-install-file-sharing] Error 255
==> ERROR: A failure occurred in package().
    Aborting...

Command 'sudo --user=#1000 --preserve-env=VISUAL,EDITOR -- makepkg --force' failed to execute.

Any idea why it want to connect to "192.168.123.5"!??