Package Details: cropgui-git 1:0.2.r60.g541e812-1

Git Clone URL: (read-only)
Package Base: cropgui-git
Description: A GTK GUI for lossless JPEG cropping (and rotating)
Upstream URL:
Licenses: GPL
Conflicts: cropgui
Provides: cropgui
Submitter: rafaqzsu
Maintainer: Rhinoceros
Last Packager: Rhinoceros
Votes: 3
Popularity: 0.055628
First Submitted: 2015-11-26 09:16
Last Updated: 2017-03-02 00:04

Latest Comments

Rhinoceros commented on 2017-02-28 01:57

Well, I guess it adds a bit more information than a bare revision count would. I'm happy to take it over if you like. Cheers.

rafaqzsu commented on 2017-02-28 01:49

Ok yes I've obviously spent 2 mins reading the instructions! But my concern would still be that tags are irrelevant information as cropgui doesn't use tags in any meaningful way. Also Rhinocerous if you want to mange this repo and do it however you like, I would be delighted. I could spend this time actually writing code.

Rhinoceros commented on 2017-02-28 00:46

I think you might misunderstand. Both lines of code still pull the latest version, i.e. 541e812. The only difference is that the recommended pkgver lists the most recent version in the string itself, and counts revisions relative to this. Hence, users know that they are running a version 60 commits after 0.2.

I think you might be confusing it with non-vcs PKGBUILD, i.e. `cropgui` (without the `-git`), which would have a hard coded pkgver of 0.2. Unlike either vcs code, this would pull the 2009 version.

rafaqzsu commented on 2017-02-28 00:43

rafaqzsu commented on 2017-02-28 00:38

I hear you, but you will notice the tags haven't been updated since 2009, so waddyado. I need the recent changes, that's why this package exists. I you want to bug jepler about tagging, go for it and I'll update this too.

Rhinoceros commented on 2017-02-28 00:08

Thanks for the update. However, you are now using the "untagged" pkgver, instead of the code that I recommended. Since upstream *does* use tags, you should use the code in my last comment, as per the wiki [a again]. This makes the version `0.2.r60.g541e812-1` instead of the current `r135.541e812-1`, i.e. it includes the most recent tag in it.

(You won't need to rebump epoch this time, since 0… > r…)

Rhinoceros commented on 2017-02-23 06:45

It looks like your pkgver is only based on the commit hash, so pacman won't update it with new versions. See here for the proper way to do it [a].

Basically, you should use

git describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'

but given the current version is broken, you'll need to add a new epoch, too [b].


vasya commented on 2017-02-18 20:49

The build can be fixed by adding the second line of these two:
pkgver() {
cd "$srcdir/$pkgname"

simon04 commented on 2017-01-11 20:05

Building fails:
==> Starting pkgver()...
fatal: Not a git repository (or any parent up to mount point /var/cache/pacman/pkg)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
==> ERROR: pkgver is not allowed to be empty.
==> ERROR: pkgver() generated an invalid version:

NoSuck commented on 2016-12-23 19:56

Makepkg complains upon reaching pkgver about the current directory not being a git repo. Perhaps there needs to be a $( cd "$srcdir/$pkgname" ) in there.

All comments