can i suggest that riot-desktop.sh do:
exec electron /usr/lib/riot/ $@
instead of:
electron /usr/lib/riot/ $@
this removes the parent shell process that sits around doing nothing all day but waiting for electron to exit. saves 1 process and a bit of ram... :)
also in riot-desktop.desktop you should have
StartupWMClass=Riot
not
StartupWMClass="Riot"
The freedesktop.org standards dont allow quoting of field values. They allow escaping, but not quoting. Exec lines can quote because you CAN execute "ls" in a shell and the shell processes the quote to do the execution. Quotes are literally passed on to run. This is a problem with the StartupWMClass as then things are left looking for strings in the window class that literally contain quotes in the class when the app clearly only sets Riot in WM_CLASS in the class field:
WM_CLASS(STRING) = "riot", "Riot"
(xprop adds quotes when it displays the string - the actual property does not contain quotes).
I've had to do a bug workaround in this in code just to have the matching work. :)
Pinned Comments