Arch Linux User Repository

@berquist Implemented. Thanks for the recommendation!

@berquist If that's the correct syntax, then yes, it should. This package used to be exercism-cli and changed to exercism-bin a commits ago.

Should the PKGBUILD have replaces=('exercism-cli')?

@linduxed Awesome :)

Updated the package to 3.0.13. Thank you @patrick96 for your contribution!

Sure, no worries!

@patrick96 Thank you for your work!

I can't have a look at this right away, but I'll get around to it either tomorrow evening or during the weekend.

Hi. I updated the PKGBUILD for this to 3.0.13 and I also switched over to the new release tarball names. You can find it here: https://gist.github.com/patrick96/80f7e9150b8be4ab524330a0763d6dc3

@linduxed feel free to pull this in ;)

The tarball also provides the license file and shell completion so I use it directly from there. And I also copy the zsh and bash completion to the proper location for completion to work out of the box.

I don't know where I should put the fish completion because I never used it so I just didn't include it.

EDIT: I now also included the fish completions after researching where to put them

Oh, yes, sorry, forgot that this is a binary package. Then patching is hard.

@NobbZ: my suspicion is that this version of the package (binary that gets extracted from an archive) can not be patched. The source version of this package probably could be patched, but I have not considered what that would look like.

Regarding the upcoming changes to the package itself: I have not looked at this closely yet, and therefore don't know how to best handle this. I hope to take a look at this during one of the upcoming weekends.

Is there a way to provide a patch during building the package that will disable the upgrade subcommand?

Perhaps leaving the update check in place and replacing the upgrade process of downloading and replacing the binary with printing out something like "A new version has been released, please check https://aur.archlinux.org/packages/exercism-bin for an updated package".

Please also be aware of the fact, that the next release of exercism will probably break this PKGBUILD, as the convention to name the tarballs is going to be changed in the process of enabling automatic releases.

Please see https://github.com/exercism/cli/issues/700#issuecomment-529013140 for details.

It turns out that the zsh completion sourcing problem that I had was caused by me sourcing the files in a faulty manner and a recent update of zsh making this faulty method no longer work.

Problem was solely on my end.

New exercism-bin package is up and I have submitted the request to merge this package into the -bin package.

@Nobbz Regarding completion:

1. Since the PKGBUILD pulls the completion files according to the pkgver, I'm guessing that it'll work out the same.
2. Do you think you one could tweak the PKGBUILD to make the problem with the completion file for zsh go away? I don't fully understand whether this situation necessitates patching the zsh file or not.

@linduxed, @NobbZ

Maybe it is a better idea to make 'merge request' rather than 'deletion request' on this package after creating a new one, because it that way the votes and popularity will be transferred as well.

sounds like a good idea, but unfortunately I don't know the exact procedure of how to do this. There does not seem to be some menu option in the maintainer interface.

Yes, as far as I understand the procedure, it would be creating a new one with a different name, pushing to that with slightly altered PKGBUILD (name) and then deleting this one.

To avoid friction, it might be a good idea to use provides=exercism-cli in the new one.

The design of the zsh completion has been changed, but never really was tested…

I'm not sure if this was before or after 3.0.11.

The old version of the completion was written in a way that sourceing was necessary, the new version can benefit from autoloading and discovery.

The file needs to be renamend to _exercism and copied into the $fpath.

Also, please do not download completion files from master, all three completion files (bash, fish, and zsh) are available in the release tarball.

The latest version seems to result in the following error upon loading:

/usr/share/exercism-cli/completion/exercism_completion.zsh:local:6: options: can't change type of a special parameter

Not sure if this happens to everyone or just me.

Package has now been updated to 3.0.12.

@swalladge: This sounds like a good idea, but unfortunately I don't know the exact procedure of how to do this. There does not seem to be some menu option in the maintainer interface.

Maybe one needs to remove the package and resubmit it with a different name? This thread seems to suggest that to be the case, but it's quite old:

https://bbs.archlinux.org/viewtopic.php?id=76460

Can this be renamed to exercism-bin, since this uses the prebuilt binaries. There is another aur package (exercism) <https://aur.archlinux.org/packages/exercism/> that provides the same software but builds from source.

@pablox I applied your patch, and it seems like the way the two completion files are currently written make them not work automatically, as one would have hoped.

I don't know what the problem is with bash (I just tried tab-completing and it didn't work), but with zsh I'm guessing the slightly different way of organizing the file compared to the rest of the files in "/usr/share/zsh/site-functions" makes it not load it. One of the differences is the lack of starting the file with "#compdef exercism".

I believe the zsh completion should be installed on:

/usr/share/zsh/site-functions/_exercism

and bash on:

/usr/share/bash-completion/completions/exercism

That way, completions works out of the box.

Here's the file to the patch: https://gist.github.com/pablox-cl/a79d3d4d7592f867eac0098d70f5e8e9/raw/a058693de80b33edc4ae3eb66c1b79f01b6b170b/exercism-cli-better-completion

Package has been updated to 3.0.9.

Thank you to Fabrizio Cirelli for reminding me to update, and providing me with the PKGBUILD!

Thank you for the update! This seems to work fine!

Package has been updated to 3.0.6.

Sorry about the delay, real life stuff got in the way!

Thank you to @vitaliel on Github for providing me with the updated PKGBUILD and SRCINFO for this version.

Please be aware of the fact, that the completions haven't been updated since v2.x. So they create false completions, that might not work with the 3.x set of the CLI.

I'm not sure how this will be dealt with upstream.

@hugueschabot: Thank you for notifying me of this! I hope to have the time to update the package during this weekend to the latest version.

@linduxed The shell completion scripts are now included in the tarball. There is no need to download them from http://cli.exercism.io/ anymore.

@linduxed Deleting ~/.cache/pacaur/exercism-cli/ did the trick, thanks!

Could it maybe be a similar problem to that which @antoyo resolved in his comment from 2016-08-23 13:07?

@linduxed Thank you for maintaining this. The bash and zsh completion files are not passing the validity checks when I try to update the package via trizen.

@wezm: Thank you for pointing this out!

The package has been updated.

Looks like the completion files have moved (see http://cli.exercism.io/scripts/). The new URLs are:

http://cli.exercism.io/shell/exercism_completion.bash http://cli.exercism.io/shell/exercism_completion.zsh

Completion files have now been included in the package. Thanks for the suggestion!

As for renaming the package: thanks for pointing this out, good recommendation. I won't be able to get to this right now, however.

...is this a binary (non-compiled) package? if so, it's name should end in "-bin" suffix.