Arch Linux User Repository

@baris-inandi: I think you meant to bump the pkgver from 1.1.5 to 1.1.6? 0 is not a valid pkgver.

@yochananmarqos

I read the vcs package guidelines and came up with this pkgver():

pkgver=0
...
pkgver() {
    cd "$pkgname"
    printf "%s" "$(git describe --tags --long)"
}

However, just adding this function does not update the version. I expected makepkg --printsrcinfo > .SRCINFO to include the latest tag but it shows the version as 0.

@baris-inandi: It appears you missed my edit to my previous comment.

@a821: Aha! Would you believe I never noticed that? The request is cancelled now.

@baris-inandi: You can use a pkgver() function, see VCS package guidelines.

Hey, just implemented git tags using git checkout. I also removed the maintainer variable and replaced it with a comment. (1.0.19)

@baris-inandi: As said, the PKGBUILD is much better. Just minor issues

1. you can easily pin a commit (while you work on the tags) with for example source=("git+$url#commit=ad5db3d79c4ca66e28b79cdd801e088c8c946b52")

2. the maintainer line should be a bash comment, not a variable, eg, # Maintainer: your name <your email> (custom variables in the PKGBUILD need an underscore prefix: _foobar="some value")

@yochananmarqos: btw, you can reject the deletion request yourself ("Requests" tab) to reduce the load of the TUs :)

@baris-inandi: It's much better now, thanks for working on it. Perhaps I was a little hasty filing the deletion request. The request will be rejected since you resolved the issue.

Hey @a821, thank you so much for the help, really appreciate it.

Here's what I did (1.0.14):
- Removed all sudo calls
- Added paru to depends
- Removed bash from makedepends
- Added the config files to backup
- Changed license to "GPL3"
- Now the PKGBUILD uses install properly

I'll try to use git-tags too so that the naming is also appropriate

The PKGBUILD is extremely bad. Please read carefully the Go package guidelines again (link in first comment). There's even a sample PKGBUILD you can mostly copy and paste.

1. This package uses git sources, so it needs the -git suffix, unless you pin a commit or use git-tags.
2. You do not need sudo at all.
3. Use the install command to install files to $pkgdir, for example 'install -Dm755 my_program "$pkgdir/usr/bin/my_program"`
4. If you intend to install paru.conf to /etc then your package will conflict with paru which, I guess, is not what you want.
5. If your package needs paru, add it to the depends array.
6. If your package installs files that could be modified by the user (eg, files in /etc), then add those files to the backup array.
7. bash is not required in makedepends as it is provided by base-devel (which it is assumed to be installed) via pacman
8. license should be simply GPL3 (no "v")

Hello, does the PKGBUILD look right now? I'm still calling sudo for go build on the build() function, should sudo be avoided entirely?