Package Details: ffsend 0.2.37-1

Git Clone URL: https://aur.archlinux.org/ffsend.git (read-only)
Package Base: ffsend
Description: Easily and securely share files from the command line. A Firefox Send client.
Upstream URL: https://gitlab.com/timvisee/ffsend
Keywords: cli encryption file-sharing file-upload firefox firefox-send rust send
Licenses: GPL3
Conflicts: ffsend-git
Submitter: timvisee
Maintainer: timvisee
Last Packager: timvisee
Votes: 6
Popularity: 4.690650
First Submitted: 2019-01-12 22:10
Last Updated: 2019-03-18 23:06

Dependencies (2)

Required by (0)

Sources (1)

Latest Comments

timvisee commented on 2019-03-13 12:28

@ogarcia All right! Planning to change that soon. Created an issue for it over at gitlab/timvisee/ffsend.

ogarcia commented on 2019-03-13 12:27

@timvisee this package must be renamed to ffsend-bin since is based in a binary source file (and have a valid sha256sum). The package that you called ffsend-git must be this package. If you want to maintain a ffsend-git then the source must be the git master branch, not a tag archive and have pkgver() function. You can look my package numix-cursor-theme-git as sample of a -git package.

timvisee commented on 2019-03-13 11:34

@physkets Thank you for the heads up. I decided to use -git in the end, as that seemed more common (versus -bin) judged by the package counts. What do others think?

physkets commented on 2019-03-13 07:58

I think it is good practice to have a '-bin' suffixing the name, because people will assume that it is being built from source unless mentioned.

emlun commented on 2019-03-12 17:52

Yeah, that makes sense. I know many other packages use a remotely hosted binary, but I feel like many of them are very large programs that would take an impractically long time to compile (Chromium or Firefox, for example). Anyway, if you've thought about it and concluded this is the best way to go then that's cool. That's why I included the "if you agree" part. :)

I tried ffsend-git too but hit a snag, I'll add a comment to that package.

timvisee commented on 2019-03-12 15:23

@emlun Thank you!

I interpreted the Wiki as: submitting binaries should be avoided to the AUR git repository (to prevent it from growing too large too fast). Many other AUR packages are using a remotely hosted binary.

I also have ffsend-git available which builds from source. It can be quite flaky though, due to the cargo dependency not really allowing you to set a required version. Therefore I decided to submit a binary package as well, which won't have any build issues.

What do you think?

emlun commented on 2019-03-12 15:13

This is really cool! Thanks!

However, quoting the Arch Wiki on AUR:

Submitting binaries should be avoided if the sources are available. [...]

So I think it's preferable to build the program from sources rather than downloading a prebuilt binary. If you agree, you can use this patch for that:

diff --git a/PKGBUILD b/PKGBUILD
index 5818831..6a92071 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -7,12 +7,17 @@ pkgdesc="Easily and securely share files from the command line. A Firefox Send c
 url="https://gitlab.com/timvisee/ffsend"
 license=('GPL3')
 conflicts=('ffsend-git')
-source=("ffsend::https://github.com/timvisee/ffsend/releases/download/v$pkgver/ffsend-v$pkgver-linux-x64-static")
-sha256sums=('SKIP')
+source=("ffsend::https://github.com/timvisee/ffsend/archive/v$pkgver.tar.gz")
+sha256sums=('271ab5595e96ca93ef10e50c6a136cf9fdd73498ddd9a5ea3a8f5ead63e3c3e1')
 arch=('x86_64')
 depends=('ca-certificates')
 optdepends=('xclip: clipboard support')

+build() {
+    cd "${srcdir}/ffsend-${pkgver}"
+    cargo build --release
+}
+
 package() {
-    install -D "$srcdir/ffsend" "$pkgdir/usr/bin/ffsend"
+    install -D "${srcdir}/ffsend-${pkgver}/target/release/ffsend" "$pkgdir/usr/bin/ffsend"
 }