hey @icedream, sadly I still get the error regarding the service file with the wrong path. the github issue is closed, what is the status here?
Search Criteria
Package Details: fw-fanctrl-git 1.0.0.r7.e2a2eb9-2
Package Actions
Git Clone URL: | https://aur.archlinux.org/fw-fanctrl-git.git (read-only, click to copy) |
---|---|
Package Base: | fw-fanctrl-git |
Description: | A simple systemd service to better control Framework Laptop's fan(s) |
Upstream URL: | https://github.com/TamtamHero/fw-fanctrl |
Licenses: | BSD-3 |
Conflicts: | fw-fanctrl |
Provides: | fw-fanctrl |
Submitter: | icedream |
Maintainer: | icedream |
Last Packager: | icedream |
Votes: | 7 |
Popularity: | 1.03 |
First Submitted: | 2023-07-04 00:25 (UTC) |
Last Updated: | 2025-03-03 08:22 (UTC) |
Dependencies (9)
- fw-ectool-gitAUR
- python (python37AUR)
- python-jsonschema
- python-watchdog (python-watchdog-gitAUR)
- git (git-gitAUR, git-glAUR) (make)
- python-build (make)
- python-installer (make)
- python-setuptools (make)
- python-wheel (make)
Required by (1)
- fw-fanctrl-ui-git (requires fw-fanctrl)
Sources (1)
hasechris commented on 2025-05-26 19:36 (UTC)
icedream commented on 2025-04-05 18:03 (UTC)
@xorly Thanks for reporting! As there's now a GitHub issue to track this I'll put what I find there, but I'll have to check what's wrong first later.
xorly commented on 2025-03-14 17:03 (UTC) (edited on 2025-03-14 17:37 (UTC) by xorly)
The --dest-dir "${pkgdir}" \
is causing a problem, because .service is using PYTHON_SCRIPT_INSTALLATION_PATH
which is set to PYTHON_SCRIPT_INSTALLATION_PATH="$DEST_DIR$PREFIX_DIR/bin/fw-fanctrl"
and something like
ExecStart=/usr/bin/python3 "/home/user/.cache/paru/clone/fw-fanctrl-git/pkg/fw-fanctrl-git/usr/bin/fw-fanctrl" --output-format "JSON" run --config "/etc/fw-fanctrl/config.json" --silent
Ends up in the systemd service file.
DEST_DIR
is used several time in that install.sh script for copying of some some stuff, so in most cases it is correct. I think, we may have to patch the resulting service file or solve it with upstream.
Opened issue: https://github.com/TamtamHero/fw-fanctrl/issues/129
icedream commented on 2025-03-03 08:23 (UTC)
@Mikescher Good catch, thank you! Not sure why I put it into makedepends instead of depends but I've fixed it now.
Mikescher commented on 2025-03-03 08:18 (UTC) (edited on 2025-03-03 08:18 (UTC) by Mikescher)
I think python-jsonschema should be a normal dependency, instead of a make-only dependency.
Otherwise I get an error executing fw-fanctrl in Configuration.py [1].
The dependency was added last week in commit b7309 [2]
[1] https://github.com/TamtamHero/fw-fanctrl/blob/main/src/fw_fanctrl/Configuration.py
[2] https://github.com/TamtamHero/fw-fanctrl/commit/e4bfe9fd9eda386dbf6bc3975ee5013705fb7e09#diff-2ba53b33af817afae5d7a93641c6addefcdd3853d4453f584784eec793fc3a74R6
icedream commented on 2025-02-25 06:22 (UTC)
There is now a version of this package that will give you the released version instead of latest Git: https://aur.archlinux.org/packages/fw-fanctrl
icedream commented on 2025-02-25 05:56 (UTC)
There was a recent issue with the package build failing due to a missing .whl file. A workaround has been put in place.
Further discussion will happen in https://github.com/TamtamHero/fw-fanctrl/issues/111 for a longer-term fix.
icedream commented on 2025-02-11 08:02 (UTC)
@Nashenas I've reverted the enabling of pytest for now. Will need to check which dependencies I need for this to work properly at a later point.
Nashenas commented on 2025-02-11 05:05 (UTC)
The latest version is failing for me. It has an unspecified build dependency on the python-pytest package. I installed it manually but it still fails with:
Successfully built fw_fanctrl-1.0.0-py3-none-any.whl
==> Starting check()...
============================================================ test session starts ============================================================
platform linux -- Python 3.13.1, pytest-8.3.4, pluggy-1.5.0 -- /usr/bin/python
cachedir: .pytest_cache
rootdir: /home/user/.cache/paru/clone/fw-fanctrl-git/src/fw-fanctrl
configfile: pyproject.toml
collected 0 items
=========================================================== no tests ran in 0.03s ===========================================================
==> ERROR: A failure occurred in check().
Aborting...
error: failed to build 'fw-fanctrl-git-1.0.0.r4.b37bd3b-6':
icedream commented on 2025-02-10 17:30 (UTC)
The issue with the missing bin script has been solved.
In detail: Problem was the order of install steps - the remaining part of the install script being used deleted the file due to legacy procedures.
I plan in the coming days to coordinate to which degree I should continue to rely on the script but for now this package is back working.
Pinned Comments
icedream commented on 2025-02-25 06:22 (UTC)
There is now a version of this package that will give you the released version instead of latest Git: https://aur.archlinux.org/packages/fw-fanctrl
icedream commented on 2025-02-25 05:56 (UTC)
There was a recent issue with the package build failing due to a missing .whl file. A workaround has been put in place.
Further discussion will happen in https://github.com/TamtamHero/fw-fanctrl/issues/111 for a longer-term fix.