Package Details: ghfetch 1.5.4-1

Git Clone URL: https://aur.archlinux.org/ghfetch.git (read-only, click to copy)
Package Base: ghfetch
Description: A nice way to display CLI Github user / repo / organization info inspired in neofetch
Upstream URL: https://github.com/ghfetch/ghfetch
Licenses: MIT
Submitter: ghfetch
Maintainer: ghfetch
Last Packager: ghfetch
Votes: 1
Popularity: 0.002962
First Submitted: 2023-07-13 21:47 (UTC)
Last Updated: 2024-04-08 20:44 (UTC)

Latest Comments

m040601 commented on 2024-02-29 19:00 (UTC) (edited on 2024-02-29 19:49 (UTC) by m040601)

Thanks for your work on this interesting tool. It's a good idea and can be usefull.

But your PKGBUILD still needs some polish. And you should make sure you test it yourself before uploading to the AUR. Also make sure that you are aware of all the Archwiki pages that exist related to AUR/PKGBUILDS,A

If you are not a daily Archlinux user yourself, I advise you to just search the AUR for other similar python tools "python-xxx" and see how they manage the PKGBUILD.

Here are some corrections and suggestions:

This is what you are currently "stuffing" in the user's computer:

pacman -Ql ghfetch

ghfetch /usr/
ghfetch /usr/bin/
ghfetch /usr/bin/ghfetch
ghfetch /usr/lib/
ghfetch /usr/lib/ghfetch/
ghfetch /usr/lib/ghfetch/.env.example
ghfetch /usr/lib/ghfetch/__init__.py
ghfetch /usr/lib/ghfetch/data/
ghfetch /usr/lib/ghfetch/data/__init__.py
ghfetch /usr/lib/ghfetch/data/language-colors.json
ghfetch /usr/lib/ghfetch/main.py
ghfetch /usr/share/
ghfetch /usr/share/doc/
ghfetch /usr/share/doc/ghfetch
ghfetch /usr/share/licenses/
ghfetch /usr/share/licenses/ghfetch

$ file /usr/share/doc/ghfetch
/usr/share/doc/ghfetch: Unicode text, UTF-8 text


$ file /usr/share/licenses/ghfetch
/usr/share/licenses/ghfetch: ASCII text

Those two are wrong. You created a file "ghfetch". You should not put "files" in /usr/share/doc or /usr/share/licences. What you want is to create a folder "ghfetch" and then put the readme's and licence there.

Like this,

/usr/share/doc/ghfetcher/README.md
/usr/share/licences/ghfetcher/LICENCE

So you need to edit,

32     install -D -m 644 ./README.md "${pkgdir}/usr/share/doc/${pkgname}"
33     install -D -m 644 ./LICENSE "${pkgdir}/usr/share/licenses/${pkgname}"


  Description:   A nice way to display CLI Github user / repo / organization info inspired in neofetch

Why dont you puth the word python in that description ? There sooooooo many tools on the AUR to deal with github, this would make it easier for AUR users browsing and searching for stuff.

Regarding the name of the PKGBUILD. I would have personally have named it, the PKGBUILD that is, not the tool you develop, "python-ghfetch". The installed binary is still called "/usr/bin/ghfetch" but the PKGBUILD is called "python-ghfetch".

It is more according to the AUR guidelines for python-projects. There is a wiki page with recomendations also.

ghfetch commented on 2023-07-15 00:42 (UTC)

Hello FabioLolix,

I've reuploaded the repo with the new suffix ghfetch-git as you said.

Still having issues to fix.

It looks like it's unable to do the cd $pkgname because now its value is ghfetch-git while the git clone of the repo creates the folder ghfetch without the suffix.

What could be the possibilities to fix it? Change the command cd manually? Somehow clone the repo but specifing the folder name?

Additionally, we wouldn't like to change the Github repo name.

Thanks in advance.

ghfetch commented on 2023-07-14 22:52 (UTC)

Hello FabioLolix,

We just saw your messages.

First of all, thank you so much for all of the fixes that you gave us.

We were struggling trying to fix the build and saw the comments just now!

We'll do all the changes and build the fix release.

FabioLolix commented on 2023-07-14 11:23 (UTC)

About the build:

==> Starting build()...
/usr/lib/python3.11/site-packages/setuptools/dist.py:745: SetuptoolsDeprecationWarning: Invalid dash-separated options
!!

        ********************************************************************************
        Usage of dash-separated 'description-file' will not be supported in future
        versions. Please use the underscore name 'description_file' instead.

        By 2023-Sep-26, you need to update your project and remove deprecated calls
        or your builds will no longer be supported.

        See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
        ********************************************************************************

!!
  opt = self.warn_dash_deprecation(opt, section)
running build

FabioLolix commented on 2023-07-14 11:21 (UTC)

  • please remove epoch= it is not needed, bumping pkgrel is enough, epoch is used to let see a downgrade as an upgrade, since this pkgbuild has been up for 1 day only this isn't a problem
  • does this really need python-pip to run?
  • you don't have to specify dependency versions, users need to upgrade their system before complaining to AUR pakcagers. i.e. python>=3.6.0 python is on that version since December 2016 on Arch
  • source is not correctly fetched, need to be source=('git+https://github.com/ghfetch/ghfetch.git'), how it is now it fetch an html page
  • please remove setup.cfg and setup.py from AURWeb, that need to be downloaded from source, don't use AUR git repos as github
  • build is broken because of cd "../../$pkgname", need to be cd "$pkgname"
  • for arch=() please use arch=(any), namcap output: ghfetch W: No ELF files and not an "any" package
  • A license like MIT which isn't part of the licenses package need to be installed in "${pkgdir}/usr/share/licenses/${pkgname}"

FabioLolix commented on 2023-07-13 22:38 (UTC)

Hello,