Arch Linux User Repository

I get an error with a missing help-functions.bash script:

/usr/bin/git-subrepo: line 1941: /git-subrepo.d/help-functions.bash: No such file or directory

Also tests fail when commit.gpgsign or tag.gpgsign are set to true.

This can be disabled by setting environment variables: GIT_CONFIG_COUNT=2 GIT_CONFIG_KEY_0=commit.gpgsign GIT_CONFIG_VALUE_0=false GIT_CONFIG_KEY_1=tag.gpgsign GIT_CONFIG_VALUE_1=false makepkg

However, It would be best if the script did this automatically before running the tests ;)

Tests pass on my end. Make sure you use a clean chroot.

Packaging fails due to test failures:

Test Summary Report
-------------------
test/issue96.t                   (Wstat: 0 Tests: 2 Failed: 1)
  Failed test:  2
test/pull-merge.t                (Wstat: 0 Tests: 8 Failed: 0)
  Parse errors: No plan found in TAP output
test/pull-ours.t                 (Wstat: 0 Tests: 4 Failed: 0)
  Parse errors: No plan found in TAP output
test/pull-theirs.t               (Wstat: 0 Tests: 3 Failed: 0)
  Parse errors: No plan found in TAP output
test/push.t                      (Wstat: 0 Tests: 0 Failed: 0)
  Parse errors: No plan found in TAP output
Files=36, Tests=293, 100 wallclock secs ( 0.11 usr  0.06 sys + 39.61 cusr 33.65 csys = 73.43 CPU)
Result: FAIL
make: *** [Makefile:49: test] Error 1
make: Leaving directory '/home/abody/.cache/yay/git-subrepo/src/git-subrepo'
==> ERROR: A failure occurred in check().
    Aborting...
 -> error making: git-subrepo-exit status 4
 -> Failed to install the following packages. Manual intervention is required:
git-subrepo - exit status 4

The names of everyone who maintained the package in the past are in the git history.

I'm happy to give credit to anyone who submits patches/PRs, but no one else contributed here. This entire PKGBUILD was written from scratch (see git blame/log).

Please do not remove the old "Maintainer: ..." line but instead add them as Contributor :)

https://aur.archlinux.org/cgit/aur.git/commit/?h=git-subrepo&id=77ac48ff56514832ebee4fb045abd059edede820

This PKGBUILD should now address all of the applicable issues, and splits off the helper library bashplus into its own dependency.

I fixed some of the issues (missing backup entry, broken .SRCINFO) in the comments; regarding FHS conformance I thought it would be quite simple at first, but upstream's scripts are frankly absurd and use arbitrary environment variables to declare imports of other scripts. Not to mention upstream bundles two other projects with this one (via git-subrepo) that need to be extricated into their own packages. Upstream's Makefile is broken as well and doesn't install most of the necessary files either.

I've looked at the other PKGBUILD but I don't think it addresses the issue of brittle dependencies, and actually fixing this seems to require extensive patching. Which I'm fine doing, I was just curious if someone had already done so.

I submitted an orphan request in part because I was willing to fix this. Why did you adopt it if the issues already expressed in comments were not something you were ready to fix? Also there is a complete alternate PKGBUILD in comments that doesn't use /opt. It has other issues but maybe get some ideas from there.

This package seems to be quite the mess due to how upstream has organised the project in such a way that it expects everything to sit in the same folder.

I at least updated some parts that don't make sense, but I'll eventually want to make this properly follow FHS instead of shoving everything in /opt. If anyone has suggestions, please feel free to post a link to a pastebin patch or submit a PR at https://github.com/eclairevoyant/aur-packages

Also the RC file needs to be installed with backups, and my previous comments have not been addressed.