Package Details: gklib 5.1.1-4

Git Clone URL: https://aur.archlinux.org/gklib.git (read-only, click to copy)
Package Base: gklib
Description: A library of various helper routines and frameworks used by many of the lab's software
Upstream URL: https://github.com/KarypisLab/GKlib
Licenses: Apache
Submitter: carlosal1015
Maintainer: carlosal1015
Last Packager: carlosal1015
Votes: 10
Popularity: 0.44
First Submitted: 2023-02-20 02:53 (UTC)
Last Updated: 2023-08-07 23:32 (UTC)

Latest Comments

carlosal1015 commented on 2023-08-11 12:19 (UTC) (edited on 2023-08-11 12:22 (UTC) by carlosal1015)

Thank you @sgizoid, looks like these variables are not exact? in this compilation.

What is the output of $(shell uname -m | sed "s/\\ /_/g") and $(shell uname -s) in your case and with the suggestion? I tried with bash.

sgizoid commented on 2023-08-11 05:59 (UTC) (edited on 2023-08-11 05:59 (UTC) by sgizoid)

build() is failing due to something wrong with the wrapper makefile for cmake, bypassing the run-config section like this works to get it building:

build() {
  cd ${_base}-METIS-v${pkgver}-DistDGL-0.5
  mkdir -p build/$(uname -s)-$(uname -m)
  cd build/$(uname -s)-$(uname -m)
  cmake ../../
}

calcmogul commented on 2023-08-07 23:24 (UTC)

You can change the default generator with "export CMAKE_GENERATOR=Ninja" prior to the cmake configure. I stuck it in my .bashrc so it applies globally.

The original CMake commands worked for me at least. Are the default build and install targets doing the wrong thing?

carlosal1015 commented on 2023-08-07 23:18 (UTC)

Thanks for the report @calcmogul. I'm thinking of modifying CMakeLists.txt or Makefile to add like -DCMAKE_GENERATOR='Unix Makefiles' or -DCMAKE_MAKE_PROGRAM='/usr/bin/make'. Do you know how can I set up ninja as a default build generator for testing purposes. Thanks.

calcmogul commented on 2023-08-07 17:02 (UTC)

The recent changes to use "make" instead of "cmake --build" and "cmake --install" break users who don't have "make" configured as their default build generator.

See section 5 of https://wiki.archlinux.org/title/CMake_package_guidelines for the recommended template that's agnostic to whether make or ninja is used.

carlosal1015 commented on 2023-08-07 02:24 (UTC) (edited on 2023-08-07 02:52 (UTC) by carlosal1015)

I am not sure why

/tmp/makepkg/gklib/src/build/test/strings
[1]    6427 segmentation fault  /tmp/makepkg/gklib/src/build/test/strings

maybe something is wrong with strings.c.

Edited: with gklib 5.1.1-4, the test is running well.

A_Bart commented on 2023-08-01 07:50 (UTC)

Hello @carlosal1015, thanks for the quick patch! It compiles now. The flag from the article you linked is a different one. -pg is available in clang, the problem is that it is not used, and clang considers unused flags as errors by default. I see that flag is added when you turn -DGPROF=ON which should not be in a production build, it's just used for profiling.

carlosal1015 commented on 2023-07-31 15:47 (UTC) (edited on 2023-07-31 15:49 (UTC) by carlosal1015)

Hi @A_Bart, maybe I can explicit change to use gcc compiler. Looks like the some flags for gcc are not in clang. https://stackoverflow.com/a/14248722

A_Bart commented on 2023-07-31 08:29 (UTC) (edited on 2023-07-31 08:31 (UTC) by A_Bart)

Hello, I get an error when compiling with clang:

[ 56%] Linking C shared library libGKlib.so
clang-15: error: argument unused during compilation: '-pg' [-Werror,-Wunused-command-line-argument]
make[2]: *** [CMakeFiles/GKlib.dir/build.make:481: libGKlib.so] Error 1
make[1]: *** [CMakeFiles/Makefile2:118: CMakeFiles/GKlib.dir/all] Error 2

I can force my clang to ignore unused command line argument but maybe it's worth patching.