Arch Linux User Repository

@alerque tyvm! That's definitely made for a cleaner PKGBUILD. I originally based this on the gitlab-glab package, but I see a lot changed when it was migrated to the official repos.

Actually there are quite a few issues with this PKGBUILD. It doesn't follow the Arch guidelines on fields at all. The generated binary doesn't have RELRO support because the wrong Go flags are setup. It isn't reproducible because the date field doesn't take that support into account. And so forth.

I've cleaned it up so it builds in a clean chroot and follows all or most Arch packaging guidance. Here is a patch you can save to a file and apply to your Git repo with git am file.patch:

From c3dee3d732fde29d6a85cba2254dc310756d604a Mon Sep 17 00:00:00 2001
From: Caleb Maclennan <caleb@alerque.com>
Date: Sun, 30 Oct 2022 10:41:32 +0300
Subject: [PATCH] Overhaul package to fix Go flags, reproducible builds,
 dependencies, and Arch package guidelines

Signed-off-by: Caleb Maclennan <caleb@alerque.com>
---
 .SRCINFO |  9 ++++----
 PKGBUILD | 65 +++++++++++++++++++++++++-------------------------------
 2 files changed, 34 insertions(+), 40 deletions(-)

diff --git a/.SRCINFO b/.SRCINFO
index b229696..0dbed66 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,16 +1,17 @@
 pkgbase = glab-git
    pkgdesc = Cli tool to help work seamlessly with Gitlab from the command line
    pkgver = 1.22.0.r168.g11a81099
-   pkgrel = 1
+   pkgrel = 2
    url = https://gitlab.com/gitlab-org/cli
    arch = x86_64
    license = MIT
+   makedepends = git
    makedepends = go
    depends = glibc
-   provides = glab
+   provides = glab=1.22.0.r168.g11a81099
    conflicts = glab
    replaces = gitlab-glab-git
-   source = git+https://gitlab.com/gitlab-org/cli.git
-   md5sums = SKIP
+   source = glab-git::git+https://gitlab.com/gitlab-org/cli.git
+   sha256sums = SKIP

 pkgname = glab-git
diff --git a/PKGBUILD b/PKGBUILD
index 864eb98..6999206 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,60 +1,53 @@
 # Maintainer: Samuel Collins <samuel.collins@live.co.uk>
 # Co-Maintainer: Bradley Garrod <bradleybredgarrod@gmail.com>
+# Contributor: Caleb Maclennan <caleb@alerque.com>

 pkgname=glab-git
-_reponame=cli
 pkgver=1.22.0.r168.g11a81099
-pkgrel=1
-epoch=
-pkgdesc="Cli tool to help work seamlessly with Gitlab from the command line"
+pkgrel=2
+pkgdesc='Cli tool to help work seamlessly with Gitlab from the command line'
 arch=(x86_64)
 url="https://gitlab.com/gitlab-org/cli"
-license=('MIT')
-groups=()
+license=(MIT)
 depends=(glibc)
-makedepends=(go)
-checkdepends=()
-optdepends=()
-provides=(glab)
+makedepends=(git
+             go)
+provides=("glab=$pkgver")
 conflicts=(glab)
 replaces=(gitlab-glab-git)
-backup=()
-options=()
-install=
-changelog=
-source=(git+$url.git)
-noextract=()
-md5sums=(SKIP)
-validpgpkeys=()
+source=("$pkgname::git+$url.git")
+sha256sums=(SKIP)

 pkgver() {
-    cd "${_reponame}"
+    cd "$pkgname"
     git describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'
 }

 prepare(){
-  cd "${_reponame}"
-  mkdir -p build/
+    cd "$pkgname"
+    mkdir -p build
 }

 build() {
-  export GOPATH="$srcdir"/gopath
-  cd "${_reponame}"
-  export CGO_CPPFLAGS="${CPPFLAGS}"
-  export CGO_CFLAGS="${CFLAGS}"
-  export CGO_CXXFLAGS="${CXXFLAGS}"
-  export CGO_LDFLAGS="${LDFLAGS}"
-  _builddate=$(date -u +%m/%d/%Y)
-  go build -o build -trimpath -buildmode=pie -ldflags "-extldflags \"${LDFLAGS}\" -X main.version=v${pkgver} -X main.build=${_builddate} -X main.usageMode=prod -s -w" -modcacherw ./cmd/glab/main.go
+    cd "$pkgname"
+    export GOPATH="$srcdir"/gopath
+    local _date=$(date +'%Y/%m/%d' ${SOURCE_DATE_EPOCH:+-d @$SOURCE_DATE_EPOCH})
+    go build \
+      -trimpath \
+      -buildmode=pie \
+      -modcacherw \
+      -ldflags "-linkmode external -extldflags \"$LDFLAGS\" -X main.version=v$pkgver -X main.build=$_date -X main.usageMode=prod -s -w" \
+      -o build \
+      ./cmd/glab/main.go
 }

 package() {
-  cd "${_reponame}"
-  install -Dm755 build/main "$pkgdir"/usr/bin/glab
-  install -Dm644 $srcdir/${_reponame}/LICENSE "$pkgdir/usr/share/licenses/${pkgname}/LICENSE"
+    cd "$pkgname"
+    install -Dm0755 build/main "$pkgdir/usr/bin/glab"
+    install -Dm0644 -t "$pkgdir/usr/share/licenses/$pkgname/" LICENSE

-   # Shell completions
-   build/main completion -s bash | install -Dm644 /dev/stdin "${pkgdir}/usr/share/bash-completion/completions/glab"
-   build/main completion -s zsh | install -Dm644 /dev/stdin "${pkgdir}/usr/share/zsh/site-functions/_glab"
-   build/main completion -s fish | install -Dm644 /dev/stdin "${pkgdir}/usr/share/fish/vendor_completions.d/glab.fish"
+    # Shell completions
+    build/main completion -s bash | install -Dm0644 /dev/stdin "$pkgdir/usr/share/bash-completion/completions/glab"
+    build/main completion -s zsh  | install -Dm0644 /dev/stdin "$pkgdir/usr/share/zsh/site-functions/_glab"
+    build/main completion -s fish | install -Dm0644 /dev/stdin "$pkgdir/usr/share/fish/vendor_completions.d/glab.fish"
 }
-- 
2.38.1

Thanks!

One more thing: this is missing makedepends=(git) which is required to build.

Please update this to the new upstream repository location, it no longer builds the latest code since the repo moved to GitLab.