Arch Linux User Repository

@uffe Thanks, just removed git as a makedepend.

I just built this package (gotop 3.0.0-3) with success on a server without git installed. I had no problems at all.

I do not see why "git" is mentioned as a makedepend requirement ?

Hi @FabioLolix,

I've added a desktop entry and icon so that it can be run from a DE directly.

I've also removed the provides= redundancy mentioned by @willemw. According to this wikipage, provides= is redundant as $pkgname will always implicitly add itself, but conflicts= isn't because multiple packages that provide the same feature can be installed as long as they don't conflict.

Here's the patch, you can apply it with git am gotop.patch.

provides=(gotop)
conflicts=(gotop)

are redundant.

Great. Thank you.

@egrupled Thanks for pointing out the issues. The PKGBUILD has been updated and fixed. To fix the GOPATH issue, I added -mod vendor to the build flags instead of modifying the GOPATH env variable, since gotop vendors all of its dependencies. I was under the impression that go build defaulted to using the vendor directory, but apparently you have to explicit opt into that at least when using go modules.

There are couple issues with the current PKGBUILD:

1. It creates persistent ~/go dir (with default GOPATH) and download all dependencies there. Moreover files in that dir are set as read-only.

2. It doesn't honor LDFLAGS

Below is example which fixes this issue:

1. It sets GOPATH to temporary directory under build dir.

2. It take LDFLAGS into account, also strips build path for reproducibility[1].

3. It makes temporary GOPATH writable which allows for clean up.

[1] https://wiki.archlinux.org/index.php/Go_package_guidelines#Flags_and_build_options

Please consider adopting those changes.

build() {
  cd "${srcdir}"/${pkgname}-${pkgver}
  export GOPATH="$srcdir/gopath"
  go build \
  -gcflags "all=-trimpath=${PWD}" \
  -asmflags "all=-trimpath=${PWD}" \
  -ldflags "-extldflags ${LDFLAGS}"
}

package() {
  export GOPATH="$srcdir/gopath"
  install -Dm755 "${srcdir}"/${pkgname}-${pkgver}/gotop "${pkgdir}"/usr/bin/gotop
  chmod -R 644 "$GOPATH"
}

@The999eagle Building should be fixed now.

@dude Added git to makedepends.

@egrupled Removed Go version.

Sorry about the delay. Forgot to enable notifications :doh:

Please change "go>=1.11.0" to "go" in depends otherwise it break building with go-pie. Versioned deps doesn't make sense in Arch as there is only one "go" version in repos and partial upgrades aren't supported

Can you add the git package to makedepends please? If it's not installed, the build will fail:

-> Extracting gotop-2.0.1.tar.gz with bsdtar
==> Starting build()...
go: github.com/stretchr/testify@v1.2.2: git init --bare in /build/go/pkg/mod/cache/vcs/ed2f58bca3966d01dc4666baa48276a4fab360938a8d941050d58e371e2bba77: exec: "git": executable file not found in $PATH