Arch Linux User Repository

Can we have an r prefix in the version number to denote the number of commits difference since the listed tag from git describe --tags? This is what the s/\([^-]*-g\)/r\1/ portion is for on https://wiki.archlinux.org/title/VCS_package_guidelines#Git:

git describe --long | sed 's/\([^-]*-g\)/r\1/;s/-/./g'

Thanks!

The git package is missing in the makedepends, as per https://wiki.archlinux.org/title/PKGBUILD#makedepends

Otherwise, one can't build this package in a clean chroot.

Would you consider installing the completions: https://github.com/helix-editor/helix/tree/master/contrib/completion

e.g. fish should go into /usr/share/fish/completions/ probably

This package conflicts with community/hex, which already contains /usr/bin/hx

A single rm -r "${pkgdir}${_rt_path}/grammars/sources" at the end of package() removes the extra unnecessary files and has been working for me.

I think this package's PKGBUILD should use a package() more similar to the one used for the official repository's PKGBUILD for helix: https://github.com/archlinux/svntogit-community/blob/packages/helix/trunk/PKGBUILD

Currently, helix-git pulls in sources of the "runtime/grammars" as well as each source's .git directories, adding unneeded additional files to the resulting package. This doesn't happen in helix's PKGBUILD. I tested adding a find command to delete the unnecessary files/dirs in the end of package(), and that significantly reduces the file-size of the resulting package without breaking helix.

@djemil, interesting suggestion, thanks. Not doing the --abbrev=0 is probably even better since it gets rid of the rev-parse and probably obsoletes the rev-list too.

@wsippel, building with (fat) lto seems to work just fine for me, besides the obvious slower compilation time.

Might be a good idea to override the lto build option set in makepkg.conf for this package? options=('!lto') should work I believe. Helix builds with thin lto by default anyway, but fails with fat lto, which is what the global setting appears to force.

replace: printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)" with: printf "%s.r%s.%s" "$(git describe --tags --abbrev=0)" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)" | sed 's/^v//;s/-/./g'

to fix version example: helix-22.08.1.r3767.0b2bb061b-1 vs helix-r3731.652497bd-1

To fix the blank screen, you need to remove the --all-features flag being passed to cargo build. In particular, it enables the --features integration flag, which enables integration testing and disables rendering.