Arch Linux User Repository

gcc-libs is deprecated, use libgcc, libstdc++ dependencies instead

Well, it landed in extra after all, so further comments should be directed there...

It appears that this package has been at least partially abandoned by the maintainer. Several best-practice build improvements previously suggested by xantares in earlier comments have been ignored, and the new feature introduced in HiGHS 1.12, namely the HiPO LP solver, is currently not enabled in this PKGBUILD.

@x2b, would you be willing to improve and maintain this package accordingly, or consider transferring maintenance to someone who is willing to actively maintain it?

This doesn't succeed at installation for me. It fails to set the installation prefix correctly. It seems to install the h files in the .yay folder. I can't tell exactly what the error is.

also the new solver is not enabled: -DHIPO=ON

hi, could you add -DCMAKE_UNITY_BUILD=ON option to speed up builds ?

no need to specify CMAKE_C[XX]_FLAGS variables, it automatically uses CFLAGS, CXXFLAGS etc from the environment variables set by makepkg

Sorry about the late reply, the build is now generator agnostic. However, the flags seem to have to be set manually for some reason, otherwise namcap shows corresponding warnings.

Thank you for providing this package. Unfortunately, the package unconditionally assumes (Unix) Makefiles CMake generator which causes the following error every time I update:

-- Configuring done (2.4s)
-- Generating done (0.0s)
-- Build files have been written to: /home/<user>/Projects/highs/src/HiGHS-1.7.1/build
==> Starting build()...
make: *** No targets specified and no makefile found.  Stop.
==> ERROR: A failure occurred in build().
    Aborting...

because I have CMAKE_GENERATOR=Ninja defined in my ~/.bashrc.

Resolving this issue requires replacing all make calls either by cmake --build or cmake --install to be generator agnostic. I suggest the following changes:

diff --git a/PKGBUILD b/PKGBUILD
index eb34216..66e1109 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -14,30 +14,22 @@ source=("https://github.com/ERGO-Code/HiGHS/archive/refs/tags/v${pkgver}.tar.gz"
 sha256sums=('65c6f9fc2365ced42ee8eb2d209a0d3a7942cd59ff4bd20464e195c433f3a885')

 prepare() {
-    cd "$srcdir/${_pkgname}-${pkgver}"
-    mkdir -p "build"
-    cd "build"
-
-    cmake \
-      -DCMAKE_EXE_LINKER_FLAGS=$LDFLAGS \
-      -DCMAKE_SHARED_LINKER_FLAGS=$LDFLAGS \
-      -DCMAKE_INSTALL_PREFIX=/usr \
-      ..
+    cmake -S "$srcdir/${_pkgname}-${pkgver}" \
+      -B "$srcdir/${_pkgname}-${pkgver}/build" \
+      -DCMAKE_INSTALL_PREFIX=/usr
 }

 build() {
-    cd "$srcdir/${_pkgname}-${pkgver}/build"
-    make
+    cmake --build "$srcdir/${_pkgname}-${pkgver}/build"
 }

 check() {
-    cd "$srcdir/${_pkgname}-${pkgver}/build"
-    make test
+    cmake --build "$srcdir/${_pkgname}-${pkgver}/build" \
+          --target test
 }

 package() {
-    cd "$srcdir/${_pkgname}-${pkgver}/build"
-    make DESTDIR="$pkgdir/" install
+    DESTDIR="$pkgdir/" cmake --install "$srcdir/${_pkgname}-${pkgver}/build"

     cd "$srcdir/${_pkgname}-${pkgver}"
     install -Dm644 LICENSE.txt "$pkgdir/usr/share/licenses/$pkgname/LICENSE"

I took here the liberty to further simplify the build recipe. Particularly, setting linker flags is unnecessary since CMake pulls these from LDFLAGS anyway.

@ducakar: Sorry for the late reply. To improve build times I suggest you visit the makepkg page in the wiki:

https://wiki.archlinux.org/title/Makepkg

The TLDR is that you should set MAKEFLAGS="-j<N>" in /etc/makepkg.conf to enable parallel compilation system wide for your machine, which should make more sense than fiddling with individual packages (and including ninja as additional dependency).